From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE857359F90 for ; Tue, 27 Jan 2026 13:41:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769521300; cv=none; b=FiSVJX1oMQZIRgMUdrxNsyTXKWvxivQvWVl5tdzULz2lYKTkP5U/1snr/fPgIgdEin54aD9eq7P99Nxfy/y32SG//DAWlTNzJo4NuhEHpyBKDxOJ8k3oxtMg6ztc443qifGrEFPjVD4+QbvIyCUzvujdDUfSVc4KY3xnszb3nTI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769521300; c=relaxed/simple; bh=J9NPVHKK1SyrBiVPsigzabAbbIi+AxVUNECi9PAdcMc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Kpt8KEo9D4Tw0Uw0pEjHVEPQMYkgvMoE+dwqQIYkN3tTDDwY+k8iDz8ZLnLkdbH/YQU6TcvhsAWMNBIfdQ291W0OBO/qaG5zndySq9ce6V9Z8fSqahZ1qMGhrXONNGWr4DCJzsSB8EwVaqMQ3f/hH3OUr8okbtIdgFBYuK8/3x8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=XPV+iVx+; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="XPV+iVx+" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=iOKXG9Ip0SkC/9AL3ADC9BHQKfkdAPIL06Iyiewce+M=; b=XPV+iVx+ZIFtWaKrh6b6E4xDHB ZJyuVmOr0YljMY9/gmubl4zzEWzrCOkf8F+BEdjmncQKD24E6FWFbwJ3MSBEKe+gGAKKTjDHlGJ9u xWOSGU9lvjzX70n6bdidltR2U8VfJ6yfRNn0L0Wz4Ou82e5GmRhAnYnfpfBgXv4P5PrZBWWKKfp7p dvwtZtq1Hzwh8JSPjQWhAyC71zm7NIzojalrDW2hRDKRGMoBaBTeNOKYGYwKwoE8wky/Y8Z9ZAg1Q wPoV4ywJIEECerFpq3c4F17aazK0/1KL+zJJ6lxtd9sO44MWfnRdWDhO0lHVvJXHB5hyFmimjLn5g p6ozUb9Q==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1vkjJv-00H1lR-9u; Tue, 27 Jan 2026 13:41:27 +0000 Date: Tue, 27 Jan 2026 05:41:22 -0800 From: Breno Leitao To: Mike Rapoport Cc: Alexander Graf , Pasha Tatashin , Pratyush Yadav , linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org, usamaarif642@gmail.com, rmikey@meta.com, clm@fb.com, riel@surriel.com, SeongJae Park , kernel-team@meta.com Subject: Re: [PATCH v5 2/4] kho: rename fdt parameter to blob in kho_add/remove_subtree() Message-ID: References: <20260126-kho-v5-0-7cd0f69ab204@debian.org> <20260126-kho-v5-2-7cd0f69ab204@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Debian-User: leitao Helo Mike, On Tue, Jan 27, 2026 at 09:26:52AM +0200, Mike Rapoport wrote: > On Mon, Jan 26, 2026 at 08:07:24AM -0800, Breno Leitao wrote: > > Since kho_add_subtree() now accepts arbitrary data blobs (not just > > FDTs), rename the parameter from 'fdt' to 'blob' to better reflect > > its purpose. Apply the same rename to kho_remove_subtree() for > > consistency. > > So if we are doing renames, let's take care of kho_debugfs_fdt_*() as well. Sure. I am happy to do it. I will update the functions name as well, basically s/fdt/blob in the function defition. Something like: kho_debugfs_blob_add(struct kho_debugfs *dbg, const char *name, const void *blob, size_t size, bool root) void kho_debugfs_blob_remove(struct kho_debugfs *dbg, void *blob); Thanks for the review, --breno