From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E21002C0F75 for ; Tue, 27 Jan 2026 13:55:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769522117; cv=none; b=MuUDBUeiX6Rr4sS2QeReUnUuRMmGSU/DPPT61iSY1fGrG5PwGN4hYOdrm6Y6HPnpOz0pNuUSQdGmEMY1+ZX8Ww5zJPGI5wllQrfcz7O+uNYImSR3T+y7QiNAw42Qh1vjfwAOc9tFMkA/9tYUG635gb+M9rK/kcTi+e1kMF72sAA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769522117; c=relaxed/simple; bh=XCH8Wz4CI5ZglnNIsHiUejB2LHfmUzbG247xBvpyHnc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ItvgGN6bAluXDmN/3FSPmjXKsL96pOxs+9nx9I8HeyEshV8bLYfRRLSrKr2SLkRq2Ywm5DNe/mcSQs8+yvfVncxBAAHFBDpKwgfdGcHQnTQVFZE3quoO6DwwTtQyXBzh3C0WTZ/OHndAQDdwhq3rFkcmASipT7+J0Ds35cXCYtE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s/3eI0M+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s/3eI0M+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EDEAC116C6; Tue, 27 Jan 2026 13:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769522116; bh=XCH8Wz4CI5ZglnNIsHiUejB2LHfmUzbG247xBvpyHnc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s/3eI0M+Oeb//gY6t9o2cY1DgUv36AL1K2WjuI/a3klNxzb+xW37AZ0xqQNVs9amO J59ysBBq4mvMXPI23DPmKG2r063lZZiKt1cL082uI2PzKioV9r+7xCW0caM77GbEJW F7HK0SOT0usLeqgBm/hps7nl+SYxTJzku72e2fVPHtQ9FIi8ILIqm8hC3sh3dC0X8O +Uw8rE+O7ajoL5MuYC+mGfQMyz6u2DPa61zr8v4cVbvzC18L9CMNdLT3q4FQPj8dm9 KN1O+A7v97wIDBaU6o0BG0IAAdXVKeLPHCfJO5Tjyj1mJBvKpJxIF4RXNwoFHjuxt7 lgFAE05RPAXQw== Date: Tue, 27 Jan 2026 14:55:13 +0100 From: Frederic Weisbecker To: Andrew Morton Cc: Sebastian Andrzej Siewior , Marco Crivellari , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Tejun Heo , Lai Jiangshan , Michal Hocko Subject: Re: [PATCH v2 3/3] mm: add WQ_PERCPU to alloc_workqueue users Message-ID: References: <20260113114630.152942-1-marco.crivellari@suse.com> <20260113114630.152942-4-marco.crivellari@suse.com> <20260124222135.XyGv6OqY@linutronix.de> <20260124152241.d97b8b525c1d67ad2b0423f7@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260124152241.d97b8b525c1d67ad2b0423f7@linux-foundation.org> Le Sat, Jan 24, 2026 at 03:22:41PM -0800, Andrew Morton a écrit : > On Sat, 24 Jan 2026 23:21:35 +0100 Sebastian Andrzej Siewior wrote: > > > On 2026-01-13 12:46:30 [+0100], Marco Crivellari wrote: > > > --- a/mm/slub.c > > > +++ b/mm/slub.c > > > @@ -8542,7 +8542,9 @@ void __init kmem_cache_init(void) > > > > > > void __init kmem_cache_init_late(void) > > > { > > > - flushwq = alloc_workqueue("slub_flushwq", WQ_MEM_RECLAIM, 0); > > > +#ifndef CONFIG_SLUB_TINY > > > > This ifndef does not belong here. > > > > > + flushwq = alloc_workqueue("slub_flushwq", WQ_MEM_RECLAIM | WQ_PERCPU, > > > + 0); > > > WARN_ON(!flushwq); > > > } > > Yup, thanks, mm.git is carrying a -fix patch, which is actually wrong. > > > From: Andrew Morton > Subject: mm-add-wq_percpu-to-alloc_workqueue-users-fix > Date: Tue Jan 13 05:59:13 PM PST 2026 > > fix mm/slub.c > > Cc: Marco Crivellari > Signed-off-by: Andrew Morton > --- > > mm/slub.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/mm/slub.c~mm-add-wq_percpu-to-alloc_workqueue-users-fix > +++ a/mm/slub.c > @@ -8546,6 +8546,7 @@ void __init kmem_cache_init_late(void) > flushwq = alloc_workqueue("slub_flushwq", WQ_MEM_RECLAIM | WQ_PERCPU, > 0); > WARN_ON(!flushwq); > +#endif > } > > struct kmem_cache * > > > > I'll add this: > > --- a/mm/slub.c~mm-add-wq_percpu-to-alloc_workqueue-users-fix-fix > +++ a/mm/slub.c > @@ -8542,11 +8542,9 @@ void __init kmem_cache_init(void) > > void __init kmem_cache_init_late(void) > { > -#ifndef CONFIG_SLUB_TINY > flushwq = alloc_workqueue("slub_flushwq", WQ_MEM_RECLAIM | WQ_PERCPU, > 0); > WARN_ON(!flushwq); > -#endif With that as a fixup, looks good: Reviewed-by: Frederic Weisbecker -- Frederic Weisbecker SUSE Labs