From: "Anton D. Stavinskii" <stavinsky@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chen Wang <unicorn_wang@outlook.com>,
Inochi Amaoto <inochiama@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
sophgo@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4 5/6] ASoC: sophgo: add CV1800B internal DAC codec driver
Date: Tue, 27 Jan 2026 19:30:27 +0400 [thread overview]
Message-ID: <aXjZoFi_fq3tzJFY@anton.local> (raw)
In-Reply-To: <153acfd6-cb4f-48ee-82e0-0a18a4a1e9c7@sirena.org.uk>
On Tue, Jan 27, 2026 at 03:13:59PM +0400, Mark Brown wrote:
> On Tue, Jan 27, 2026 at 07:11:24PM +0400, Anton D. Stavinskii wrote:
> > On Tue, Jan 27, 2026 at 12:49:52PM +0400, Mark Brown wrote:
>
> > > Nothing ever mutes the DAC so this is a bit redundant. The mute should
> > > probably be a mute_stream() operation.
>
> > I'm not sure here. DAC mute feature was not implemented because I don't know how
> > exactly do that. The public documentation is very weak for my taste.
> > This call added here to be sure that override flag is
> > not set (override feature replaces the output by setting it to constant
> > value and ignoring the input, so it is some kind of mute from my understanding.
> > So ensuring this off is needed be sure that DAC will output our I2S data).
> > What do you think will be better to do here?
> > I'm sure that is needed, but may be better to move
> > it to some early stages, like probe function.
>
> It's probably fine to leave the functional code as is but you should add
> some comments to the mute function explaining waht's going on here.
Sounds good. Will add comments and prepare v5.
Thanks a lot!
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-01-27 15:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 19:06 [PATCH v4 0/6] ASoC: sophgo: add CV1800 I2S controllers support Anton D. Stavinskii
2026-01-20 19:06 ` [PATCH v4 1/6] ASoC: dt-bindings: sophgo,cv1800b: add I2S/TDM controller Anton D. Stavinskii
2026-01-20 19:21 ` Krzysztof Kozlowski
2026-01-20 19:06 ` [PATCH v4 2/6] ASoC: sophgo: add CV1800B I2S/TDM controller driver Anton D. Stavinskii
2026-01-20 19:06 ` [PATCH v4 3/6] ASoC: dt-bindings: sophgo,cv1800b: add ADC/DAC codec Anton D. Stavinskii
2026-01-21 2:30 ` Rob Herring (Arm)
2026-01-20 19:06 ` [PATCH v4 4/6] ASoC: sophgo: add CV1800B internal ADC codec driver Anton D. Stavinskii
2026-01-20 19:06 ` [PATCH v4 5/6] ASoC: sophgo: add CV1800B internal DAC " Anton D. Stavinskii
2026-01-27 12:49 ` Mark Brown
2026-01-27 15:11 ` Anton D. Stavinskii
2026-01-27 15:13 ` Mark Brown
2026-01-27 15:30 ` Anton D. Stavinskii [this message]
2026-01-27 15:46 ` Mark Brown
2026-01-20 19:06 ` [PATCH v4 6/6] riscv: dts: sophgo: dts nodes for i2s tdm modules Anton D. Stavinskii
2026-02-25 22:20 ` Inochi Amaoto
2026-02-25 22:32 ` Inochi Amaoto
2026-03-04 17:57 ` Anton D. Stavinskii
2026-03-05 0:01 ` Inochi Amaoto
2026-01-27 12:50 ` [PATCH v4 0/6] ASoC: sophgo: add CV1800 I2S controllers support Mark Brown
2026-01-27 18:51 ` Anton D. Stavinskii
2026-01-28 3:02 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXjZoFi_fq3tzJFY@anton.local \
--to=stavinsky@gmail.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=inochiama@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=perex@perex.cz \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=sophgo@lists.linux.dev \
--cc=tiwai@suse.com \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox