From: Andrea Righi <arighi@nvidia.com>
To: Gabriele Monaco <gmonaco@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Tejun Heo <tj@kernel.org>, Joel Fernandes <joelagnelf@nvidia.com>,
David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>,
Daniel Hodges <hodgesd@meta.com>,
sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sched/deadline: Reset dl_server execution state on stop
Date: Tue, 27 Jan 2026 19:54:43 +0100 [thread overview]
Message-ID: <aXkJ8_zLVSuToLxe@gpd4> (raw)
In-Reply-To: <be763631-f677-4bad-8285-69dbfe29db54@redhat.com>
On Tue, Jan 27, 2026 at 04:00:31PM +0000, Gabriele Monaco wrote:
> 2026-01-27T14:18:29Z Andrea Righi <arighi@nvidia.com>:
> > I think my case should work also doing something like this (I'll run some
> > tests later to double check):
> >
> > if (dl_se->runtime <= 0)
> > dl_se->dl_defer_running = 0;
> >
> > In this way:
> > - short sleep + remaining runtime > 0
> > - dl_defer_running stays set
> > - restart can go A->D directly
> > - no extra defer / zero-laxity penalty
> >
> > - stop with exhausted (or negative) runtime
> > - dl_defer_running is cleared
> > - restart must re-establish eligibility
> > - deferral / timer is armed again
> > - no stale "already running" server
>
> Yeah that looks like the neatest to me.
> Fair tasks are a bit more penalised than now but won't be if they really sleep before consuming the runtime, which I think was the whole point of this logic.
Unfortunately checking only runtime <= 0 isn't enough for the sched_ext DL
server case:
# Runtime of EXT task (PID 2025) is 0.000000 seconds
# Runtime of RT task (PID 2026) is 4.990000 seconds
# EXT task got 0.00% of total runtime
not ok 2 FAIL: EXT task got less than 4.00% of runtime
With the unconditional reset the EXT task gets 5% of the bandwidth. I'll
add some debugging to figure out exactly what is happening.
-Andrea
next prev parent reply other threads:[~2026-01-27 18:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 16:16 [PATCH v2] sched/deadline: Reset dl_server execution state on stop Andrea Righi
2026-01-23 16:22 ` Juri Lelli
2026-01-26 14:20 ` Gabriele Monaco
2026-01-26 16:30 ` Andrea Righi
2026-01-26 16:56 ` Gabriele Monaco
2026-01-26 21:26 ` Andrea Righi
2026-01-27 8:52 ` Gabriele Monaco
2026-01-27 14:18 ` Andrea Righi
2026-01-27 16:00 ` Gabriele Monaco
2026-01-27 18:54 ` Andrea Righi [this message]
2026-01-28 9:50 ` Gabriele Monaco
2026-01-28 13:41 ` Andrea Righi
2026-01-29 11:48 ` gmonaco
2026-01-29 17:32 ` Andrea Righi
2026-01-30 7:30 ` Juri Lelli
2026-01-30 12:24 ` Peter Zijlstra
2026-01-30 12:26 ` Peter Zijlstra
2026-01-30 12:41 ` Peter Zijlstra
2026-01-30 15:52 ` Juri Lelli
2026-01-30 16:25 ` Andrea Righi
2026-01-30 16:40 ` Peter Zijlstra
2026-01-30 16:46 ` Andrea Righi
2026-01-30 22:12 ` [tip: sched/urgent] sched/deadline: Fix 'stuck' dl_server tip-bot2 for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXkJ8_zLVSuToLxe@gpd4 \
--to=arighi@nvidia.com \
--cc=bsegall@google.com \
--cc=changwoo@igalia.com \
--cc=dietmar.eggemann@arm.com \
--cc=gmonaco@redhat.com \
--cc=hodgesd@meta.com \
--cc=joelagnelf@nvidia.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=void@manifault.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox