From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BAA12D7DF1 for ; Wed, 28 Jan 2026 11:52:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769601170; cv=none; b=G11UF30qe2ShxFnsuAINQrRskiZEmTktP8tFjnbhKQYrrmvGvR0cdaPZsdAgEqOjR449kMXW7Rlz+hnkRm5N4e5vBQw3PWO8KBu8FsjU4QkZlmtw7EYgG8kUz8odzej1LnT0ewrKwZYr03hxe3aP+e1D4cyLtsoqHEbv0ytxcS8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769601170; c=relaxed/simple; bh=qGeiQcnPUREdu3NwgL8PhW+DAcExAANqppOHWMibh1M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Wf8kdd3NJ2q+BKl2mU53EeZNutsEdEMzrcFB19tDG7dovEeVBj06Gg55c04UpPIV0lCLDwcBfRXHaRI5jvyXK4cqXfGsLcJydG63nUoLpLYpw7aY5U6CFOcrB/7X1wvnxUMQMrnYskqx0EgqgreW76E9UDM3N931V2lqoyPX9I0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=C0608Ttu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="C0608Ttu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AABFC4CEF1; Wed, 28 Jan 2026 11:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769601170; bh=qGeiQcnPUREdu3NwgL8PhW+DAcExAANqppOHWMibh1M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C0608TtuLAJdwx1KLa0K5cLbb458/bDhbLIzblRKsOyGSV4RJe9vIYW8YMegQfzEA nT70UewOXAYVf1GRY4pc880T3YL3C5cgtXPvflM9zJ2WCQHZlPMV1kTvv4zQ5hOMpF A255Jp1o582c7Lu51oJQp41SxmVvf3su7//YyqKRBMCfMt6wcFdIIWCKjWW7/3aAZd kppBXaQ/GOhtDVgC8ohsYpVBs2nXbCkeYvDjdnGVpc+VoA0uTu0NPzygloo426uskf moHAht3pfr+2hb9QhAMxP9D8qDMZS7Q9dpei5Oza56T1wlr0az+Gilnc5DrN5547HS 5KcgciN4WPEeQ== Date: Wed, 28 Jan 2026 13:52:43 +0200 From: Mike Rapoport To: "Vishal Moola (Oracle)" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, "Matthew Wilcox (Oracle)" , Dave Hansen , Andy Lutomirski , Peter Zijlstra Subject: Re: [PATCH 0/3] Convert x86/mm/pat to ptdescs Message-ID: References: <20260127005140.197847-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260127005140.197847-1-vishal.moola@gmail.com> Hi Vishal, On Mon, Jan 26, 2026 at 04:51:37PM -0800, Vishal Moola (Oracle) wrote: > x86/mm/pat should be using ptdescs. One line has already been > converted to pagetable_free(), while the allocation sites use > get_free_pages(). This causes issues separately allocating ptdescs > from struct page. > > These patches convert the allocation/free sites to use ptdescs. In > the short term, this helps enable Matthew's work to allocate frozen > pagetables. And in the long term, this will help us cleanly split > ptdesc allocations from struct page. > > ------ > > Based on current mm-new. > > Vishal Moola (Oracle) (3): > x86/mm/pat: Convert pte code to use ptdescs > x86/mm/pat: Convert pmd code to use ptdescs There are still get_zeroed_page() calls in populate_pgd(). I think they also should be converted to pagetable_alloc(). Other than that LGTM. > x86/mm/pat: Convert split_large_page() to use ptdescs > > arch/x86/mm/pat/set_memory.c | 37 +++++++++++++++++++----------------- > 1 file changed, 20 insertions(+), 17 deletions(-) > > -- > 2.52.0 > -- Sincerely yours, Mike.