From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2BB533F383 for ; Wed, 28 Jan 2026 09:15:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769591740; cv=none; b=QpDShujZH3DJlYr0eXSjD1Tof2jrld/sh+HQPvhZVwzrgCAHFnNoyqlrWuj8RZET+JX/6Ojd/4nIEh7d/C1EjEP6g/QWD+eNMFnjhXlrkKw5e65oXwEcE+RSuRoTxFlZNcfwyQi5S4/hUxxcnkKANMm8L3GsoatA7aW/mmSt/B0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769591740; c=relaxed/simple; bh=LfaBtJpSWCF5kA4CdK+iSTrFtU8Ddk4D4KH57CT9f/A=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=MJlavlIP9FYsgcwHHnUNjrJVUPlpdVbJM9qaksKq7hJxXUy+juAXpxm5Q42FTLbqeKZdjlNztM2eAvuBb9Xao1w2rfA7uUFnflD4uQ7xFB7yh8aWv78SOrDVNLCsATWtBCSqqykbcAsqa+L0/yNRo3CDg/ELr4DtIkWsMTkMYHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=4sZH+W6n; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="4sZH+W6n" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-4806cd00e02so3789005e9.0 for ; Wed, 28 Jan 2026 01:15:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769591737; x=1770196537; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=zrjnjrWJRJ/MpDqQmBtQDJOql1m90JNXl6Q6zdTxfG8=; b=4sZH+W6nbqOE7yyIEUhfpdr3XmOK06qUCq2A+ULWc0YxqzwlMr1asECRW4RTmhCC4Q XuE3AKdIqCNd+rgF3GMvivBQ8O+s3bujYAWdxWPgHGUeoHnxGF3JE/fSb9cQe8zLAwdF utTofSqf91WQJSRyb3MSQOcx8s4UN8rUi+3EYe46rVVqIluBvn474vCROpXAzT2dwXV4 6GqgOx88ssfwpsdBjk58y4YwX1dGj1qDQN6SggkKKoowAMtYqlWVzwV/zbZqMdrvEp2I BqNj13GxNXsxYkzNb+u5mz7bNiY26pMYnbSJIHaXXp45Jd4DnoxHcGnT9b9cmST6bE0Y ZDyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769591737; x=1770196537; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zrjnjrWJRJ/MpDqQmBtQDJOql1m90JNXl6Q6zdTxfG8=; b=R/FERhnZzBLmCIlpVtrReoNvfhQxRqCBNKZcmF92Jb47VN1hA4iFfVpXL2vfkkBBuw dT/HnUA/CLQmfAep08IPyJcJWTrPWabTT9g6VJqVcahEB5K1yTU5hOcB575XWyYQOee2 r/MKxJ+VU9OBbaVMDx0uFcxjI48mmpvtsta9R/j4hp6whNJM532spebiVfjqnKshNDEQ ZNjkw6cv4Y1cDgciagY9rxUkgZzBVKo8X1AfaWfw+YeqxpbF0TROcUSQIqxB+szZjwLf IRg0kAOo/a28mQ1cBsV+z0HIhatAf1BtXhqNEKqLDNs98mvMK6aigIDBFsa16TWACcQk x2Lg== X-Forwarded-Encrypted: i=1; AJvYcCV5swjKMiXapP+0cdW1ockzieFluvjS2VIOw5u5d/dvmO0OnN7284tuQbsFxg8GCDCPRhj96Im8MtwbD84=@vger.kernel.org X-Gm-Message-State: AOJu0YzBXqqPL0NscFmmyyHcdzWrBkYbiSRgnVrYImCFaloUJhNg8/qn Stn6HITZQS4m0cpq8GhKS8UnhvQ4XPyrUh966X7hIQdlFBCuMzvhpfHSuV8cZ3aCZQr+2ViRRc1 DBwYxgZlB7eCD1M6gIQ== X-Received: from wmby17.prod.google.com ([2002:a05:600c:c051:b0:480:6b43:8a18]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3113:b0:47e:dc64:f1c6 with SMTP id 5b1f17b1804b1-48069c3fb40mr58701215e9.6.1769591737025; Wed, 28 Jan 2026 01:15:37 -0800 (PST) Date: Wed, 28 Jan 2026 09:15:36 +0000 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251203-binder-trace1-v1-0-22d3ffddb44e@google.com> <20251203-binder-trace1-v1-2-22d3ffddb44e@google.com> Message-ID: Subject: Re: [PATCH 2/2] rust_binder: add binder_transaction tracepoint From: Alice Ryhl To: Carlos Llamas Cc: Greg Kroah-Hartman , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Miguel Ojeda , Boqun Feng , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , "Arve =?utf-8?B?SGrDuG5uZXbDpWc=?=" , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Suren Baghdasaryan , rust-for-linux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Tue, Jan 27, 2026 at 06:31:36PM +0000, Carlos Llamas wrote: > On Wed, Dec 03, 2025 at 02:48:09PM +0000, Alice Ryhl wrote: > > This patch adds the binder_transaction tracepoint to Rust Binder. This > > was chosen as the next tracepoint to add as it is the most complex > > tracepoint. (And it's also an important tracepoint known to perfetto.) > > > > Signed-off-by: Alice Ryhl > > --- > > This approach seems to work well considering the limitations. I wonder > though if it would be more practical to simply pass the individual > primitive values used by TP_prinkt() from the start? I suppose the > downside would be the extra overhead with the tracepoints disabled. > However, this might be neglectable and the solution much simpler? I decided to go down this road because the same kinds of helpers would be useful for vendor hooks. > > +static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_transaction t) > > +{ > > + void *p = *(void **) (t + RUST_BINDER_LAYOUT.t.target_node); > > + > > + if (p) > > + p = p + RUST_BINDER_LAYOUT.n.arc_offset; > > + return NULL; > > It looks like this should have 'return p' right? Sorry for the late > review this has been picked up so we might need a fixes for this. Fix sent: https://lore.kernel.org/r/20260128-binder-fix-target-node-null-v1-1-78d198ef55a5@google.com No idea how this happened. Thanks. Alice