From: Alice Ryhl <aliceryhl@google.com>
To: Carlos Llamas <cmllamas@google.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Christian Brauner" <brauner@kernel.org>,
"Dmitry Antipov" <dmantipov@yandex.ru>,
"Al Viro" <viro@zeniv.linux.org.uk>, NeilBrown <neil@brown.name>,
"Matt Gilbride" <mattgilbride@google.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Li Li" <dualli@google.com>, "Paul Moore" <paul@paul-moore.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, "kernel test robot" <lkp@intel.com>
Subject: Re: [PATCH 1/2] rust_binderfs: fix ida_alloc_max() upper bound
Date: Wed, 28 Jan 2026 09:18:49 +0000 [thread overview]
Message-ID: <aXnUeQKA63282mYG@google.com> (raw)
In-Reply-To: <20260127235545.2307876-1-cmllamas@google.com>
On Tue, Jan 27, 2026 at 11:55:10PM +0000, Carlos Llamas wrote:
> The 'max' argument of ida_alloc_max() takes the maximum valid ID and not
> the "count". Using an ID of BINDERFS_MAX_MINOR (1 << 20) for dev->minor
> would exceed the limits of minor numbers (20-bits). Fix this off-by-one
> error by subtracting 1 from the 'max'.
>
> Cc: stable@vger.kernel.org
> Fixes: eafedbc7c050 ("rust_binder: add Rust Binder driver")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/r/202512181203.IOv6IChH-lkp@intel.com/
> Signed-off-by: Carlos Llamas <cmllamas@google.com>
For both patches:
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
prev parent reply other threads:[~2026-01-28 9:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 23:55 [PATCH 1/2] rust_binderfs: fix ida_alloc_max() upper bound Carlos Llamas
2026-01-27 23:55 ` [PATCH 2/2] binderfs: " Carlos Llamas
2026-01-28 9:18 ` Alice Ryhl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXnUeQKA63282mYG@google.com \
--to=aliceryhl@google.com \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=cmllamas@google.com \
--cc=dmantipov@yandex.ru \
--cc=dualli@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mattgilbride@google.com \
--cc=neil@brown.name \
--cc=paul@paul-moore.com \
--cc=stable@vger.kernel.org \
--cc=tkjos@android.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox