From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5701D33CE84 for ; Wed, 28 Jan 2026 11:28:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769599736; cv=none; b=Ebv6JHVak6nPvr811d6f6hQwB7VS1Z2u68l3RS4YiMRl3sxWpL9/O3maymw5NIS8Z5pU6DmNwGjyVT1ggqkKE5Skm34p5veLaBLjNeLmcB+WXqITNeBhDG6oVs0u1mnW3WWMOMnjAL0nBgabyUHeFWPQoKQ312nIPTK+vEL3G8k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769599736; c=relaxed/simple; bh=q2MeOp8Y5yyCDXFyyC7HRaeDTb2/mMO8W7CGD3ap0g4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SLMsTJERRGDXVcpmKA+nI2nAzxi4ubSdTsxHgckQfT99ObBH8DisVHWomv236KQPnRbL3gAkuq4ItQge4qQHt5xqg9unqKHlK4WM6mZwp4VBRZ8GtxZj/CthRcnFmS4ZmP4SwmyasDPd7gesWe+Ei12sNTWzc9aTRSkEcpNZmbE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=XQ2D0Zln; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XQ2D0Zln" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-658b9e95990so894705a12.1 for ; Wed, 28 Jan 2026 03:28:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769599733; x=1770204533; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zsg0G1qQnJMZmcTOUlSvTX8oIURapE56eMOFO0KQLsg=; b=XQ2D0ZlnAppH4Gm8ELsp/iIQy8oupZntWwPL7bywdEalIXnY3KCPEM6chGcmcQZhsw wqn0jmOzvHxqFcsHNqWHE1Na/M2gJgTyEcIDLm85lotl0wnBCnlYmBQeHFFOZgfCuGtR s+dZmUX9s+ksGC6WxjDU3mUOeR8M1M1x/2j3sG+vUPJs4Sd21RdADBtCnf3KgEzGvS6t Bu0TYLSgnWFANqFic+5JXLcpluyuct2rkHtrENsdu87/mU2bnDJ436NUtCKu1U27F8il bhHee/GN7IKz5RjTf6+HAfIOJIIZ7EcHEcQgO9f77rrG7SIyTl+xbGFxEcQDTjiBMooL ZhlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769599733; x=1770204533; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zsg0G1qQnJMZmcTOUlSvTX8oIURapE56eMOFO0KQLsg=; b=Z3VYYjIHqcO9XKm/5u0HyZQb/y/xkEctjuQCDEIEe1VKqytkTtDXWDGRAWO7/bIBw/ SYkQemw1L5UhKeqBjM+nql1xDBXOafGqTMj1PBmtl6H9W1ydgR6M6UyWddlHYl5fvb0P 6Wy/Poy8X3O7se4MmSprcU6wUu9L7CJnlExrx0BhXWqtLSheOpi/C+wC9AfEJjIheVmE 2yFEfpW0Y7lOTLx8SM3wFB9/BRtPwpFpd/K6kWzUkQIkj3XCx+u9JPv+rvfS6+1T8kTo quPIiKafeGhBf+Pnf85MINxSoOH9vDFG7CiuzDRAsIrY30EcuzuoRtC4os3H1Wv6D2tj /8dw== X-Forwarded-Encrypted: i=1; AJvYcCV2h22xSIShjH+vh+QhC4xlgX05iLWBhC1whpmtjEfNpSNJGi2vLNU/BtQYIcQfZBO87M8/SoBDrCxrTFc=@vger.kernel.org X-Gm-Message-State: AOJu0YzVe0nmfqqC+nCNLnolGrf4wlGjd6Nw+pjqW18tmVq6xxwiCtBX r0PnkeRQFcTfp8gzthahky/05CI9u0MkOTIFdGdgJK6oAGsPBzQ1eZbz97FuOy0mZw== X-Gm-Gg: AZuq6aKZ0UNbOYwD6cacSoqZ4Ny2tooPfjvXusehZKNgMXUZUrXxp2hW1uIgyAJlsls c0SayYi1fw68v++mLE+7BceKK8av7eTAW9tn9FAUZia1eLsBpwiZKxjqxbJTM3+oDAxl45CDmd1 vAIm26/TodqRqFKXOh1bAAF0YBsbuXUGMvSreRIiJF/4AlDZRNwxMeKQ51jEu/7Pu1F8cRvXUrq DXTtnTsz7i+Q6SCBM86JSmcqbGOg3ekkUFPU3RFhr4oPQiTiZgJGpj4mwD/h+HObhWObFIaeIVD DFh+buAsfzmlKO/rIaw8R3dU0W8W3CJvkEHoPYPVA84lXAtiAaTblSsL6wWVmyHXu7Nb50G2LaN aLMdzSim7OLpi/oPdUwIYN4qmL/4q3CpL7vvzHqBqTwnuYt604wlPfV0BJejRWnNWNFyaeFDr+n 1lIIsG4aLbJJ31C4JpVr62Bw3Q+d+VOP5gqY2ohA4VLXX3BCLb88A= X-Received: by 2002:a17:907:da16:b0:b88:646b:ae3f with SMTP id a640c23a62f3a-b8dab1a5c0dmr331559966b.15.1769599732400; Wed, 28 Jan 2026 03:28:52 -0800 (PST) Received: from google.com (93.50.90.34.bc.googleusercontent.com. [34.90.50.93]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbeff5629sm116615766b.27.2026.01.28.03.28.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 03:28:51 -0800 (PST) Date: Wed, 28 Jan 2026 11:28:48 +0000 From: Matt Bobrowski To: Roman Gushchin Cc: bpf@vger.kernel.org, Michal Hocko , Alexei Starovoitov , Shakeel Butt , JP Kobryn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Suren Baghdasaryan , Johannes Weiner , Andrew Morton Subject: Re: [PATCH bpf-next v3 01/17] bpf: move bpf_struct_ops_link into bpf.h Message-ID: References: <20260127024421.494929-1-roman.gushchin@linux.dev> <20260127024421.494929-2-roman.gushchin@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260127024421.494929-2-roman.gushchin@linux.dev> On Mon, Jan 26, 2026 at 06:44:04PM -0800, Roman Gushchin wrote: > Move struct bpf_struct_ops_link's definition into bpf.h, > where other custom bpf links definitions are. > > It's necessary to access its members from outside of generic > bpf_struct_ops implementation, which will be done by following > patches in the series. Looks OK to me: Acked-by: Matt Bobrowski > Signed-off-by: Roman Gushchin > --- > include/linux/bpf.h | 6 ++++++ > kernel/bpf/bpf_struct_ops.c | 6 ------ > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/include/linux/bpf.h b/include/linux/bpf.h > index 4427c6e98331..899dd911dc82 100644 > --- a/include/linux/bpf.h > +++ b/include/linux/bpf.h > @@ -1891,6 +1891,12 @@ struct bpf_raw_tp_link { > u64 cookie; > }; > > +struct bpf_struct_ops_link { > + struct bpf_link link; > + struct bpf_map __rcu *map; > + wait_queue_head_t wait_hup; > +}; > + > struct bpf_link_primer { > struct bpf_link *link; > struct file *file; > diff --git a/kernel/bpf/bpf_struct_ops.c b/kernel/bpf/bpf_struct_ops.c > index c43346cb3d76..de01cf3025b3 100644 > --- a/kernel/bpf/bpf_struct_ops.c > +++ b/kernel/bpf/bpf_struct_ops.c > @@ -55,12 +55,6 @@ struct bpf_struct_ops_map { > struct bpf_struct_ops_value kvalue; > }; > > -struct bpf_struct_ops_link { > - struct bpf_link link; > - struct bpf_map __rcu *map; > - wait_queue_head_t wait_hup; > -}; > - > static DEFINE_MUTEX(update_mutex); > > #define VALUE_PREFIX "bpf_struct_ops_" > -- > 2.52.0 >