* [PATCH] rust_binder: return p from rust_binder_transaction_target_node()
@ 2026-01-28 9:12 Alice Ryhl
2026-01-28 13:53 ` Carlos Llamas
2026-02-03 11:48 ` Greg Kroah-Hartman
0 siblings, 2 replies; 6+ messages in thread
From: Alice Ryhl @ 2026-01-28 9:12 UTC (permalink / raw)
To: Greg Kroah-Hartman, Carlos Llamas; +Cc: linux-kernel, Alice Ryhl
Somehow this got changed to NULL when I ported this to upstream it. No
idea how that happened.
Reported-by: Carlos Llamas <cmllamas@google.com>
Closes: https://lore.kernel.org/r/aXkEiC1sGOGfDuzI@google.com
Fixes: c1ea31205edf ("rust_binder: add binder_transaction tracepoint")
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
---
Commit not yet upstream, so cc stable not required.
---
drivers/android/binder/rust_binder.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/android/binder/rust_binder.h b/drivers/android/binder/rust_binder.h
index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644
--- a/drivers/android/binder/rust_binder.h
+++ b/drivers/android/binder/rust_binder.h
@@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t
if (p)
p = p + RUST_BINDER_LAYOUT.n.arc_offset;
- return NULL;
+ return p;
}
static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t)
---
base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd
change-id: 20260128-binder-fix-target-node-null-02fcb98f0200
Best regards,
--
Alice Ryhl <aliceryhl@google.com>
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] rust_binder: return p from rust_binder_transaction_target_node()
2026-01-28 9:12 [PATCH] rust_binder: return p from rust_binder_transaction_target_node() Alice Ryhl
@ 2026-01-28 13:53 ` Carlos Llamas
2026-02-03 11:48 ` Greg Kroah-Hartman
1 sibling, 0 replies; 6+ messages in thread
From: Carlos Llamas @ 2026-01-28 13:53 UTC (permalink / raw)
To: Alice Ryhl; +Cc: Greg Kroah-Hartman, linux-kernel
On Wed, Jan 28, 2026 at 09:12:07AM +0000, Alice Ryhl wrote:
> Somehow this got changed to NULL when I ported this to upstream it. No
> idea how that happened.
>
> Reported-by: Carlos Llamas <cmllamas@google.com>
> Closes: https://lore.kernel.org/r/aXkEiC1sGOGfDuzI@google.com
> Fixes: c1ea31205edf ("rust_binder: add binder_transaction tracepoint")
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> ---
> Commit not yet upstream, so cc stable not required.
> ---
> drivers/android/binder/rust_binder.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/binder/rust_binder.h b/drivers/android/binder/rust_binder.h
> index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644
> --- a/drivers/android/binder/rust_binder.h
> +++ b/drivers/android/binder/rust_binder.h
> @@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t
>
> if (p)
> p = p + RUST_BINDER_LAYOUT.n.arc_offset;
> - return NULL;
> + return p;
> }
>
> static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t)
>
> ---
> base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd
> change-id: 20260128-binder-fix-target-node-null-02fcb98f0200
>
> Best regards,
> --
> Alice Ryhl <aliceryhl@google.com>
>
Acked-by: Carlos Llamas <cmllamas@google.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rust_binder: return p from rust_binder_transaction_target_node()
2026-01-28 9:12 [PATCH] rust_binder: return p from rust_binder_transaction_target_node() Alice Ryhl
2026-01-28 13:53 ` Carlos Llamas
@ 2026-02-03 11:48 ` Greg Kroah-Hartman
2026-02-03 11:56 ` Alice Ryhl
2026-02-03 11:57 ` Greg Kroah-Hartman
1 sibling, 2 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2026-02-03 11:48 UTC (permalink / raw)
To: Alice Ryhl; +Cc: Carlos Llamas, linux-kernel
On Wed, Jan 28, 2026 at 09:12:07AM +0000, Alice Ryhl wrote:
> Somehow this got changed to NULL when I ported this to upstream it. No
> idea how that happened.
>
> Reported-by: Carlos Llamas <cmllamas@google.com>
> Closes: https://lore.kernel.org/r/aXkEiC1sGOGfDuzI@google.com
> Fixes: c1ea31205edf ("rust_binder: add binder_transaction tracepoint")
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> ---
> Commit not yet upstream, so cc stable not required.
> ---
> drivers/android/binder/rust_binder.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/binder/rust_binder.h b/drivers/android/binder/rust_binder.h
> index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644
> --- a/drivers/android/binder/rust_binder.h
> +++ b/drivers/android/binder/rust_binder.h
> @@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t
>
> if (p)
> p = p + RUST_BINDER_LAYOUT.n.arc_offset;
> - return NULL;
> + return p;
> }
>
> static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t)
>
> ---
> base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd
> change-id: 20260128-binder-fix-target-node-null-02fcb98f0200
Does not apply at all, what tree was this made against?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rust_binder: return p from rust_binder_transaction_target_node()
2026-02-03 11:48 ` Greg Kroah-Hartman
@ 2026-02-03 11:56 ` Alice Ryhl
2026-02-03 12:10 ` Greg Kroah-Hartman
2026-02-03 11:57 ` Greg Kroah-Hartman
1 sibling, 1 reply; 6+ messages in thread
From: Alice Ryhl @ 2026-02-03 11:56 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Carlos Llamas, linux-kernel
On Tue, Feb 03, 2026 at 12:48:40PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Jan 28, 2026 at 09:12:07AM +0000, Alice Ryhl wrote:
> > Somehow this got changed to NULL when I ported this to upstream it. No
> > idea how that happened.
> >
> > Reported-by: Carlos Llamas <cmllamas@google.com>
> > Closes: https://lore.kernel.org/r/aXkEiC1sGOGfDuzI@google.com
> > Fixes: c1ea31205edf ("rust_binder: add binder_transaction tracepoint")
> > Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> > ---
> > Commit not yet upstream, so cc stable not required.
> > ---
> > drivers/android/binder/rust_binder.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/android/binder/rust_binder.h b/drivers/android/binder/rust_binder.h
> > index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644
> > --- a/drivers/android/binder/rust_binder.h
> > +++ b/drivers/android/binder/rust_binder.h
> > @@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t
> >
> > if (p)
> > p = p + RUST_BINDER_LAYOUT.n.arc_offset;
> > - return NULL;
> > + return p;
> > }
> >
> > static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t)
> >
> > ---
> > base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd
> > change-id: 20260128-binder-fix-target-node-null-02fcb98f0200
>
> Does not apply at all, what tree was this made against?
This applies on char-misc-next. It's a fix for commit c1ea31205edf,
which currently only exists in that branch.
Alice
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rust_binder: return p from rust_binder_transaction_target_node()
2026-02-03 11:48 ` Greg Kroah-Hartman
2026-02-03 11:56 ` Alice Ryhl
@ 2026-02-03 11:57 ` Greg Kroah-Hartman
1 sibling, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2026-02-03 11:57 UTC (permalink / raw)
To: Alice Ryhl; +Cc: Carlos Llamas, linux-kernel
On Tue, Feb 03, 2026 at 12:48:40PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Jan 28, 2026 at 09:12:07AM +0000, Alice Ryhl wrote:
> > Somehow this got changed to NULL when I ported this to upstream it. No
> > idea how that happened.
> >
> > Reported-by: Carlos Llamas <cmllamas@google.com>
> > Closes: https://lore.kernel.org/r/aXkEiC1sGOGfDuzI@google.com
> > Fixes: c1ea31205edf ("rust_binder: add binder_transaction tracepoint")
> > Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> > ---
> > Commit not yet upstream, so cc stable not required.
> > ---
> > drivers/android/binder/rust_binder.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/android/binder/rust_binder.h b/drivers/android/binder/rust_binder.h
> > index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644
> > --- a/drivers/android/binder/rust_binder.h
> > +++ b/drivers/android/binder/rust_binder.h
> > @@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t
> >
> > if (p)
> > p = p + RUST_BINDER_LAYOUT.n.arc_offset;
> > - return NULL;
> > + return p;
> > }
> >
> > static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t)
> >
> > ---
> > base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd
> > change-id: 20260128-binder-fix-target-node-null-02fcb98f0200
>
> Does not apply at all, what tree was this made against?
Ugh, I was looking at the wrong tree, nevermind, my fault...
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rust_binder: return p from rust_binder_transaction_target_node()
2026-02-03 11:56 ` Alice Ryhl
@ 2026-02-03 12:10 ` Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2026-02-03 12:10 UTC (permalink / raw)
To: Alice Ryhl; +Cc: Carlos Llamas, linux-kernel
On Tue, Feb 03, 2026 at 11:56:31AM +0000, Alice Ryhl wrote:
> On Tue, Feb 03, 2026 at 12:48:40PM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Jan 28, 2026 at 09:12:07AM +0000, Alice Ryhl wrote:
> > > Somehow this got changed to NULL when I ported this to upstream it. No
> > > idea how that happened.
> > >
> > > Reported-by: Carlos Llamas <cmllamas@google.com>
> > > Closes: https://lore.kernel.org/r/aXkEiC1sGOGfDuzI@google.com
> > > Fixes: c1ea31205edf ("rust_binder: add binder_transaction tracepoint")
> > > Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> > > ---
> > > Commit not yet upstream, so cc stable not required.
> > > ---
> > > drivers/android/binder/rust_binder.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/android/binder/rust_binder.h b/drivers/android/binder/rust_binder.h
> > > index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644
> > > --- a/drivers/android/binder/rust_binder.h
> > > +++ b/drivers/android/binder/rust_binder.h
> > > @@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t
> > >
> > > if (p)
> > > p = p + RUST_BINDER_LAYOUT.n.arc_offset;
> > > - return NULL;
> > > + return p;
> > > }
> > >
> > > static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t)
> > >
> > > ---
> > > base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd
> > > change-id: 20260128-binder-fix-target-node-null-02fcb98f0200
> >
> > Does not apply at all, what tree was this made against?
>
> This applies on char-misc-next. It's a fix for commit c1ea31205edf,
> which currently only exists in that branch.
Our emails crossed, my fault, I was looking at the wrong tree. Now
applied, thanks!
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-02-03 12:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-28 9:12 [PATCH] rust_binder: return p from rust_binder_transaction_target_node() Alice Ryhl
2026-01-28 13:53 ` Carlos Llamas
2026-02-03 11:48 ` Greg Kroah-Hartman
2026-02-03 11:56 ` Alice Ryhl
2026-02-03 12:10 ` Greg Kroah-Hartman
2026-02-03 11:57 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox