From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B01135EDBB for ; Wed, 28 Jan 2026 13:53:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769608419; cv=none; b=Yd0zTDof0cv8hYHiB9mEJ0qPTEYtgW3Qep70CTDVpm4RlD/nNeGoatU5OMVwqWe9u6YsJHjqtrxM2kCi5d9ttNzZ9ki5JdWMXvUWojnzJxh4ipFr6K4NuI+IxeOPpRO8gAGyBu9XLpaz+5bzMYrrt4xu/Itplv2ixDQ+rovb6HA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769608419; c=relaxed/simple; bh=odI5qTCvmmP5Tv9cnvRVO0NVggTMPEPbdD3irG2V7b8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ex8eHyTevw3rvp5BAcFvDGJTbXIWSv5I2CWdj+6UmiUeLMS0qhH/2Wbi71X/SHNMd/mDQWNBhcfNx4afoHuwaX/lKRGqFggltzbbyJY8q6LSYaMjp+zNs2buBU84OhRzg2QKEkMExxR1Sb0owXAOtk52a7OrpiKMDCYgBPTQ+YI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=jRzhZmG5; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jRzhZmG5" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2a76b39587aso69085ad.0 for ; Wed, 28 Jan 2026 05:53:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769608417; x=1770213217; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FHKx9jvUOzbrmodTdU/9iKuBjPCq0S90+7yzRCY3/GY=; b=jRzhZmG5o6TnmQnMilECW6AuiNCrSMLICAuj1Zi4+M+ns1WLZHKcaRN6XyB5b8WSq3 rM1Bl45N78SAL8e6jfdu2oAtPIB+e4YBGhUxZDVPtFwAObYa6yQazleXCneTxDUPsmO/ nuyzY2Im0gf9998xKPjqyZ1eqbtfMMf5WItjhSE1wpglI2wk5Xh/2no5nGcvS17WUqP6 +Q9n53/CE2KmcD4wx81x8P6nUnzK/1RNSwTUtJIr8hE4TI+OYoXXjNKfzA6HjWMpbwPw q8cNqOVocAuqOVuNYyFMIqZtapFAdcAhKBbjmSzoziGYLl7l5RwUGH+VmfWC6etSG5mA 47Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769608417; x=1770213217; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FHKx9jvUOzbrmodTdU/9iKuBjPCq0S90+7yzRCY3/GY=; b=MOHLMNCuxzp+wZLcJ1Ls2/V4fzpl9JTEzEIeajpvyM+61EDJoim9lUsRcq9xvpffLn prUgYGIYXKhUINhy579XZQL4cg+a/9OmHuG8PUh9T3DfSs9DMOZuu95/SbA8vl2erApc O3lg9RoNMT6L1870YttpQNgHHJ33I4BgJ10/Wqg55F7wPF3Gzig9dIKRa+qLT9+vE0/a IzR8KKBF+JpCetk7DtHUDhZ3a5AsZ5mLlB2Yw752fsOtxbWG48jyvPajYWYY3dUV6DMJ Avk0/BDHbxyPGM3/p12UG86zaKTm0roF7xauTS5O7jZ1pj8IyZF6Iy05fvd41ZSbys6Q P5nQ== X-Forwarded-Encrypted: i=1; AJvYcCVePrfKuOIpsQ4v1FO4ui0a7w8+t07PGYDp09UERjV0u9RC7A25dEXUi51gVlpEJ9E1HOrdl1ADh+SpYA4=@vger.kernel.org X-Gm-Message-State: AOJu0YyqiBuj7DYBe4nuP4qU9S4If0kvM6339xWyVSpf+XOn40vSBc1W rfMvD6wf0+pQ33k7O4Gcor+D5hVG/QU9N/czsruEyyMjKMSwEOcQsCHUse8ikXfaNA== X-Gm-Gg: AZuq6aIiJUyIp2cJj3m0GgWTuDzW0j6qntQ0TMUC8uyfMVE5syZJ/wA9WRwsMcfV3bh j+9vnKQTijZKSMnmd+RUczGJPjbMHsuO9bW1yK3gV3LikyXVq/Q3/qCw+zRXESY2wfVbaBc049e /5fXU+RuGsbxezC/F58s48oj2MqydIyZWzxVR6rMAHzYvL92eRTENjsw9xqwRCyc5Z+bsO1OO2M qEV7uaUdfL9CJArU7Y/yJAsq28MdQpMBzBwwIP2v4raI3V/UwDV9AL42V1GOml/ujWc+ngzI78c GZo1OqImdw096YcLBVyn+u8nqxsnqNG9QygpFJFGl3LBshnzQy5ARkhqiUSKdgunSjZ+blwx6Cw dTPMOiS/cmCvDVwh3t9WdkYqhJqkdglmKfiAgwyFNjhhbwf8AyFrEwUFa9EL5AIwvSD0/baLdFR xJtle6XQUATILPO1H9+z8AQxiYyuvOU/zk8mt4R6VFSgliIhoHHISKJmlxRo/L X-Received: by 2002:a17:903:2409:b0:290:8ecf:e9f9 with SMTP id d9443c01a7336-2a8708cf283mr5430195ad.7.1769608417124; Wed, 28 Jan 2026 05:53:37 -0800 (PST) Received: from google.com (28.117.125.34.bc.googleusercontent.com. [34.125.117.28]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c64283710e1sm2363259a12.14.2026.01.28.05.53.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 05:53:36 -0800 (PST) Date: Wed, 28 Jan 2026 13:53:31 +0000 From: Carlos Llamas To: Alice Ryhl Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] rust_binder: return p from rust_binder_transaction_target_node() Message-ID: References: <20260128-binder-fix-target-node-null-v1-1-78d198ef55a5@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260128-binder-fix-target-node-null-v1-1-78d198ef55a5@google.com> On Wed, Jan 28, 2026 at 09:12:07AM +0000, Alice Ryhl wrote: > Somehow this got changed to NULL when I ported this to upstream it. No > idea how that happened. > > Reported-by: Carlos Llamas > Closes: https://lore.kernel.org/r/aXkEiC1sGOGfDuzI@google.com > Fixes: c1ea31205edf ("rust_binder: add binder_transaction tracepoint") > Signed-off-by: Alice Ryhl > --- > Commit not yet upstream, so cc stable not required. > --- > drivers/android/binder/rust_binder.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/android/binder/rust_binder.h b/drivers/android/binder/rust_binder.h > index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644 > --- a/drivers/android/binder/rust_binder.h > +++ b/drivers/android/binder/rust_binder.h > @@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t > > if (p) > p = p + RUST_BINDER_LAYOUT.n.arc_offset; > - return NULL; > + return p; > } > > static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t) > > --- > base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd > change-id: 20260128-binder-fix-target-node-null-02fcb98f0200 > > Best regards, > -- > Alice Ryhl > Acked-by: Carlos Llamas