From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 871242F1FC4 for ; Wed, 28 Jan 2026 17:09:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769620170; cv=none; b=Jq7z0DKcSE8MbVmzfGPCYGCijMAq2Y3OSfp/8tcETpw22iyff7oHNNh7VrwegQNAaKKG46Le2PCHH8DT30mXuOh2ll7iWNK2Rj4liOME3GfyZHy7uIUY38zs5KLUk82x4nrWmFp2Ijah34ZUjTY29dp7N36Jtbpdf8UvZUO0/sE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769620170; c=relaxed/simple; bh=KurgbNWJTQ5kVHItAijM0+vAimABKdpO5fQ58fGqS+4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T+BU3kR9UwfaPJZDwXK8OURbnXOLC8scOMxVoCBOGIeyHHO4xrdZApkWfzgwdZGPJp/tm/4X6UHYAP+QthDoxhSPZbZdRwMlYtppHImQCqD94n7EfUvy06IP8huI41b+lBeDV6t8pm0adWxPfd0mnYx7EvcOSBIA1+KR9c2DhY0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k8wjMU6K; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k8wjMU6K" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46680C4CEF1; Wed, 28 Jan 2026 17:09:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769620170; bh=KurgbNWJTQ5kVHItAijM0+vAimABKdpO5fQ58fGqS+4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k8wjMU6KKCSJVYIslvoWlpQaHMY61buvhCnSS/F+Tb/GAgRL6ZFcfVnRfFpGN3piZ lf+UnGKnTP/KNXPiESmk7aYop4ZXirYbtEFuk6JZmlx5AvyHwxonlWvTKyZUbVtZN8 jm817GKyixqiJ/03k8xHG5xT/I8a9J0hqrmE0xqdymMNSzFLinCJkw2vVz8LqAi9b+ 3pKQ9dzb9ClYFTyfZkDm5hHjpRiBVbaoaB0Ob29wmVAf/m6MIIubYiHPTGlT8ZmQou 1geRIM4fXZQFQTqacXgTvGZOM9/nMghsZrcqM5xeRFSh3UxjUL51rIcm9UJ0hnqIbX 3enB1EVt0RgWg== Date: Wed, 28 Jan 2026 19:09:22 +0200 From: Mike Rapoport To: Mark Brown Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , "Rob Herring (Arm)" , Oreoluwa Babatunde , Marek Szyprowski , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: cma: Fix stub for cma_skip_dt_default_reserved_mem() Message-ID: References: <20260128-cma-fix-stubs-v1-1-e07a077d5b33@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260128-cma-fix-stubs-v1-1-e07a077d5b33@kernel.org> On Wed, Jan 28, 2026 at 04:28:35PM +0000, Mark Brown wrote: > The stub for cma_skip_dt_default_reserved_mem() is not inlined so > triggers build warnings: > > In file included from /tmp/next/build/fs/proc/meminfo.c:18: > /tmp/next/build/include/linux/cma.h:68:13: warning: 'cma_skip_dt_default_reserved_mem' defined but not used [-Wunused-function] > 68 | static bool cma_skip_dt_default_reserved_mem(void) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > which are fatal with -Werror. > > Fixes: 26332ae848f08 ("of: reserved_mem: Allow reserved_mem framework detect "cma=" kernel param") > Signed-off-by: Mark Brown Acked-by: Mike Rapoport (Microsoft) > --- > include/linux/cma.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/cma.h b/include/linux/cma.h > index 0bf408360641..d0793eaaadaa 100644 > --- a/include/linux/cma.h > +++ b/include/linux/cma.h > @@ -65,7 +65,7 @@ extern void cma_reserve_pages_on_error(struct cma *cma); > #ifdef CONFIG_DMA_CMA > extern bool cma_skip_dt_default_reserved_mem(void); > #else > -static bool cma_skip_dt_default_reserved_mem(void) > +static inline bool cma_skip_dt_default_reserved_mem(void) > { > return false; > } > > --- > base-commit: d0d97f0b2b2b4633022dfaef4ac08af0b7917efe > change-id: 20260128-cma-fix-stubs-26b13ce1471d > > Best regards, > -- > Mark Brown > -- Sincerely yours, Mike.