From: Ben Zong-You Xie <ben717@andestech.com>
To: "Uwe Kleine-König" <ukleinek@kernel.org>
Cc: <linux-pwm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: pwm: remove redundant check in pwm_ops_check()
Date: Fri, 30 Jan 2026 13:11:41 +0800 [thread overview]
Message-ID: <aXw9jY5kpPNAiyxR@swlinux02> (raw)
In-Reply-To: <jxzeyujbaj6s2j3woj7lyuilwi7tzlhenamlih2q23khxw4d3f@dpbnhlxzsjmr>
On Thu, Jan 29, 2026 at 08:19:00AM +0100, Uwe Kleine-König wrote:
> I would rewrite the commit log to:
>
> pwm: Remove redundant check in pwm_ops_check()
>
> ops->write_waveform is already known to be non-NULL so there is
> no need to check it a second time.
>
> The superflous check was introduced in commit 17e40c25158f
> ("pwm: New abstraction for PWM waveforms").
>
> Signed-off-by: Ben Zong-You Xie <ben717@andestech.com>
>
> to make the change more clear and also to not bother the stable team
> with backporting the commit to stable.
>
> Please confirm if you're ok with this change, then I cope for the update
> while applying your change.
>
> Best regards
> Uwe
Hi Uwe,
I'm ok with the change, and thank you for the review.
Best regards,
Ben
next prev parent reply other threads:[~2026-01-30 5:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 6:43 [PATCH] drivers: pwm: remove redundant check in pwm_ops_check() Ben Zong-You Xie via B4 Relay
2026-01-29 7:19 ` Uwe Kleine-König
2026-01-30 5:11 ` Ben Zong-You Xie [this message]
2026-01-30 10:12 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXw9jY5kpPNAiyxR@swlinux02 \
--to=ben717@andestech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox