From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44CC123BCF7 for ; Fri, 30 Jan 2026 09:07:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769764077; cv=none; b=Wn/iSxLvwgUl1vgQhkaOXq45s8YexY0fgJtTxO7B5jJT9howp6ve3Ma9/AW6pC7l3x2KZj1rYYTZu0xY/iPnQBC8iJ76FfT1uikTKYBCTTZHwA4IHci8SVWmgc3PgZW/EVtE1ItR7dUiyspJMsfbfgYEW6t4RpMvw2LC9xA4VbM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769764077; c=relaxed/simple; bh=1SnfYteut4GCl5KCt6lVmzXoLsIbYqa+8nLCzo5Jxgc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Hl1eb1qqnEIGQ28W+6dGSZT2E6HZXjPO2f1wScBxz7KnjfSqh6PgynH9VRclC2euxzlYLPWsS58yKQFGA2NGaboYIcu6Ypm0pEaXAwK79zzWT8/Wkavvh8YHyer/qyIMyJELmduB7IvUWo4FYrv4Nnhton3IXtwglsDctajsXQc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=IyoLEJ7l; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IyoLEJ7l" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-430f3ef2d37so1582481f8f.3 for ; Fri, 30 Jan 2026 01:07:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769764075; x=1770368875; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1x5cz/G6bIEUDLXvp5Ag3NYOCmffhKeS9wCcDi5MCAE=; b=IyoLEJ7lf4ny0/bMHWbujfCmpZGuJQZDjgP0vnCaq7lD8bw2mShMEVXDAoC+C5wO9F 0Bco70/XFptLtjrq7l/zgh3KyCeRyJFlDHnyZRpnVbB4ivgAVzyfmC2hOuwb2NQ5s8A5 YVUwXoI82hsagkZ1wq1SGriepR4FzTqDr7ypowDglHP5WNF8owJY87IS9+eprd3GBQXI y6jwg5TeIzvv4jzUYLY4kUNxM+dktw/zLKHFGibaypiuXpvmNK+SfPtolxrjAcmPBmk7 Agz4cZlb/nri/hSOj2VQT1m9bk4Kgv9tpp35esB2pgsDvBwHBFyVDeslL4gzRjkgkJE0 joIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769764075; x=1770368875; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1x5cz/G6bIEUDLXvp5Ag3NYOCmffhKeS9wCcDi5MCAE=; b=GuwGlu9OjlosYMHxtb/zy1CAk3G7h4TwARxzS+XoRdZD77fJwSgtgCyzp5KLkuW539 VyGBFe9mx6kNFR8Iod1BSsFDTlJ/OC28vTzDnAaK/t5V4nUmG4ay35FgQYe0/JA1HA/7 d186R0QYlIWJvw8PSIh7I+qeuIqt1qWGxFm0qaOIii5hwYIWlhIAo+TgYL+dhGQk/m6m bPieTL+rgKDKf56OZRWLeBwpWT5qX16QYiMjHFZ5zbX0A+xwDl91UdcXuAYVoWNkmX83 ElzannuGR6qJcORep16TSj2b0KDW3dYqX4n05afwPh91W29UPjOvWCjfTHHe1TIK6QTt 0uvQ== X-Forwarded-Encrypted: i=1; AJvYcCVl2NLdiOb3UGBW1eO04GKpkdA9rMk84t13xvsBFfjcphrlX9WOAOI2sWyzo5Xn+gnuseEzAtN+5g62tX8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy75enkrxiK2bu3IuKyRvJPna39r1Z0xkkRkr1Jj5XWJIGCx9vq SntNTM+aWBaxO/ZvvQ8jFr4sPYLplwUe3genOpP0wYe9C+Vs+/AtoMdU6BF21H5JYtk= X-Gm-Gg: AZuq6aIgLcRQWz4ifS0ZxQ1vCgofrqZMLt/fxh9xITM2I1Vt5OXNrRf7JfOowvGRR8F ZrRrkhVF1s+heG+OKBsfJcm6Q0+g1th9KB8eSRYFTiSzxQnu4eqi2mrQzbZwEcPTDYccIYTu5v3 WY2IlKCsJnwJuQ170egsITbx0v4dJTd99u7ot/0zYqUCufeo+5z94L0s/v6ipbQwSUJcb4HynxS fpc53iVwp76FQyd+Q+xRx2/cfZM9EvLv+VrLVKaIw8suAY4W3vhuk94DNHX1shcA6BYS2yZhymZ R+tiOaC5s0Ya116+/LoJds3VQW+ZHnCiuNmnhuxecITi0n3Zpngp8BOZxUQMr3uSjLcsBUQaPLg OBmJ/0rSmMmhl631kKTetMUUxWVt1oRARyVqPfntqk3jx/gEkmbT7rgyuSNQ+szvJe1g1hg/u0T SdK+qQtFkiict1ftBm X-Received: by 2002:a05:6000:1786:b0:430:f301:3e6c with SMTP id ffacd0b85a97d-435f3aa7a0emr3036966f8f.34.1769764074550; Fri, 30 Jan 2026 01:07:54 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10e474csm20459988f8f.2.2026.01.30.01.07.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 01:07:54 -0800 (PST) Date: Fri, 30 Jan 2026 12:07:51 +0300 From: Dan Carpenter To: Minu Jin Cc: gregkh@linuxfoundation.org, bqn9090@gmail.com, abrahamadekunle50@gmail.com, straube.linux@gmail.com, bryant.boatright@proton.me, davidzalman.101@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: rtl8723bs: fix potential race in expire_timeout_chk Message-ID: References: <20260129023214.1149822-1-s9430939@naver.com> <20260129123342.309946-1-s9430939@naver.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260129123342.309946-1-s9430939@naver.com> On Thu, Jan 29, 2026 at 09:33:42PM +0900, Minu Jin wrote: > The expire_timeout_chk function currently do lock and unlock inside the > loop before calling rtw_free_stainfo(). > > This can be risky as the list might be changed > when the lock is briefly released. > > To fix this, move expired sta_info entries into a local free_list while > holding the lock, and then perform the actual freeing after the lock is > released. > > Signed-off-by: Minu Jin > --- > Changes in v3: > Suggested-by Dan Carpenter > - Use list_for_each_entry_safe() only for the new code. > - Remove blank line in the declaration block. > - Keep existing code unchanged Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter