From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Nuno Sá" <noname.nuno@gmail.com>, "Chen Ni" <nichen@iscas.ac.cn>,
haibo.chen@nxp.com, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, linux-iio@vger.kernel.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: vf610: Add missing check for device_property_read_u32_array
Date: Fri, 30 Jan 2026 07:25:08 +0200 [thread overview]
Message-ID: <aXxAtFgmX0odYwne@smile.fi.intel.com> (raw)
In-Reply-To: <20260129174021.4022306d@jic23-huawei>
On Thu, Jan 29, 2026 at 05:40:21PM +0000, Jonathan Cameron wrote:
> On Wed, 28 Jan 2026 09:29:47 +0000
> Nuno Sá <noname.nuno@gmail.com> wrote:
> > On Wed, 2026-01-28 at 12:27 +0800, Chen Ni wrote:
...
> Given the driver has a fallback for info->max_adck_rate[x] == 0
> I think this is intentional. It would be clearer if this had done.
>
> info->max_adck_rate[0] = 8;
> info->max_adck_rate[1] = 8;
> info->max_adck_rate[2] = 8;
Just in case, we have memset32() if it fits :-)
> device_property_read_u32_array(dev, "fsl,adck-max-frequency", info->max_adck_rate, 3);
>
> though rather than where it has the fallback in vf610_adc_calculate_rates()
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-01-30 5:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 4:27 [PATCH] iio: adc: vf610: Add missing check for device_property_read_u32_array Chen Ni
2026-01-28 6:02 ` Bough Chen
2026-01-28 9:09 ` Andy Shevchenko
2026-01-28 9:29 ` Nuno Sá
2026-01-29 17:40 ` Jonathan Cameron
2026-01-30 5:25 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXxAtFgmX0odYwne@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=noname.nuno@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox