From: Breno Leitao <leitao@debian.org>
To: Baoquan He <bhe@redhat.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, kexec@lists.infradead.org,
dyoung@redhat.com, tony.luck@intel.com,
xueshuai@linux.alibaba.com, vgoyal@redhat.com,
zhiquan1.li@intel.com, olja@meta.com
Subject: Re: [PATCH] vmcore_info: expose hardware error recovery statistics via sysfs
Date: Fri, 30 Jan 2026 03:07:52 -0800 [thread overview]
Message-ID: <aXyOsFomVyQNlMof@gmail.com> (raw)
In-Reply-To: <aXwQngYZx9Nk7hbv@fedora>
On Fri, Jan 30, 2026 at 09:59:58AM +0800, Baoquan He wrote:
> On 01/29/26 at 05:34am, Breno Leitao wrote:
> > Add a sysfs file at /sys/kernel/vmcore_stats and expose hardware error
> > recovery statistics that are already tracked by the kernel. This allows
> > userspace monitoring tools to track recovered hardware errors without
> > requiring kernel crashes.
>
> I don't understand. If w/o requring kernel crashes, why do you call it
> vmcore_stats? It's a normal showing of hardware error recovery
> statistics tracked by kernel, can we name it /sys/kernel/hwerr_stats?
Agreed, /sys/kernel/hwerr_stats is a much better name. Thank you for the
suggestion!
> It's obviously having nothiing to do with vmcore, isn't it?
You're correct. The only connection is that this functionality currently
resides in kernel/vmcore_info.c. I initially thought it would make sense
to create a generic sysfs entry for vmcore, but I can see now that this
caused more confusion than clarification.
I'll update the patch accordingly.
Thanks,
--breno
prev parent reply other threads:[~2026-01-30 11:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 13:34 [PATCH] vmcore_info: expose hardware error recovery statistics via sysfs Breno Leitao
2026-01-29 22:28 ` Andrew Morton
2026-01-30 11:33 ` Breno Leitao
2026-01-30 1:59 ` Baoquan He
2026-01-30 11:07 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXyOsFomVyQNlMof@gmail.com \
--to=leitao@debian.org \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=kernel-team@meta.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olja@meta.com \
--cc=tony.luck@intel.com \
--cc=vgoyal@redhat.com \
--cc=xueshuai@linux.alibaba.com \
--cc=zhiquan1.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox