From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a4-smtp.messagingengine.com (fhigh-a4-smtp.messagingengine.com [103.168.172.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BF822561AB; Fri, 30 Jan 2026 11:28:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.155 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769772507; cv=none; b=KpVNxcU5DrSy/QWisJWYZjlhDy8dW06Om8jpkx08/DQgyVUhseSO58sb3UWsjyni3FJ7xHHzhUENPISgv58jIYh185lKF5a2Z7lbEwPw5f13at8ha2pE8s9Mxy58n+tMFMyQ9v94Zyd6baZYywYZNb7OFzjl93opSEeCBnArs2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769772507; c=relaxed/simple; bh=rkG8xetznpS00ubWfKkmJIWYKAFjeq42mPQ7VWx586c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Gx7N0vsQ3pcrVk4wy30bMrN1Zsnq4T7Aneil6jXb7O1Xko2DLisQb2lKIOTp31cyDMqfW/f0iokWUp7fatvCK58a24iEZkRgnexsOVczN/mvuAAGF9yK07ZPswxVRb4Pm+plDg02x7JtKrI22DJdasOYaUwtTYK2nyfCf6EJtow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=ygZmXh/F; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=aKt0DvBZ; arc=none smtp.client-ip=103.168.172.155 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="ygZmXh/F"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="aKt0DvBZ" Received: from phl-compute-12.internal (phl-compute-12.internal [10.202.2.52]) by mailfhigh.phl.internal (Postfix) with ESMTP id 63A7A14000F5; Fri, 30 Jan 2026 06:28:23 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-12.internal (MEProxy); Fri, 30 Jan 2026 06:28:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1769772503; x= 1769858903; bh=ay+37y+yJvUhkN/e+UkFG+5HZ0yJBlraYJBawBaJYZQ=; b=y gZmXh/Fs9jNfNxcl8QicrfE2YZuOdJe6yTttkt8NKHVkfwK5Cr9mf+YJqeCvep3k 8PRUJnhKdwOnzeMhIKuLHprNqfaa0jevhFJEnuhRYRQkEDK/KyRJvoZlXNRJ9xzH ag4j2tlmAP8hndPw9orEMv8nmqKpKHxXO24liWNaOLklTx6jXdTS9adQu1+/+teJ 9myIw+m5X1PR+w7+/QNKsdyYXQCTssiK/8zWKwZFT9rq3dhgjOVk5qqgLpODJdzf AeaN4wC2Cc39wqz1Z0OKT+pn9IB3lriQIF6/+1H7NXVAN7lmIY6flpcsf/URQqpG KaEfxcCHJw9ZZhb2N4ztQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1769772503; x=1769858903; bh=ay+37y+yJvUhkN/e+UkFG+5HZ0yJBlraYJB awBaJYZQ=; b=aKt0DvBZBnhKYTkjLsIblJgs2TVlmZ8LOk27AnO9t/J8HS7KDjl MXhG7Lzr0ozPR4j8RACBLgWdDzh+zCcW2suhBPxoTRCXHsjNzD7HXOQb9C18pCYy pH57YcH1vxwZJsK7cq7XaDI5eNaygzSIbVQBBS6XrlIV7Eonhd9/yMPzwEIJoMm5 QEddN4fWdInYylFUFvPHVB61im1LDBCYpijU3tBeNlYBg/lcatxV9DrZnP4ZSQQW UKAgfCuxOZLbXcEnnn85FArrNKkXL4l8wvO28FII1nNGT3ZXYbZh2FkQiRL1+rc6 qu+dYD9EP1WalArtyk0rQt63WfPIvGK7Qhg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdduieekledvucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtjeenucfhrhhomhepufgrsghrihhn rgcuffhusghrohgtrgcuoehsugesqhhuvggrshihshhnrghilhdrnhgvtheqnecuggftrf grthhtvghrnhepuefhhfffgfffhfefueeiudegtdefhfekgeetheegheeifffguedvueff fefgudffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshgusehquhgvrghshihsnhgrihhlrdhnvghtpdhnsggprhgtphhtthhopedufedpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtoheprghnthhonhihrdgrnhhtohhnhiesshgvtg hunhgvthdrtghomhdprhgtphhtthhopehsthgvfhhfvghnrdhklhgrshhsvghrthesshgv tghunhgvthdrtghomhdprhgtphhtthhopehhvghrsggvrhhtsehgohhnughorhdrrghprg hnrgdrohhrghdrrghupdhrtghpthhtohepnhgvthguvghvsehvghgvrhdrkhgvrhhnvghl rdhorhhgpdhrtghpthhtohepuggrvhgvmhesuggrvhgvmhhlohhfthdrnhgvthdprhgtph htthhopegvughumhgriigvthesghhoohhglhgvrdgtohhmpdhrtghpthhtohepkhhusggr sehkvghrnhgvlhdrohhrghdprhgtphhtthhopehprggsvghnihesrhgvughhrghtrdgtoh hmpdhrtghpthhtoheptghhihgrtghhrghnghifrghnghesghhoohhglhgvrdgtohhm X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Jan 2026 06:28:21 -0500 (EST) Date: Fri, 30 Jan 2026 12:28:19 +0100 From: Sabrina Dubroca To: Antony Antony Cc: Steffen Klassert , Herbert Xu , netdev@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chiachang Wang , Yan Yan , devel@linux-ipsec.org, Simon Horman , linux-kernel@vger.kernel.org Subject: Re: [PATCH ipsec-next v5 3/8] xfrm: allow migration from UDP encapsulated to non-encapsulated ESP Message-ID: References: <7c30e7f8543048a384f693684ccba5f71fe8543b.1769509131.git.antony.antony@secunet.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7c30e7f8543048a384f693684ccba5f71fe8543b.1769509131.git.antony.antony@secunet.com> 2026-01-27, 11:42:40 +0100, Antony Antony wrote: > The current code prevents migrating an SA from UDP encapsulation to > plain ESP. This is needed when moving from a NATed path to a non-NATed > one, for example when switching from IPv4+NAT to IPv6. > > Only copy the existing encapsulation during migration if the encap > attribute is explicitly provided. Are we sure nobody out there relies on this behavior (silently copying the existing UDP encap without having to explicitly request it in the MIGRATE request)? If there are, this patch would break their setup by clearing the encap that they expect to still be present. -- Sabrina