public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <dgc@kernel.org>
To: alexjlzheng@gmail.com
Cc: cem@kernel.org, linux-xfs@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Jinliang Zheng <alexjlzheng@tencent.com>
Subject: Re: [PATCH 0/2] Add cond_resched() in some place to avoid softlockup
Date: Sat, 14 Feb 2026 08:38:27 +1100	[thread overview]
Message-ID: <aY-Z06HJnnB_Kdx3@dread> (raw)
In-Reply-To: <20260205082621.2259895-1-alexjlzheng@tencent.com>

On Thu, Feb 05, 2026 at 04:26:19PM +0800, alexjlzheng@gmail.com wrote:
> From: Jinliang Zheng <alexjlzheng@tencent.com>
> 
> We recently observed several XFS-related softlockups in non-preempt
> kernels during stability testing, and we believe adding a few
> cond_resched()calls would be beneficial.
> 
> Jinliang Zheng (2):
>   xfs: take a breath in xlog_ioend_work()
>   xfs: take a breath in xfsaild()
> 
>  fs/xfs/xfs_buf.c     | 2 ++
>  fs/xfs/xfs_log_cil.c | 3 +++
>  2 files changed, 5 insertions(+)

To follow up on my comments about cond_resched(), commit
7dadeaa6e851 ("sched: Further restrict the preemption modes") was
just merged into 7.0. This means the only two supported preempt
modes for all the main architectures are PREEMPT_FULL and
PREEMPT_LAZY.

i.e. PREEMPT_NONE and PREEMPT_VOLUNTARY are essentially gone and
only remain on fringe architectures that do not support preemption
or have not yet been fully ported to support preemption.

Hence we should be starting to consider the removal all the
cond_resched() points we have in the code, not adding more...

-Dave.
-- 
Dave Chinner
dgc@kernel.org

      parent reply	other threads:[~2026-02-13 21:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-05  8:26 [PATCH 0/2] Add cond_resched() in some place to avoid softlockup alexjlzheng
2026-02-05  8:26 ` [PATCH 1/2] xfs: take a breath in xlog_ioend_work() alexjlzheng
2026-02-05 10:54   ` Dave Chinner
2026-02-05 12:49     ` Jinliang Zheng
2026-02-05 20:27       ` Dave Chinner
2026-02-05  8:26 ` [PATCH 2/2] xfs: take a breath in xfsaild() alexjlzheng
2026-02-05 11:44   ` Dave Chinner
2026-02-05 12:49     ` Jinliang Zheng
2026-02-05 21:17       ` Dave Chinner
2026-02-05 10:39 ` [PATCH 0/2] Add cond_resched() in some place to avoid softlockup Dave Chinner
2026-02-13 21:38 ` Dave Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aY-Z06HJnnB_Kdx3@dread \
    --to=dgc@kernel.org \
    --cc=alexjlzheng@gmail.com \
    --cc=alexjlzheng@tencent.com \
    --cc=cem@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox