From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f46.google.com (mail-dl1-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E54C03542E6 for ; Wed, 11 Feb 2026 22:18:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770848306; cv=none; b=F2g38nhyrTWvvXiWc7crvk1XKRZ/QU8b4JehHSFa/3dYhW1PhVS5jyHhid2cVu78inlZjLGf6P6Vv1tBV1q47WbtowHYlDwIjdiv5P1BL7YPh8fjs92/1o7v7FJz2/ZTSeaoDcCTA9I+liNnAEHQUjTdU4+koUuRaovDAM6lDmw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770848306; c=relaxed/simple; bh=ovBbe9GcMrLxXSbjAE8rTjc+c5jEAhvsVtXqCbZ0iXM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Tfb8Z73corn78HNiqUVbJ7t1iZh62URUnT0idQh8/XBs1wowG+mPDFM7fGP1mgYcIwDTA3Z5ktwv9//wSeyGNqBqqmTRhaaEoc9J0ZPpJ2I8hXD3IQ2kgQVpnjIk/FswluJwJyIp7FjN5poT6GvNjKJyC3rOmAeBNrc+LZCbdFw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Mk8ITvVe; arc=none smtp.client-ip=74.125.82.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Mk8ITvVe" Received: by mail-dl1-f46.google.com with SMTP id a92af1059eb24-12713e56abdso959427c88.1 for ; Wed, 11 Feb 2026 14:18:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770848304; x=1771453104; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=E9Z7wrUPu/eDtNPIgAA170h+g7/v16GEGL2FZHaFyG4=; b=Mk8ITvVe4AkKPF/2Fy9jwRV/mpo9ifbGWfz8n9mW1Qx9sfCjlmk9AoT6L0aO98KZZG 9MdlOgC3xBE1vHurBYEutdbDiKU2SnsvBQXzVxaIfwK7GjXkCHTt5FsOYUkDd6ndDb6C LjEQJC/GOhMieFbMVOVuQfwkbC8HFlOxpyiRVdnqHj7EUYTsIZ2zlmGDJGbXK+AJOaaw IdX+wJ6TCxO5pNHLKvtBQj9NRlxAXAFqqOupJI1S6ciViJO3DyhUJUp3LL+tLQY647k4 wPcAb7sHyjmfCefUVqQOymMJjerYW6zCXmwF015A53EufEETPDUJ3bMSov3SB7YbflMz zj/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770848304; x=1771453104; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E9Z7wrUPu/eDtNPIgAA170h+g7/v16GEGL2FZHaFyG4=; b=OcogsxzPcgCwtl03OuW9lk8XyR3dDhhSmLmXc0ogXP1IEC9zbcS4Pwqp0UutGzLjkk kpnS7LwzhKR6u/2NHzw7/YzDpXei7pLPOdwoQqE1hzArkmK1aRflBhIlmSesn80GUeJ/ Mo19HN2yvHI8NBggvmruTUbi3cK121sWtWuknv+5qwYbmnQ5xh0t7I81pNYVRk7Z7QRA Ar3E5UFiWdFKAwSiFqJTKduOVtPQ/Ue9MSLixbo+cP1NGBYJGz4DX7PZ86X8EhV3BgfN 44GjqKYg18Ts6qiZY3xUxiZ/hbGSZk0/akN6cbkkGprEPMCpKoYgLth+C/QaKFq4ui6S xKaA== X-Gm-Message-State: AOJu0Yz3aZ1U19Xklm6LrtkUym29o87q+vgEKaPAJyeQRjgit68J4uNI jZ6IEHC9s0ddecTWYr/qL3mpbTFLm3P2kEZ/NYVfS5zxSQwhDk9Sf1ljXX7u1A== X-Gm-Gg: AZuq6aJJ2l7ep7JaEw8+79KZuQ/hT/eWskV3qnb7WAHK/fbhMdOFfL8oAQnnr6iza7a KBUEzrVYZ9Z+RKqdPT/ccE0z5LREx4eD4AfsrFoPH7+cfEXCejFLEwL+O99Y4C3ATYIEpL1wzC/ RcRVLZ5vIMQckapfOEjzAn5ylhsf5LSofo9VCJnbPbQ1qS8d2vZLXPIK0B0wcAj7jffonCbQL8m 0chEmAK2s8BhrhM+QcdxqokeUr3rEK25GM3Vg7C/OG0ZA/qNBxDthoEapNi9jCC81RijtZcXBlI Fin9RupOSuR6s2EzHwbnoNHRD3u9gNwt8olLOI/61UQyZcQ/nUIsiytv5fRdekAhwrMu0kvJlsW 0dQa5GRxo+T8p+QsMMIGKLmR+GlUftmdXyQQQTmXy0ZvyeaH2m5zUAI1c9O5HEhzaqH2gOrtbM2 u+5TtRLQ1lDMtBu0IT7tfrAJXF3bS+1cPkMG7ts+KIeE4kEomaXvYF9CA= X-Received: by 2002:a05:7022:619a:b0:123:3c65:d724 with SMTP id a92af1059eb24-1272fdc842amr209524c88.25.1770848303872; Wed, 11 Feb 2026 14:18:23 -0800 (PST) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ba9dcfe6b7sm2713774eec.29.2026.02.11.14.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Feb 2026 14:18:23 -0800 (PST) Date: Wed, 11 Feb 2026 14:18:20 -0800 From: "Vishal Moola (Oracle)" To: Dave Hansen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, "Mike Rapoport (Microsoft)" , akpm@linux-foundation.org, "Matthew Wilcox (Oracle)" , Dave Hansen , Andy Lutomirski , Peter Zijlstra Subject: Re: [PATCH v5 1/4] mm: Add address apis for ptdescs Message-ID: References: <20260211195233.368497-1-vishal.moola@gmail.com> <20260211195233.368497-2-vishal.moola@gmail.com> <0ead4a2d-c88c-4c89-b1dd-5954c28edb99@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0ead4a2d-c88c-4c89-b1dd-5954c28edb99@intel.com> On Wed, Feb 11, 2026 at 12:13:10PM -0800, Dave Hansen wrote: > On 2/11/26 11:52, Vishal Moola (Oracle) wrote: > > +/** > > + * pgtable_alloc_addr - Allocate pagetables to get an address > > + * @gfp: GFP flags > > + * @order: desired pagetable order > > FWIW, I don't like how pgtable_alloc_addr() looks in practice. It reads > like it is: "allocate a page table address", not "allocate a page > table". I don't have a better suggestion other than having: Hmmm. I meant for it to read "allocate a page table and get its address." > pgtable_alloc() > > that returns a page table pointer, a void*, and: Initially, I intended to name it pgtable_alloc() & pgtable_free(). I saw arm using pgtable_alloc() and powerpc using pgtable_free(), so I looked for another name. > ptdesc_alloc() > > which returns a ptdesc*. But I suspect that would get confusing at the > point that ptdescs _themselves_ start getting allocated. The ptdesc_alloc() equivalent right now is named pagetable_alloc(), so I don't think it'd get confusing.