From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f172.google.com (mail-dy1-f172.google.com [74.125.82.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 368E03542E6 for ; Wed, 11 Feb 2026 22:23:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770848634; cv=none; b=qTqHzYDmetDscXlg1dUizqBXF7i3rmjNhLg8AIgQQrcAKrT4ShysXSSbTR91aNcOfMoZDCyYsfngG+74JGJ6PIqNB4LHopriLN2QvPpRHtJG+nPJDwHf0ok2qJX+A/hFHNfcoeeqJBZrMWUhojDWGotHJXuzMcqymbXzvoxaOPg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770848634; c=relaxed/simple; bh=MsVvGY+EiJeo8mW1MX13W/QLBv3Wg3qexFFPvCehYP8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lmSljZJMAqactcA82fKdUNkvHnIg1C4qipSGS/9t/pOlV3zFJxF0QHHmeMloOCEkfQvBWjtojVp1oVZlwkrSlAUdU8KzQ3ThMzF+UdimCWs9Eic428ZH+LHWdtRl2UnGKHOUhwnGNTd8FBZTaa/sU2gjG8hZbodiK50cmXlXFFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J6Dn1neQ; arc=none smtp.client-ip=74.125.82.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J6Dn1neQ" Received: by mail-dy1-f172.google.com with SMTP id 5a478bee46e88-2b86671f87eso689487eec.0 for ; Wed, 11 Feb 2026 14:23:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770848632; x=1771453432; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2aPMYahgom9IxZ82sjrZyGh+YU8kYPUynbCqDa1XpeU=; b=J6Dn1neQd/e2HqQ54o4fEBbSZnlAIfWRehL2TXVV+amJfwROZ/O9jH4rFy8AXA40rT 1KWydp/hU8dbpQUUnV0GWNKBx/eBbxwmfhZxI4cd4yW3brjp2VTBuaydNfwTaxDDCV5c 4EK187G6NbfIcgvGZ1k651Sc7unIWF2MZ4ObdmVoXtepGjy6LMWFdtdHtTkWNYYAQQtu l50dC60Yb5yBDmypDHsZE0Ca6QDV+drcFz2Kmq6Hmwldj7mQYhy2zisftMSa7XZm0IHW y+n2grpuIxExOqH2o2jTklDBccLP2Oiot/M6dvWfJLQVmKTy++awcVp6vrd3aFKHC2nI G/WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770848632; x=1771453432; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2aPMYahgom9IxZ82sjrZyGh+YU8kYPUynbCqDa1XpeU=; b=cJzgp9AyKXvFbLBzut4N/BGQOkUDNqATceyjw/JCL7vH0nf+tRD2N4AKiFT46Hddax jGbAHS9/OD16nebvyqNnQJ0ELIU4es/Y77QOFnqb6sGw1+XZ/EHvvxQ1fSLONCXCJW0T LincMd3yNj13EJQXSlZwAJTM2ngFQWXBQfvTBsKm4gNsJOep6K/zGfBXCEVbwwknTL1W nW84DTd9+SP1/APKEHqPxX/0IQlICOdNgRYDFntJ2ar5/FGZSjjaJx1oDcXe1rTWeuus X1tcFwgX2/E9QI2ViQFubmstq1MlIxozZGxg/h36+b23VyFJfDx2yrzE239l6IuvNDYU LweQ== X-Gm-Message-State: AOJu0Yx3qop0s/qWLfdBhyC1oCiPgydwMgQt6NKtrMGW8QGNzJzAXN6p IRuIoqDKWY1tefrG4AWW9tvU/gVtejewFELCLSw72EMknowbsSGwQMwY X-Gm-Gg: AZuq6aLZupofh32GsXfFbT2vlbV9uP9AZkk39Gw8g1emlUzwK36GOA5oSDPiQTXYbok NkIq64CmjO516xVl3JPaD27tROdq+uaAhihAsX/5YnSLvfTmV7MK5Ug1nltRXQiYWAiYfUngbJV XGJCBLY/Px6zG43OqC2Zj0zKGMBGGRdCcpWOd5KPKEzoFpYCXZecJo3PCTxo8Vh2fM9NFSvmxLV p3t4laZsDA4PfaIo5Kdl0U3LgTvEzc0Z0YeDzaFoGzpwN+CNUA75AqO5zAYryfBayIYhvs1DWGd 6vPPrlYmAGVNVRVJVpaNyW5squnE35ka0nIXU8K3mK4vqml3qRIMIPjZtoJPhxdGtxs1NTwlVnD z+eK8fbICOtMrUAIoY5s9dSpyZgWNw4mtLBGgDNtMqoFO+H+3Uw6BF/se6//kkacjqYoXKNb3SR LbFZIOBv0QFjkK8Z5PqdPujI7ntqprhF2ropK8VZsQ5z1Fb+GiPRwv2Q0= X-Received: by 2002:a05:7300:a887:b0:2b8:66f3:2522 with SMTP id 5a478bee46e88-2baa7f66c67mr448011eec.3.1770848632266; Wed, 11 Feb 2026 14:23:52 -0800 (PST) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ba9dcead67sm2228631eec.26.2026.02.11.14.23.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Feb 2026 14:23:51 -0800 (PST) Date: Wed, 11 Feb 2026 14:23:49 -0800 From: "Vishal Moola (Oracle)" To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, "Mike Rapoport (Microsoft)" , akpm@linux-foundation.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra Subject: Re: [PATCH v5 2/4] x86/mm/pat: Convert pte code to use ptdescs Message-ID: References: <20260211195233.368497-1-vishal.moola@gmail.com> <20260211195233.368497-3-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Feb 11, 2026 at 09:55:51PM +0000, Matthew Wilcox wrote: > On Wed, Feb 11, 2026 at 11:52:31AM -0800, Vishal Moola (Oracle) wrote: > > -static bool try_to_free_pte_page(pte_t *pte) > > +static bool try_to_free_pte(pte_t *pte) > > I don't like this name though. You're not freeing a single PTE, > you're freeing a level of page tables. How about > try_to_free_pte_table()? Ah, right. That would make sense to me. Dave doesn't want the renaming at all[1], so I'm planning to leave it as try_to_free_pte_page() though. [1] https://lore.kernel.org/linux-mm/20260211195233.368497-1-vishal.moola@gmail.com/T/#m72f1d8d91b16f0693cca4271cc8685d2337372d7