From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f173.google.com (mail-dy1-f173.google.com [74.125.82.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC174288C20 for ; Wed, 11 Feb 2026 22:38:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770849537; cv=none; b=WxN+XvK5cgpn+8Rhc2gL1EYpb6g+rmOTWaPQxdNVYEKmXv0ZSpfseTRPrp/8JEy5uwGkog4YjkkshsucMDISQqxTXgOQ4PVof5FB97vBa8Va51Kqq66U3uCbnZVce8Ye/liY66Bn5AMR1wf4hj3SHbdnGi9Tj4m1Sce4WV6Grws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770849537; c=relaxed/simple; bh=AUO9Iz/JNUrekDZ4GdqcnA8tXNrrA29PpkAy1qHlS4A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b2HPIC4KtciKTTQ6FmrsbvZhgn1ZBjvfKhOePFKjcLPs+Bi3dk4PACCwtepA5nKTNV+BBVbFKl0jfPxXKliKhuIEZ5WFTz4E3wEENC5hrBk23/qu9R5qZbJQlKZq39vSRh2yoNP1pMBP61UI5BGbZ2D3uvF7ZDnu7gNLVjKBnSo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pjsxi+rI; arc=none smtp.client-ip=74.125.82.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pjsxi+rI" Received: by mail-dy1-f173.google.com with SMTP id 5a478bee46e88-2ba9d13f10eso50455eec.0 for ; Wed, 11 Feb 2026 14:38:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770849536; x=1771454336; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KBtZyZv/k/CWYzcfXcthUFUg18flW9coOP2MiyQMzYQ=; b=Pjsxi+rIxVI3O4W77DxwlnPW3P6Yo3Wig/ux7DlpDfNUpd3hKr1V0ZNsHulncjoH7q SMhy1dr+Ec9IAOpSgYn07XegGo16IGFCSXW7ON1wLoD1GezsNtr/7g+VO8tDt/DAM8vB gzQYZGmR2f4J/AB3elEIUfH1TCoP96vZLLZ/NuQnZ4Isxi9u4xEFQ/8liQYjNm/m9vhq 1cqUgyu6akJtanze3SGF0j2CN7lTsC5TkW9c1no6E4MD47cUUrGEjcltifXpr7M/ywf9 ME/8NBrbtKPxMUwqyb9v+qEx7E8UVqIWJxdLJrL8STj65swIDKOhC6l2jelneU+O+7Nu Khww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770849536; x=1771454336; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KBtZyZv/k/CWYzcfXcthUFUg18flW9coOP2MiyQMzYQ=; b=HNZuV9EoetDrdhSPiX1KlFyw36Q8tvMp8wG/osovC9wnM5Z1gVgR1kyGPP6bYUhP+n kDPaO6f2y2xG96KZvuCWoT3xtG0jPys38IFU1cvCpxWrUw1xeZqAX5xVojAMuounYyS2 qFbzSwAT8IS1QySkIo0sFS4nYqd/4y3dkLmLaQQtnDGx2ydBpl6NJh/8fHZA6S3rj+4+ RhBJcRmjQx3y8aCKbhvmD1lD+JQFwhH8keFKE/rKSGc90EJM2ndZ+C6LqIQWLeg/aFct fCy141xevKbxK67uMsnrL8LaDD49PJKKmq0MTzQ8JAHnZGiqtibuqO2L4L8qE82XrIrB 6Tkw== X-Gm-Message-State: AOJu0YzETR8t+2W5w5J/gMe/x7kdfZYUKgXTkD4U08DFBc62IEE5uc9p evYiN00UJP49iU3mKLYe321KLiQhjsSwF3y1nO8huoWTaNn8ZWuuELrM X-Gm-Gg: AZuq6aKzbYq1O4ep5NTWPMLaiLt8RS9laoRi8zyYMAx0VRDb6ruSHZWty67XdOfbetP QV4f7V4YU+QfXWqNgyAS66gyM7M+QVLV/+/EmK9FdFq5tArmSYxXOfbiEWcb61+ejSS6cZXJG3W bgaifeN4kQMu0/wObPEaRmAEwNtNspsH1RCEHJ0lgKa9V3Ucc7653M/L3ZiRTgqYDjor8I9mE2z 0CbL+6lWYnAc4cfgrodS7rP3j+b6fgrNu1s/HebnP6tpfGqqg8sa2CXrRJoqxgN91YC1QKYB8D1 ftid54WNBcz8R7YwUmUEpynl3PEZcDlhRnpjD0v3h4ioY6md6KuEFh1u4H+ts+SgGmpu9L2YjVv RWGyAZXpOBrppgmOuz7Mo04QyTyBoollHtbQ7SjbLvZcBT/OMzK2wvrMmxeO0lwyK9Orb4zHMD8 dpJxLigiqkwvuSRP+DoD5t0Knz86ggZ27aknjt4QyeiSehE6OkghmoFts= X-Received: by 2002:a05:7300:7c10:b0:2b9:1375:b546 with SMTP id 5a478bee46e88-2baa7fbc0a0mr449042eec.16.1770849535629; Wed, 11 Feb 2026 14:38:55 -0800 (PST) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ba9dba3317sm2328461eec.5.2026.02.11.14.38.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Feb 2026 14:38:55 -0800 (PST) Date: Wed, 11 Feb 2026 14:38:52 -0800 From: "Vishal Moola (Oracle)" To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, "Mike Rapoport (Microsoft)" , akpm@linux-foundation.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra Subject: Re: [PATCH v5 4/4] x86/mm/pat: Convert split_large_page() to use ptdescs Message-ID: References: <20260211195233.368497-1-vishal.moola@gmail.com> <20260211195233.368497-5-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Feb 11, 2026 at 09:59:19PM +0000, Matthew Wilcox wrote: > On Wed, Feb 11, 2026 at 11:52:33AM -0800, Vishal Moola (Oracle) wrote: > > static int > > __split_large_page(struct cpa_data *cpa, pte_t *kpte, unsigned long address, > > - struct page *base) > > + struct ptdesc *ptdesc) > > { > > unsigned long lpaddr, lpinc, ref_pfn, pfn, pfninc = 1; > > + struct page *base = ptdesc_page(ptdesc); > > pte_t *pbase = (pte_t *)page_address(base); > > We have ptdesc_address() already. Can we avoid the other uses of > 'base' in this function? We could, but not without helpers similar to folio_pfn() and folio_mk_pte(). I hadn't added those in this patchset since my primary goal right now is to ensure all the allocation/free sites are using the proper apis.