From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44283153598 for ; Thu, 12 Feb 2026 01:30:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770859831; cv=none; b=UjIrQt9CNFyNGhaozxmyfNp6tIdhhNppH9p9Gwnh++A+ZQHHndYuObQI2IJmHpxYo++JW2uVHBfxKA0fSmHcDaZt4yySyjNjJAM7MyIqFakGq/56K1z+q9aHDp1jqc78hUQiHn3hds1tYeuOqMsCj3RMxbOUNKBRqfsgEsK/IcI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770859831; c=relaxed/simple; bh=KgiA3wWySdtu27emmfFx9TmT091bq+yUVCdDCtZD06E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PAyuUzKtt+zt6Z9cbTPvZ/rONfzPX1t/SMdrFhPxTepP6nrGjXf60F8aA+O3lEUvIsQ8zoiLaT498QhgentWmkVF/ZDVnYa5dcm+J4NpbPgBol3s0l9DAfCiX7zfdO/BkZHFAlC6aBAC5le6jrQEBkj14Ee6QkEn4v2IuOOhD0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AstQJRbp; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=GKGmUkrr; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AstQJRbp"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="GKGmUkrr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770859828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bY4z6uuO6pRuPz5GN5A8CgMrwxk/puAYj4i3AjMGr9s=; b=AstQJRbpgZMBDfedPSvIG3Xnm5M2B//WLIDQk+TQjtOT3E6HivpB5auxwSEoGzSe4NadKB 4VX0yKUdUPfE+Bo5cB8Zvun30ncCADH3u1Nmka9q4M8pdlDxKVaJGgVOJpoBiAOn5fAxAe d9b0KsQkGsIPO7slZKuV4rPPHflHXtk= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-118-8Box1YY6M4C7b-NMlE7imQ-1; Wed, 11 Feb 2026 20:30:26 -0500 X-MC-Unique: 8Box1YY6M4C7b-NMlE7imQ-1 X-Mimecast-MFC-AGG-ID: 8Box1YY6M4C7b-NMlE7imQ_1770859826 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c6de1ee12a3so3283662a12.2 for ; Wed, 11 Feb 2026 17:30:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770859825; x=1771464625; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bY4z6uuO6pRuPz5GN5A8CgMrwxk/puAYj4i3AjMGr9s=; b=GKGmUkrrbyream/4X1gm8LzWWQTYogwaWoUAN3ffdevUBmJlEEeGFN0ibUVRN/k9tK RjeYEMt0KWiTkt+6BXlgB4+SwLrEx3SR7yZgeIQO4JpRnfTdkz7/fjUukGVLHzcO6Dw3 gGnEyzcxouaSAMPg/WWx1qJtznn1N2idu9R8SkuRGTvKjLerOo1h09B+ucytt3kGi9rn TgOOHZsORTcBwMq53N/P7KApSODNDcM7tgOj2vwigNjKGfFXYinj1JlBxiy6RfEIhrO9 qCut5DDh2casD0/iIQYvXKgFyDdHh4Dd4i5TL7wWKoAmdX6kAg/vXHJwQEJa8CPwwF9J W3vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770859825; x=1771464625; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bY4z6uuO6pRuPz5GN5A8CgMrwxk/puAYj4i3AjMGr9s=; b=tySuMTwY6Oz/vnnRKDPvHR06dlCreBma628XU4l/V7cZinK4bM02B5WkGvljGJChSn AKxu3bhKPnO2nYxMdAWyxhNKZRUc3xpGWya6t3VV1izN4yVAcBQFajMRK7+3ZwDZjEfJ wp+rX8AGnnFpMWOa4u7prVbLmW6yy8nV31h+mY0PlR84IWaFi2neTgn1cW24m1DD5UWc AzjfaVBTuBWsRihf5hgviuboVFR065kAkLNZLOwY+LMqifG51QnTI9u84pHXt2G3OqMG 1i+U2Z3i84mZFS3pCFq//AQ9D68CECyj38jCvyeMog7sfyurJbiU7GZq6DVxJmxYtxBo hm4A== X-Forwarded-Encrypted: i=1; AJvYcCVaqbAOT/i5/VylzLdxDuzeF6svpp0p4qgnZLalilHfNB9LYvqnXsLU4OTq/8eX4HnBfgfCI2D70p1S1x8=@vger.kernel.org X-Gm-Message-State: AOJu0YzqmgxWPLp/GeE5T18DmFxcMV/19ahfBLRuFldj7/HpW14Jjnnb zhU3qWvoUhSytTgXS4rr8SycmXmh+4MHXTQuXb9Pqrx4K7yrob4s96qZ3ZOJZYr8NXPmjVxjlkN 3XVIqTkyfQLHZ3raWNlVMtZdSu0RlcmAD2EKQJKhRS1QqjVSr17Ii0Ggu2Mo78QlY8qu66jZiTe cUEhk= X-Gm-Gg: AZuq6aIa/6OPcZnNvPyU7L+3onwpg3T8TnB0P7pawSta9SlqDmp59y9cbBULYp3E9O0 /+kxJaRauroXjcdRCmrx6t7Vtxri5rP7JxL2Tq55C7d2qkysgFuWaad+5ZQ+FGGit96tw0ihrKC 6qUmxX8dZ+i0dnt296xFNBqxZNbjZoLmc+swLWBl7rDa5NEXITqyUmqugb4A/qAQ+f51qPJUViH NXPyl/CfEp4d09yKC5MS6Yko+C02IbEHfQvPu8vuIkz2Gwk+w8KWrD42rwROD2idKlEaga89qT0 joW+zdEOt9XOoVbjO7Nj3GPd4SujKwPFQOcrtZelnfEnfSqyxRpeHjArTI8I7zrU7pj/vLApz1N qM/xTKTfERpMV X-Received: by 2002:a05:6a20:e20d:b0:38d:fc34:c88d with SMTP id adf61e73a8af0-3944887601cmr937854637.55.1770859825458; Wed, 11 Feb 2026 17:30:25 -0800 (PST) X-Received: by 2002:a05:6a20:e20d:b0:38d:fc34:c88d with SMTP id adf61e73a8af0-3944887601cmr937804637.55.1770859824883; Wed, 11 Feb 2026 17:30:24 -0800 (PST) Received: from localhost ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6e197f7e0bsm3248413a12.27.2026.02.11.17.30.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Feb 2026 17:30:24 -0800 (PST) Date: Thu, 12 Feb 2026 09:28:43 +0800 From: Coiby Xu To: Mimi Zohar Cc: linux-integrity@vger.kernel.org, Heiko Carstens , Alexander Egorenkov , Ard Biesheuvel , Dave Hansen , Roberto Sassu , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Dmitry Kasatkin , Eric Snowberg , Paul Moore , James Morris , "Serge E. Hallyn" , Jarkko Sakkinen , open list , "open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)" , "open list:S390 ARCHITECTURE" , "open list:EXTENSIBLE FIRMWARE INTERFACE (EFI)" , "open list:SECURITY SUBSYSTEM" , "open list:KEYS/KEYRINGS_INTEGRITY" Subject: Re: [PATCH v2 1/3] integrity: Make arch_ima_get_secureboot integrity-wide Message-ID: References: <20260203041434.872784-1-coxu@redhat.com> <20260203041434.872784-2-coxu@redhat.com> <66f9d13875e81a965984e2a661e992a3fe43c516.camel@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <66f9d13875e81a965984e2a661e992a3fe43c516.camel@linux.ibm.com> On Mon, Feb 09, 2026 at 03:43:08PM -0500, Mimi Zohar wrote: >On Tue, 2026-02-03 at 12:14 +0800, Coiby Xu wrote: >> EVM and other LSMs need the ability to query the secure boot status of >> the system, without directly calling the IMA arch_ima_get_secureboot >> function. Refactor the secure boot status check into a general function >> named arch_get_secureboot. >> >> Reported-and-suggested-by: Mimi Zohar >> Suggested-by: Roberto Sassu >> Signed-off-by: Coiby Xu > >Thanks, Coiby. Other than unnecessarily splitting a line, the patch set looks >good. As soon as the open window closes, I'll queue these patches for linux- >next. Hi Mimi, thanks for reviewing the patch set! Would you like me to send a new version with the line splitting issue fixed? > >> diff --git a/security/integrity/ima/ima_efi.c b/security/integrity/ima/ima_efi.c >> index 138029bfcce1..27521d665d33 100644 >> --- a/security/integrity/ima/ima_efi.c >> +++ b/security/integrity/ima/ima_efi.c [...] >> { >> - if (IS_ENABLED(CONFIG_IMA_ARCH_POLICY) && arch_ima_get_secureboot()) { >> + if (IS_ENABLED(CONFIG_IMA_ARCH_POLICY) && >> + arch_get_secureboot()) { > >No need to split the line here or below. > > >> if (IS_ENABLED(CONFIG_MODULE_SIG)) >> set_module_sig_enforced(); >> if (IS_ENABLED(CONFIG_KEXEC_SIG)) >> diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c >> index 5770cf691912..6d093ac82a45 100644 >> --- a/security/integrity/ima/ima_main.c >> +++ b/security/integrity/ima/ima_main.c >> @@ -949,8 +949,8 @@ static int ima_load_data(enum kernel_load_data_id id, bool contents) >> >> switch (id) { >> case LOADING_KEXEC_IMAGE: >> - if (IS_ENABLED(CONFIG_KEXEC_SIG) >> - && arch_ima_get_secureboot()) { >> + if (IS_ENABLED(CONFIG_KEXEC_SIG) && >> + arch_get_secureboot()) { > >===> > >Mimi > >> pr_err("impossible to appraise a kernel image without a file descriptor; try using kexec_file_load syscall.\n"); >> return -EACCES; >> } > -- Best regards, Coiby