From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E94F2C234C; Thu, 12 Feb 2026 09:50:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770889820; cv=none; b=dcqmr9/LMHLoW2d0eybA+xzaKxtbZhm2UIpqbEhvlzVedKFqtAPpLYTkP0AMQUtzK3++uD9VGM7y08gw0N7uxLHKhKjoTnLvLd6Gi7cc0cxWfXRiFV6AqJAc8/1eSrR9J2dKDWcfw+XyrjuI2glpHsdfnbYoLqJsByS+WxFq9HU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770889820; c=relaxed/simple; bh=uqYHV6WHUvhDsOBpe5pUyJM0Yd06seajXeuYOQbHbXI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TgRVGUdzqovimDc09sIMmVr4IBX3nNK8BezhdA/wW0mbr0H5XuvIHkxdg5s3yRL/UqTcxnwMv0jpXebLfylSUBDq6pdE2yLpoI7BV/aeB8hm03Wj5XcBhtz/ngUDWi0N6+aOOpY7HPPuJzY/Vh3Z++I9HIChs61Q+QEg136285I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fDHiFy8K; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fDHiFy8K" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770889819; x=1802425819; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=uqYHV6WHUvhDsOBpe5pUyJM0Yd06seajXeuYOQbHbXI=; b=fDHiFy8K9aPFSwW4cpYx8sb5QPWHZgahAj5mIrs2sPwsnoOJvxntepHG T9o02/z1avK3/khZtCIafIWQBfHtS1YhN855fAVqwpUwHEVra6PT8ocyJ NMvq32htb8R+mVzCySPGoWxMI9IcOwFS8VYDa1Ay9C9WtjXr4czP6Xaa0 k2QsI5tnQ7yv6GHeqDK0L+9X5Izj5eehQ+xmchr3k3VvJMXPEaJD6PR27 vNLcoBBsHPrfqhgD4Pno137D/zhbo9k/PYuaa3AaEi9e07apZBiasxUek aSABWceG2G35HMsijOAIWFl7vDjRONlMXDnjQ4zOddH3/CKBTxZyPGdog w==; X-CSE-ConnectionGUID: 1tJ/AlokQVuCUEXTWX9poA== X-CSE-MsgGUID: c9Vsv0ZkTkuykOw5VXDoFQ== X-IronPort-AV: E=McAfee;i="6800,10657,11698"; a="82782874" X-IronPort-AV: E=Sophos;i="6.21,286,1763452800"; d="scan'208";a="82782874" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2026 01:50:19 -0800 X-CSE-ConnectionGUID: khGUbtBfQzOmjeG1/MJmHw== X-CSE-MsgGUID: tYbxTNxvSGuPd92sVt40hg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,286,1763452800"; d="scan'208";a="216708934" Received: from mev-dev.igk.intel.com ([10.237.112.144]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2026 01:50:15 -0800 Date: Thu, 12 Feb 2026 10:47:11 +0100 From: Michal Swiatkowski To: Petr Oros Cc: netdev@vger.kernel.org, Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Swiatkowski , Wojciech Drewek , Simon Horman , intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH iwl-net 1/2] ice: fix inverted ready check for VF representors Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Feb 12, 2026 at 08:53:10AM +0100, Petr Oros wrote: > Commit 0f00a897c9fcbd ("ice: check if SF is ready in ethtool ops") > refactored the VF readiness check into a generic repr->ops.ready() > callback but implemented ice_repr_ready_vf() with inverted logic: > > return !ice_check_vf_ready_for_cfg(repr->vf); > > ice_check_vf_ready_for_cfg() returns 0 on success, so the negation > makes ready() return non-zero when the VF is ready. All callers treat > non-zero as "not ready, skip", causing ndo_get_stats64, get_drvinfo, > get_strings and get_ethtool_stats to always bail out in switchdev mode. > > Remove the erroneous negation. The SF variant ice_repr_ready_sf() is > already correct (returns !active, i.e. non-zero when not active). > > Fixes: 0f00a897c9fcbd ("ice: check if SF is ready in ethtool ops") > Signed-off-by: Petr Oros > --- > drivers/net/ethernet/intel/ice/ice_repr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_repr.c b/drivers/net/ethernet/intel/ice/ice_repr.c > index cb08746556a670..2a84f656405828 100644 > --- a/drivers/net/ethernet/intel/ice/ice_repr.c > +++ b/drivers/net/ethernet/intel/ice/ice_repr.c > @@ -315,7 +315,7 @@ ice_repr_reg_netdev(struct net_device *netdev, const struct net_device_ops *ops) > > static int ice_repr_ready_vf(struct ice_repr *repr) > { > - return !ice_check_vf_ready_for_cfg(repr->vf); > + return ice_check_vf_ready_for_cfg(repr->vf); > } > > static int ice_repr_ready_sf(struct ice_repr *repr) > -- > 2.52.0 > Thanks for fixing Reviewed-by: Michal Swiatkowski