From: Jiri Olsa <olsajiri@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>
Subject: Re: [PATCHv3 bpf-next 4/5] selftests/bpf: Add test for checking correct nop of optimized usdt
Date: Thu, 12 Feb 2026 15:10:11 +0100 [thread overview]
Message-ID: <aY3fQ-3KICVGLAKP@krava> (raw)
In-Reply-To: <CAEf4BzYVhVabvXRNGycSzA57HbF7ECZeYCQ1chq7HxXTi6gogQ@mail.gmail.com>
On Wed, Feb 11, 2026 at 01:45:24PM -0800, Andrii Nakryiko wrote:
SNIP
> > diff --git a/tools/testing/selftests/bpf/progs/test_usdt.c b/tools/testing/selftests/bpf/progs/test_usdt.c
> > index a78c87537b07..6911868cdf67 100644
> > --- a/tools/testing/selftests/bpf/progs/test_usdt.c
> > +++ b/tools/testing/selftests/bpf/progs/test_usdt.c
> > @@ -138,4 +138,13 @@ int usdt_sib(struct pt_regs *ctx)
> > return 0;
> > }
> >
> > +int executed;
> > +
> > +SEC("usdt")
> > +int usdt_executed(struct pt_regs *ctx)
> > +{
> > + executed++;
>
> did you try capturing pt_reg's ip value and validating it?
ok, it's easy to add that check
jirka
next prev parent reply other threads:[~2026-02-12 14:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 8:48 [PATCHv3 bpf-next 0/5] libbpf: Make optimized uprobes backward compatible Jiri Olsa
2026-02-11 8:48 ` [PATCHv3 bpf-next 1/5] selftests/bpf: Emit nop,nop5 instructions combo for x86_64 arch Jiri Olsa
2026-02-11 8:48 ` [PATCHv3 bpf-next 2/5] libbpf: Add uprobe syscall feature detection Jiri Olsa
2026-02-11 21:45 ` Andrii Nakryiko
2026-02-12 14:08 ` Jiri Olsa
2026-02-11 8:48 ` [PATCHv3 bpf-next 3/5] libbpf: Add support to detect nop,nop5 instructions combo for usdt probe Jiri Olsa
2026-02-11 21:45 ` Andrii Nakryiko
2026-02-12 14:08 ` Jiri Olsa
2026-02-11 8:48 ` [PATCHv3 bpf-next 4/5] selftests/bpf: Add test for checking correct nop of optimized usdt Jiri Olsa
2026-02-11 9:13 ` bot+bpf-ci
2026-02-11 21:45 ` Andrii Nakryiko
2026-02-12 14:10 ` Jiri Olsa [this message]
2026-02-11 8:48 ` [PATCHv3 bpf-next 5/5] selftests/bpf: Add usdt trigger bench Jiri Olsa
2026-02-11 21:45 ` Andrii Nakryiko
2026-02-12 14:09 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aY3fQ-3KICVGLAKP@krava \
--to=olsajiri@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox