From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F23835CBD1 for ; Thu, 12 Feb 2026 15:00:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770908412; cv=none; b=cE6DNDIWFGdxW7WyQDIAUhw3+u+g+LiH0EW/donB03akppW9dS7HUpXuRJGtBC68k3zG387GvvnSaiTc03lkbeXoKpBrqiBnhmH0zCQre8fRkHFP57oQbbx1m9X5G2PxCe9X721JI7EELrHSTVRU73LiD8YeGCN1TdNMz9apcaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770908412; c=relaxed/simple; bh=p5Hmrmgn1UcxHmYPea4G80SvvCs1nZ6lsT+jQk3xr2o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=akhXaYv/9YtnBBvxF1J8epngPnx/JU0ZN4lrLoWokmRwMuAJC5vaKpfi6FYWhoxCJOHxd8J4ANQxskgzmCn35xmVZ+3AKilb7cOJRuw8dypO0BWrjMyCSRPY4z5seO5HPuj9E+oaX3huxGTGVYhFUCKjZa+Ebmdv+CPG5nwR2HI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GPoFKOAb; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GPoFKOAb" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4801bc32725so49839885e9.0 for ; Thu, 12 Feb 2026 07:00:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770908410; x=1771513210; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IINbxAJGaRHEvEhY0z4nrEUHRqDZtjxcQiB88qmwdnM=; b=GPoFKOAb5SJUvqaJNZgVLdNYytECJOoP/H05zzdU+wnwE1yFU+Epe9bn6KgFSMI3EA mB9lUK9WXJ4y3wUTPR7dBaq8FkKlHyEyUiSL0uxn9P8xTSBqd6jLv1pxph7Od358740H o71EiInrgMu6yQWNMsorME/HpZVxwChxeJ86j4EBoybjidK4k8A76syicGoIEaXt3lVO OULZBNfPCb2MXji5QqkAAxuv7GSCO9J54o5DMc9oD8cl1Bwl2ZTc8YkieIzFd8u2P6uy PkKL7uMBhTqAoS+g9VUx0asL0g1lSQbPi8BpoO9imYRxw5wEgBqNlcoX9NrqRkhPmGP5 c2ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770908410; x=1771513210; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IINbxAJGaRHEvEhY0z4nrEUHRqDZtjxcQiB88qmwdnM=; b=AHBPQdZ9kLzpQQUVxkTkvc+R5CX93lWDyfm9UAS5GFsxoxgU0YKw7nKlnXNkZ8HYNZ Qoix3GoWiTzWhDD+SD0HT87Z9qOK+PBW/06K72rwiymkB1QvVx6koFsqbMrenJsciiET Qm9f9VePds3IHgz7ZYvymsDi+3SuiecDknxIKvLO/ZHv02M7If0PsHvZ8rvfbybmcs6P zOWUTFdaGwQlEVWjLigIo1G37X8CjuThqtHNMKrSloCgVFIZr6cpcIjdoBVYX/j46G4Z oIMRG4TqqAl2NBusUlo3eRI1xSHi4Y6Dtdno5FCqmNU/Vo0LP0IsROC7fjx5fkdMiQ7x IKqw== X-Forwarded-Encrypted: i=1; AJvYcCVGAeLgyHZIMJndo+CI9Z3u8tGywzwjgfy6dHoZ/fr/MM0jAUor54YEwP2xi23dusHVoo2CDqkVKd0wUt8=@vger.kernel.org X-Gm-Message-State: AOJu0YyDDiHOTIweLYERz+5QiIdhgRNAKBUpxuQ6O5qf7KYq9bXMJGiw DvLj/kDVgB477cm5e6F6Pyf1lJeB2i9GGH3RhO+jlniCTSpdpan42Ry6tB9abuImQ00= X-Gm-Gg: AZuq6aIlkdAjx4HCqhktMOITpSMxxaBYY6nAxnUlHOcuO32hZW6GreLxxDJ0Cr8J2Zv En7T1cqiCpM/9KzBFFwm/IESadeRehL8deS2ywo4ADRgEkxip+rGgmgJ6rbLvw4W9Rw3TmA8SsO lQUVJYLbNGSOKZB/AXZbDbt38oLfU9iMFwIYTnZXd5rnvvxpjNM4DC1FfAZRwqjmy7EFz37lWr6 pJlrFwFI79l6//OzRp8JyeSq1ACaJZE6VNGNA7N3aCNR24IIq2AT8gj7u++s9DlMgslRPHr/dBe uRQaTsQaD/PO35cSZQuIHS66AMNX7ztxeeINHyWGbd+fE0r7fF41+Qlgg2ThwhnxDDxFczRRk40 gsIVBioFdWhr6r4UUvzO9FuAlotPQWhyHFw7HfNqWppXfj+fNfHZ288mEDkadDU5zxO2nLw8k1s nYUgaOnMHtfWgrvLu1siOh6Q9NOomT X-Received: by 2002:a05:600c:19ca:b0:482:dbd7:a1c1 with SMTP id 5b1f17b1804b1-48365720147mr47963225e9.34.1770908409591; Thu, 12 Feb 2026 07:00:09 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43783e0196bsm13599697f8f.23.2026.02.12.07.00.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 07:00:09 -0800 (PST) Date: Thu, 12 Feb 2026 18:00:03 +0300 From: Dan Carpenter To: RachelOvrani Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: sm750fb: Rename nDirection to new_direction Message-ID: References: <20260212105842.36431-1-rachel.ovrani@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260212105842.36431-1-rachel.ovrani@gmail.com> On Thu, Feb 12, 2026 at 12:58:42PM +0200, RachelOvrani wrote: > Rename the variable 'nDirection' to 'new_direction' > to fix the warning reported by checkpatch.pl > > Signed-off-by: RachelOvrani > --- > v2 -> v3 : Change the commit message more appropriately > v1 -> v2 : Renaming n_direction to new_direction > > drivers/staging/sm750fb/sm750_accel.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c > index e1877e5d0..c796d410c 100644 > --- a/drivers/staging/sm750fb/sm750_accel.c > +++ b/drivers/staging/sm750fb/sm750_accel.c > @@ -153,9 +153,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, > unsigned int width, unsigned int height, > unsigned int rop2) > { > - unsigned int n_direction, de_ctrl; ^^^^^^^^^^^ The old code should be nDirection so this isn't going to apply. > + unsigned int new_direction, de_ctrl; regards, dan carpenter