public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
	"Arnd Bergmann" <arnd@kernel.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Frank Li" <Frank.Li@nxp.com>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: endpoint: pci-epf-test: select configfs
Date: Fri, 13 Feb 2026 10:35:24 +0100	[thread overview]
Message-ID: <aY7wXJQJsfdqJ4j9@ryzen> (raw)
In-Reply-To: <554897dc-1cd6-461d-9248-cc491b984a9e@kernel.org>

On Fri, Feb 13, 2026 at 08:39:34AM +0900, Damien Le Moal wrote:
> > I think at that point we would instead drop PCI_ENDPOINT_CONFIGFS
> > as a Kconfig option, since it is never user selectable. Otherwise
> > this is probably a sensible solution as well.
> 
> +1. That option is mandatory, so it is not an option at all :)
> If PCI_ENDPOINT is set, we must have configfs.

A quick git grep:

$ git grep PCI_ENDPOINT_CONFIGFS
Documentation/PCI/endpoint/pci-ntb-howto.rst:If PCI_ENDPOINT_CONFIGFS is enabled::
Documentation/PCI/endpoint/pci-ntb-howto.rst:If PCI_ENDPOINT_CONFIGFS is enabled::
Documentation/PCI/endpoint/pci-test-howto.rst:If PCI_ENDPOINT_CONFIGFS is enabled::
Documentation/PCI/endpoint/pci-test-howto.rst:If PCI_ENDPOINT_CONFIGFS is enabled::
Documentation/PCI/endpoint/pci-vntb-howto.rst:If PCI_ENDPOINT_CONFIGFS is enabled::
Documentation/PCI/endpoint/pci-vntb-howto.rst:If PCI_ENDPOINT_CONFIGFS is enabled::
Documentation/nvme/nvme-pci-endpoint-target.rst:CONFIG_PCI_ENDPOINT_CONFIGFS, and CONFIG_NVME_TARGET_PCI_EPF enabled.
Documentation/nvme/nvme-pci-endpoint-target.rst:If PCI_ENDPOINT_CONFIGFS is enabled::
arch/arm/configs/multi_v7_defconfig:CONFIG_PCI_ENDPOINT_CONFIGFS=y
arch/arm/configs/omap2plus_defconfig:CONFIG_PCI_ENDPOINT_CONFIGFS=y
arch/arm64/configs/defconfig:CONFIG_PCI_ENDPOINT_CONFIGFS=y
drivers/pci/endpoint/Makefile:obj-$(CONFIG_PCI_ENDPOINT_CONFIGFS)       += pci-ep-cfs.o
drivers/pci/endpoint/pci-epf-core.c:    if (!IS_ENABLED(CONFIG_PCI_ENDPOINT_CONFIGFS))
drivers/pci/endpoint/pci-epf-core.c:    if (!IS_ENABLED(CONFIG_PCI_ENDPOINT_CONFIGFS))
include/linux/pci-ep-cfs.h:#ifdef CONFIG_PCI_ENDPOINT_CONFIGFS
tools/testing/selftests/pci_endpoint/config:CONFIG_PCI_ENDPOINT_CONFIGFS=y


I think we should just merge and send Arnd's fix to Linus for the 7.0
release cycle.

If we want to remove CONFIG_PCI_ENDPOINT_CONFIGFS, it will require changes
in the docs, defconfigs, etc., so it does seem like something that would
have to target 7.1 rather than 7.0.


Kind regards,
Niklas

  reply	other threads:[~2026-02-13  9:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11  7:07 [PATCH] PCI: endpoint: pci-epf-test: select configfs Arnd Bergmann
2026-02-11  8:43 ` Damien Le Moal
2026-02-11  9:05 ` Niklas Cassel
2026-02-11  9:37   ` Arnd Bergmann
2026-02-12 23:39     ` Damien Le Moal
2026-02-13  9:35       ` Niklas Cassel [this message]
2026-02-18 18:00         ` Bjorn Helgaas
2026-02-19  9:02           ` Niklas Cassel
2026-02-19 13:04             ` Niklas Cassel
2026-02-19 16:13               ` Bjorn Helgaas
2026-02-19 19:14                 ` Niklas Cassel
2026-02-19 16:00             ` Bjorn Helgaas
2026-02-18 18:00 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aY7wXJQJsfdqJ4j9@ryzen \
    --to=cassel@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=dlemoal@kernel.org \
    --cc=kishon@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mani@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox