public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <frederic@kernel.org>
To: Shubhang Kaushik <shubhang@os.amperecomputing.com>
Cc: Anna-Maria Behnsen <anna-maria@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@kernel.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Valentin Schneider <vschneid@redhat.com>,
	dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de,
	rostedt@goodmis.org, Christoph Lameter <cl@gentwo.org>,
	linux-kernel@vger.kernel.org,
	Adam Li <adamli@os.amperecomputing.com>
Subject: Re: [RESEND PATCH] tick/nohz: Fix wrong NOHZ idle CPU state
Date: Fri, 13 Feb 2026 14:11:34 +0100	[thread overview]
Message-ID: <aY8jBnJgnpKdUpD4@localhost.localdomain> (raw)
In-Reply-To: <dc75bfd7-eb4b-0f1d-057a-92ef805521e3@os.amperecomputing.com>

Le Thu, Feb 12, 2026 at 12:04:11PM -0800, Shubhang Kaushik a écrit :
> On Thu, 12 Feb 2026, Shubhang Kaushik wrote:
> 
> > >  Because you rely on dynamic placement of isolated tasks throughout
> > >  isolated
> > >  CPUs by the scheduler.
> > > 
> > >  But nohz_full is designed for running only one task per isolated CPU
> > >  without
> > >  any disturbance. And migration is a significant disturbance. This is why
> > >  nohz_full tries not to be too smart and assumes that task placement is
> > >  entirely
> > >  within the hands of the user.
> > > 
> > >  So I have to ask, what prevents you from using static task placement in
> > >  your
> > >  workload?
> > 
> > Actually, the llama-batched-bench results I shared already included
> > static affinity testing via numactl -C.
> 
> What I mean by that is even when tasks are strictly pinned to individual
> cores, the performance gap remains.
> 
> IIUC, the current implementation assumes tick-stop and idle-entry are
> coupled. While this holds for standard NOHZ, nohz_full decouples them,
> causing idle CPUs to be omitted from nohz.idle_cpus_mask.
> 
> This hides idle capacity from  the NOHZ idle balancer, forcing housekeeping
> tasks onto active cores. By decoupling these transitions in the code, we
> ensure accurate state accounting.

You mean housekeeping tasks are moved to isolated CPUs? With proper
isolation setting (ie: domain + nohz_full) this shouldn't happen.

Thanks.

-- 
Frederic Weisbecker
SUSE Labs

  reply	other threads:[~2026-02-13 13:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04  0:49 [RESEND PATCH] tick/nohz: Fix wrong NOHZ idle CPU state Shubhang Kaushik
2026-02-12 14:33 ` Frederic Weisbecker
2026-02-12 19:36   ` Shubhang Kaushik
2026-02-12 20:04     ` Shubhang Kaushik
2026-02-13 13:11       ` Frederic Weisbecker [this message]
2026-02-13 12:56     ` Frederic Weisbecker
2026-02-13 18:15       ` Christoph Lameter (Ampere)
2026-03-11 11:06         ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aY8jBnJgnpKdUpD4@localhost.localdomain \
    --to=frederic@kernel.org \
    --cc=adamli@os.amperecomputing.com \
    --cc=anna-maria@linutronix.de \
    --cc=bsegall@google.com \
    --cc=cl@gentwo.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=shubhang@os.amperecomputing.com \
    --cc=tglx@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox