From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D167836073C for ; Fri, 13 Feb 2026 15:26:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770996398; cv=none; b=ZbyIJ4s60pDf+jOHom+j2SGW/+J5CWAViAR9/egPcTSv0Y37g95X0DfzkwxnOzJoAR1bnMyDRPYQe428nqca1wgxhRCqONgkD5WZqF27rneoYUJ5Rcrx/hNL35TWvWbufm/Fk1cxHPLragPkr0IKz6hFz+oQN4yEOemYkBo2HDk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770996398; c=relaxed/simple; bh=pi30Pkn9PzCg21hY3eOknzX2n23fwwsolli8HC/B4fs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=HixzbZzpi3Skz1RAp3tu5OF5Xh4nQS439/6Rh6fqhmmiKRub6FrtK1UEDlDKrxVIltibz5qH3DBvh5Aqt5OxSrcGOQhKoWPfAmliWXo7Y/5Md/sM5T93ej/K6GBEpSSRizDKG07bIKXUrpfgb1UwlRJTsM6AxUqLWizGfmI7LNU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=yT6C+EOv; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="yT6C+EOv" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-354c7febaefso3110425a91.3 for ; Fri, 13 Feb 2026 07:26:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1770996396; x=1771601196; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=4NZ9EGPtUS+7RRQiNTrvozs7Ig+vPBqmlPOteC+yYic=; b=yT6C+EOvEMKLYtMSVsK0xda8I99aVSiS6HlrJlYxo02SMBeU273Hm80fn6lZDGk13p aYQ65emOT8i8EvHzoNI1XY/MD+0yKeD5dBdnuiNTfu0Z3JT6dSV7Ae5m6vk6QCsCE1G7 y+6xUn9CD7AJxGK7KEFgIiecU8ry2WwCCT+HrWxUJtp4JA2ThKVZRCR6X7yszcrsVBHe jihlvzIkIAQPOZaswKj1THEgF3KK4CWoxEo+romZwP8r7i+WcGTgixl9rIxu9sdBsk/y Yr3uyizCxyEu7r+5yZPcV18lIECCtbMhgrKAugD7QL4NXyEIOJk7nwNgKQkCdRhvOYzB eo7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770996396; x=1771601196; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4NZ9EGPtUS+7RRQiNTrvozs7Ig+vPBqmlPOteC+yYic=; b=AQpilZFpOMe3BCQ2T6IjYQyRcnnWrdkcxordz42PiOOkaiX9fsrtwDARDM45TSiFCV 3anxsEI3iHRdtrbKV+yZyYFppL1O5OZJD9uZjwciu0Ac9FGjsPNtMGR70Uxytnsqmqlw GnJZC+rmo0kbWvIh6Wdn6pB8LdvXvk2POclNJM70gyip46f4ZZ9k2B+ZrNlWcMS7jmYL 5GPOAWtrACogB7NF5xHKuuWDsABmrnG0Em0sVHiUh0Dg83eKkTN3dGI827uxP1cA4NHr jrUy3jCCI+HCqd9zilLH2ToaiOnlV3KpSHphvhpYBycu00TJu/bRVPrscg7U+veW5sc/ N3sw== X-Forwarded-Encrypted: i=1; AJvYcCX3kSsjdgd0VFyFPL5PB5czIrdQrl0FTEU4Bw4J9MgIZNNiynq03jHTxNrwQkme/JMGVNmV+pGUXV0r19k=@vger.kernel.org X-Gm-Message-State: AOJu0YwBEBla437bKVyouMYecuLpyTrIYFMQm+raUtDfciW7dAWcP8ff jT8v/6Na7YfZfa9Q+hOZ4RhPTst9iGUTwcNsTipcJjHzijfoy6P7+AWyB26zc2aUfnjErw5nBFt OlGUxsw== X-Received: from pjbqb7.prod.google.com ([2002:a17:90b:2807:b0:356:1edc:b2a]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2dc7:b0:354:9b26:cdf8 with SMTP id 98e67ed59e1d1-356aab9a321mr1928853a91.10.1770996395984; Fri, 13 Feb 2026 07:26:35 -0800 (PST) Date: Fri, 13 Feb 2026 07:26:34 -0800 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260212155905.3448571-1-jmattson@google.com> <20260212155905.3448571-2-jmattson@google.com> Message-ID: Subject: Re: [PATCH v4 1/8] KVM: x86: nSVM: Clear VMCB_NPT clean bit when updating hPAT from guest mode From: Sean Christopherson To: Yosry Ahmed Cc: Jim Mattson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Shuah Khan , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Fri, Feb 13, 2026, Yosry Ahmed wrote: > On Thu, Feb 12, 2026 at 07:58:49AM -0800, Jim Mattson wrote: > > diff --git a/arch/x86/kvm/svm/svm.h b/arch/x86/kvm/svm/svm.h > > index 0bb93879abfe..9850ed01e16e 100644 > > --- a/arch/x86/kvm/svm/svm.h > > +++ b/arch/x86/kvm/svm/svm.h > > @@ -434,14 +434,15 @@ static inline void vmcb_mark_dirty(struct vmcb *vmcb, int bit) > > vmcb->control.clean &= ~(1 << bit); > > } > > > > -static inline bool vmcb_is_dirty(struct vmcb *vmcb, int bit) > > Huh, I assume the removed of vmcb_is_dirty() was not intentional? Regardless of whether or not it was intentional, IMO it's a good change. KVM should never check vmcb12 directly, and I can't think of a legitimate case where KVM should condition its behavior on vmcb0{1,2} being clean/dirty. Unless a v5 is needed, I'll split it to a separate patch when applying.