From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 960A7330D54 for ; Fri, 13 Feb 2026 16:14:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770999286; cv=none; b=eRhGFUTYNjiB/3N+tEEkuOHU/zzBTwyoV3WNJ5nZO9zZovcZADozsLl60f4aXze2/h9ZrZ5BDwRMg/M5f6aN0jm9Q2peFK8FcPXWTvbX2hx9+YGeYjD3z7HvAmvsKhoW3+u5ynffg07tMXhQwgludOx2RgET/GwdRy9BBh+zYZQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770999286; c=relaxed/simple; bh=gJZ0H5g6MogpXiUv5VCMxrBmJWtE1/ypyfUmSRv+31M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c+JWZahgR7AcUG/f/zJfH/LNHL/FmzqJhL0h2K8fUWd5eDzi4Xs3yXILH0tODfzDVGuHsky30jwf3d8bOI8vsgQmStTYXm+kd/hfx5JTigXiKo4dTxPulg7RHtF67SZYOeHjgsphh9P4bUQw5QOOueljfAbL1pWXu/eynOYwNaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AU499Toi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AU499Toi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09AFDC19421; Fri, 13 Feb 2026 16:14:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770999286; bh=gJZ0H5g6MogpXiUv5VCMxrBmJWtE1/ypyfUmSRv+31M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AU499ToigZuK20hiWZbH7LCORa87aJXQCPe1/z1cQ4iwPfNPc9xs39+iHxiqIPpou F32yb/TlE7gOpcotXGSzt6JIw/t4GtDmewPkiWPFdakP+sRnYX5tEw9xSmMbdVTK0N WDpH0J7hsj5T7ejCY+tGMHwfM5AdVzVOWdgoGepEc9GYF6gEs0YMNPnlk2j6pD1QN/ /akVh7b/Y3TgiaaRo5ihIxL5vKsv1ds3u5FLUHnvQnCm+nUBEbrqOmU3hYBdvN/7Sb r0LX1h1GNiSxU7olD7WhETRSpMdn19Nkign3YBE3Tzo7wIQIS2nlqAYOGlo1p43D8C z0bVOkwxuTLog== Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfauth.phl.internal (Postfix) with ESMTP id 01C01F40068; Fri, 13 Feb 2026 11:14:44 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Fri, 13 Feb 2026 11:14:45 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvtdekjedtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepmfhirhihlhcu ufhhuhhtshgvmhgruhcuoehkrghssehkvghrnhgvlhdrohhrgheqnecuggftrfgrthhtvg hrnhepueeijeeiffekheeffffftdekleefleehhfefhfduheejhedvffeluedvudefgfek necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepkhhirh hilhhlodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdduieduudeivdeiheeh qddvkeeggeegjedvkedqkhgrsheppehkvghrnhgvlhdrohhrghesshhhuhhtvghmohhvrd hnrghmvgdpnhgspghrtghpthhtohepvdegpdhmohguvgepshhmthhpohhuthdprhgtphht thhopegurghvvgdrhhgrnhhsvghnsehinhhtvghlrdgtohhmpdhrtghpthhtoheprghrug gssehkvghrnhgvlhdrohhrghdprhgtphhtthhopehtghhlgieskhgvrhhnvghlrdhorhhg pdhrtghpthhtohepmhhinhhgohesrhgvughhrghtrdgtohhmpdhrtghpthhtohepsghpse grlhhivghnkedruggvpdhrtghpthhtohepuggrvhgvrdhhrghnshgvnheslhhinhhugidr ihhnthgvlhdrtghomhdprhgtphhtthhopehthhhomhgrshdrlhgvnhgurggtkhihsegrmh gurdgtohhmpdhrtghpthhtohepgiekieeskhgvrhhnvghlrdhorhhgpdhrtghpthhtohep lhhinhhugidqvghfihesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i10464835:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 13 Feb 2026 11:14:43 -0500 (EST) Date: Fri, 13 Feb 2026 16:14:38 +0000 From: Kiryl Shutsemau To: Dave Hansen Cc: Ard Biesheuvel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Tom Lendacky , x86@kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Moritz Sanft Subject: Re: [PATCH 1/2] efi: Fix reservation of unaccepted memory table Message-ID: References: <20260213154838.46567-1-kas@kernel.org> <20260213154838.46567-2-kas@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Feb 13, 2026 at 08:01:55AM -0800, Dave Hansen wrote: > On 2/13/26 07:48, Kiryl Shutsemau (Meta) wrote: > > static __init void reserve_unaccepted(struct efi_unaccepted_memory *unaccepted) > > { > > - phys_addr_t start, size; > > + phys_addr_t start, end; > > > > start = PAGE_ALIGN_DOWN(efi.unaccepted); > > Why are we even aligning the start? Isn't *that* the bug? How so? It is up to EFI how the table is allocated. We need to be sure that this memory is mapped and not overwritten. > The memblock code seems to be able to handle arbitrary alignment just fine. Memblock will track it, but, as the comment says, anything smaller than page size will not be mapped, but we need the table to be accessible by kernel. -- Kiryl Shutsemau / Kirill A. Shutemov