From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 651F9239E9D for ; Mon, 2 Feb 2026 04:57:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770008224; cv=none; b=fTdip4IjZi1IlRWnV9GXgkFCXJ7DZY1Gt9X27qMHW5j2BhvOPsV7bw+RqO7XhgBp2AySoVeKNy2OeK7YD/Fo3yuHynkLAEVBeJeTTSQb2xatltPWv246h3MU34kmkykYqBXu6JGto7lg7XsEP+VdqM05G7b1S5B7eogF+o9A+fI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770008224; c=relaxed/simple; bh=BOP0HYX51tXnhGhaVCjDBS8AsbFAbinui7UFcEZgdKI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RSfrUgLVkQvwjIAFi5R8A3OHTLYi2n5tKFVVcY/MPBmvsCVE6SvXm35kG3uXJg2hwQOBrO2yqPkonxnbWo6qmzZzAV35TWe12fEOSPldKDoNeA376AVdAuHXLX3DWKIDXr2Yjw75n3e4Ygc0nqDF0DHtwx5QS7ciVpmYiPC0hAM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=eJHP30Vc; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eJHP30Vc" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-6582e8831aeso6169096a12.1 for ; Sun, 01 Feb 2026 20:57:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1770008222; x=1770613022; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wPRgTQwJ4jsKG4M4C4YQuYvDcSDNXuHtRvocKp3Ffdk=; b=eJHP30VcMGHDSXjoAyJfagBMphp+wBSoPw/0oEl2jLt5leU6bp+sKEDV8uGwDCqH3Q TYUk1QTC9iEGlZpnnB+hElMxGggQMxDHMxsv6mHVHTFZKgi8TkJ/JoiHU1XvFJBzeMXi js5mmwBxlTU5KXG6CuT4IZVp+WBZzABdm8HAYIql+GCiqOIFAZ7qjQZV2Pg9irdqYBrA tosP0JOpkI6OhmYEwYpqZNJVtzFb1+at6amsqlKYpyupsZO9kkeqxaz6Duspe2JXZgs4 XuR0zRm+61jLwwaAn1rFi/sRSXQvWNykJXn8SB1cMfL2jY56OkwqU4leHiJqopMNYIGq Cung== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770008222; x=1770613022; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wPRgTQwJ4jsKG4M4C4YQuYvDcSDNXuHtRvocKp3Ffdk=; b=nV77wOrtAVd4TUyF3HMqS7YQHHKUN/ECp4OKSgsOU6JX20r3/BbRTlmvsgxLlWXYTj 6uaLjr/Jm5sosrMAG7y7VNtOrPA1bd3CuJWB7RkLDMwJX0GwLX/mWoWZX2SCiaZgPa2f w2lXJaORU7X3LKf2zOC9UojcE0Ry+pcVbNE0sKkfRCxKj8kk2tM314lzxGTAolTBOw3L LRlamdv9NaiNJCmOgpNMMcNqXhfyQ6gWTQXlJgwP3RapkHR0AJXNzxTNJllje7FEgtbJ fB5ReuEOALQPNs4LaxJ0ViQGjaZ7lV8JGfyD60F5Rv2uklO2bOBOFDAR+zHErM7TlNwy l6aQ== X-Forwarded-Encrypted: i=1; AJvYcCVn8vlEbvREKyBf+IhdWFEP4wr4M+r/Zr8OUTgNA/m9PRruJ8yL0KNyG2tFG6TwrKCCp5F1KdT36awXBt4=@vger.kernel.org X-Gm-Message-State: AOJu0YzCzD83hHgfAmHFGVORYa1j9TOAzSnDwKqX2XPHkFji9wm12srD Z5S2cMONGhNJACQ404iqRZrk19YtG/2x5IcZdcmoyS5Vr4JnbD1AAeblxM2Kg5UA3w== X-Gm-Gg: AZuq6aJ3+2QFKM8XxG0Ds28fjfWvfySk7XgSKPVwQMd3d6BcU16hW+lOIFUB4wXdKAm BIyp3gS3XT8zXL7f6ey5vx1CYWk1Ulo1CFLHGd1J5yNE45qSYyi/iOkt/vuufRA4DS/VXL/Wgpg +aTITxIJbsosYetRg8Dm22YvuwhS1IeUHd5lR5FzDCQx2cKuo3bYcjkS23O5OCUUhv8pymjD1b0 0siyr47XHEptQ2r12XOGaL4LLbYQJ62jZJEXhpc4v769qwR2+Uso0ssAvli4yFAf48Wxv/FPjnW oQtEbm1jSvcjUuiw91uCzWotw4cOd5y32/Dp/8uMeFym+OXg0+668n45cb9T+zrF4HVbopOuUq2 sPQkcuza1BNfPHQJZ8KFyudB1yfozz92x7+i6wH5s7LOd5gjVoxB4IlKgDzlzXMj/uL2gfWbGm0 12LEY0i7RHlU7yKJ7DB9C8NDjz/gTID2HXvGcz31pHptVUvLQEODA= X-Received: by 2002:a17:907:1b20:b0:b86:f558:ecad with SMTP id a640c23a62f3a-b8dff5260f2mr573103666b.7.1770008221605; Sun, 01 Feb 2026 20:57:01 -0800 (PST) Received: from google.com (93.50.90.34.bc.googleusercontent.com. [34.90.50.93]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbf2e0868sm802341666b.58.2026.02.01.20.57.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Feb 2026 20:57:00 -0800 (PST) Date: Mon, 2 Feb 2026 04:56:57 +0000 From: Matt Bobrowski To: Roman Gushchin Cc: bpf@vger.kernel.org, Michal Hocko , Alexei Starovoitov , Shakeel Butt , JP Kobryn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Suren Baghdasaryan , Johannes Weiner , Andrew Morton , Kumar Kartikeya Dwivedi Subject: Re: [PATCH bpf-next v3 05/17] bpf: mark struct oom_control's memcg field as TRUSTED_OR_NULL Message-ID: References: <20260127024421.494929-1-roman.gushchin@linux.dev> <20260127024421.494929-6-roman.gushchin@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260127024421.494929-6-roman.gushchin@linux.dev> On Mon, Jan 26, 2026 at 06:44:08PM -0800, Roman Gushchin wrote: > Struct oom_control is used to describe the OOM context. > It's memcg field defines the scope of OOM: it's NULL for global > OOMs and a valid memcg pointer for memcg-scoped OOMs. > Teach bpf verifier to recognize it as trusted or NULL pointer. > It will provide the bpf OOM handler a trusted memcg pointer, > which for example is required for iterating the memcg's subtree. This is fine. Feel free to add: Acked-by: Matt Bobrowski > Signed-off-by: Roman Gushchin > Acked-by: Kumar Kartikeya Dwivedi > --- > kernel/bpf/verifier.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c > index c2f2650db9fd..cca36edb460d 100644 > --- a/kernel/bpf/verifier.c > +++ b/kernel/bpf/verifier.c > @@ -7242,6 +7242,10 @@ BTF_TYPE_SAFE_TRUSTED_OR_NULL(struct vm_area_struct) { > struct file *vm_file; > }; > > +BTF_TYPE_SAFE_TRUSTED_OR_NULL(struct oom_control) { > + struct mem_cgroup *memcg; > +}; > + > static bool type_is_rcu(struct bpf_verifier_env *env, > struct bpf_reg_state *reg, > const char *field_name, u32 btf_id) > @@ -7284,6 +7288,7 @@ static bool type_is_trusted_or_null(struct bpf_verifier_env *env, > BTF_TYPE_EMIT(BTF_TYPE_SAFE_TRUSTED_OR_NULL(struct socket)); > BTF_TYPE_EMIT(BTF_TYPE_SAFE_TRUSTED_OR_NULL(struct dentry)); > BTF_TYPE_EMIT(BTF_TYPE_SAFE_TRUSTED_OR_NULL(struct vm_area_struct)); > + BTF_TYPE_EMIT(BTF_TYPE_SAFE_TRUSTED_OR_NULL(struct oom_control)); > > return btf_nested_type_is_trusted(&env->log, reg, field_name, btf_id, > "__safe_trusted_or_null"); > -- > 2.52.0 >