From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDF762652B6 for ; Mon, 2 Feb 2026 09:55:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770026103; cv=none; b=AwE+cveptRjdB41IO/YZdMptW99pP/rgeiUBceU3oVCDmA02dSWBJiaKvZ4ApC4SZgxl8ymFh9Jnqm3b5/hqeA/+tuE71v5qmMLjvgdh0DONCJfwS2afCabu2bHuz27aBGDVzQ56RT4Yu5YYamlp8+lTgmsiGGXzra3WbMIs+Oc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770026103; c=relaxed/simple; bh=tM0ZIIT0SfXkZEt1oAbpUmPlaEgJ06FHaFhzTDkP/rs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZwkyggtsPjmB4cJnI+loWlAiLSk5xwkA9YsCQo0DZRdpE8YWqArQkesdBmMB0tqTiD0+hvI2QSulF5NTu6FhJav9mpq4OyQp7MaLoWHTaYPcZTBgZcrMC5fGkior2DmYAYDtf0p9V3OgmqMnpIO+A5oq2O7mABPTOo9VoWGFMXE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=2MgS3h/E; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="2MgS3h/E" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-47edd6111b4so44854075e9.1 for ; Mon, 02 Feb 2026 01:55:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1770026100; x=1770630900; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=x69aZ/PCgH5m4sapPYNqP9yFQBKilACu2vK1FG07GVk=; b=2MgS3h/E4Sew8FPWf/ZK2DOfvzx7hiytpqZvpvrqCZ+EQzYyfP3Rx00V7rKX7NnVC/ hm5ju33tfGK0uWyHpqX+Fo1kGD7Qazz+qcc6awwIv44sOGXtLy2pwwkW8eG8ZfDe/lwy miZ17VCS+kC9QoJGvb6VON1BDvKCwckXNRTvesrdtQ6iXUgUyTDiSITXFca0Vl0uqm5G BsxGtXypg+erIR1Udl//hpPwbRFbEzd2NTWZpqJ+g2AzFVlJxeNcRt8HiPoeFnxfHpwd qNqbg5YCF9vRa+hBYcqlU1B56QDrFfmL5HOwY+d0TlMmnUWbuEEUgvbMSy8Uzb3lMS4v G5sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770026100; x=1770630900; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x69aZ/PCgH5m4sapPYNqP9yFQBKilACu2vK1FG07GVk=; b=n/bDPUulKoqFIROQcWCaDUgbQg+bYcnZOybmDZTbC8FOCYuSrlilVvjk0IH7nH9Lmw lVYwxXzBF6keSJyXD/p3XRach8+OJq69E010OBZrgqCXRs45N0lsHzsZzm86gU+nxYID lqQ3OA014AG4rycT/sh5/kWjz7KzgpIwk1TwCppokZ9ennjibGOXpb0OFRydsCFRvfH2 dy2+k2V4b9LL6mlb6E090+PDx5GztWiLBRL9J0J8W5yxd4kU83/EaAWu1DqkR+rALSb2 O0n4WbuAhBl1O94DktZOJ8HEfGlfhW7x3ki2cVeojDshFt6pXBLR8SSIK7SFUNY0i53d wLxA== X-Forwarded-Encrypted: i=1; AJvYcCVYwBRGiZeOX0dICkYKZ+XsvG9mGLMzzKRXtTSSiRaFZosV0DUHM8YaQcJIMdX4hBX7jUhN4KA5gJaY7z0=@vger.kernel.org X-Gm-Message-State: AOJu0YzOQmR9tECLgGnay002f+wXW+q2nkFPXsGNM8PhB28pRGoYoCN4 NNudr+xskRbIXfkDmq2W3zBH+iM4c/DHiIWyRpoP2aWb366gqv3de4fCoBQ5nCmYOvM= X-Gm-Gg: AZuq6aLWJf/RjVz+0lkeCcGfaaRYBVd6wBzi7t6kro2UJ+ahD5hMFT2/2nAvUPcPoI4 I8DtLaHtXt5yUr8eHT5MEqM2Op1VrEHuPV5BreIbdFPdq2pZ1RaYc+GButhF9KDhDQ5o5ooVJHS EgMUw4Zv/ghBbmVzhVvcN9+43NwDCJ9w4RZolIIIGwcls7WEAS/F7Ua+iMwcIg7uRBQpwTK0Lwk Hlm3tKwSZWThooWTw+g7jTL5tMiygouKPu6J1OkKo+aEHPDxmP7ensDLKJWTmCqcuXOYoRsLNSJ F+VRAsF7IkonMnPVV9kJewTPb5uEvlm277KjhPI3vnqbOQwyvk4emgmRJSNzTg5xIyfxzvl9QK3 vAj2eWYIW0CT4/K85PyK/D3TOvEKXNwZKameONYEk2yySUcQGyIG2xfbATStwYeVQNhlxD1SFx9 ODh541Ewhof8Rg37FTVq8QDxnxjN42cAfa2F14l8fYaxKHVDp6uNWaYTWTQnq9AnCu+qevterIR FjZPHcUexY2xgFMKX/Q3dYBRF1rOGD/OXCTFiCjT8ieGjVRsZmLOt3f2Gsv6aw8CeQvy8+U X-Received: by 2002:a05:600c:3b23:b0:477:af07:dd1c with SMTP id 5b1f17b1804b1-482db49fbdfmr150380875e9.35.1770026100077; Mon, 02 Feb 2026 01:55:00 -0800 (PST) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066c4f3edsm433200195e9.15.2026.02.02.01.54.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 01:54:59 -0800 (PST) Date: Mon, 2 Feb 2026 09:54:57 +0000 From: Daniel Thompson To: Chen Ni Cc: lee@kernel.org, danielt@kernel.org, jingoohan1@gmail.com, deller@gmx.de, linusw@kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] backlight: sky81452-backlight: Check return value of devm_gpiod_get_optional() in sky81452_bl_parse_dt() Message-ID: References: <20260202075410.155375-1-nichen@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260202075410.155375-1-nichen@iscas.ac.cn> On Mon, Feb 02, 2026 at 03:54:10PM +0800, Chen Ni wrote: > The devm_gpiod_get_optional() function may return an ERR_PTR in case of > genuine GPIO acquisition errors, not just NULL which indicates the > legitimate absence of an optional GPIO. > > Add an IS_ERR() check after the call in sky81452_bl_parse_dt(). On > error, return the error code to ensure proper failure handling rather > than proceeding with invalid pointers. > > Fixes: e1915eec54a6 ("backlight: sky81452: Convert to GPIO descriptors") > Signed-off-by: Chen Ni > --- > drivers/video/backlight/sky81452-backlight.c | 4 ++++ > 1 file changed, 4 insertions(+) Thanks for the fix. Small review comment below: > diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c > index 2749231f0385..e3e5306fab84 100644 > --- a/drivers/video/backlight/sky81452-backlight.c > +++ b/drivers/video/backlight/sky81452-backlight.c > @@ -202,6 +202,10 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt( > pdata->dpwm_mode = of_property_read_bool(np, "skyworks,dpwm-mode"); > pdata->phase_shift = of_property_read_bool(np, "skyworks,phase-shift"); > pdata->gpiod_enable = devm_gpiod_get_optional(dev, NULL, GPIOD_OUT_HIGH); > + if (IS_ERR(pdata->gpiod_enable)) { > + dev_err(dev, "failed to get gpio\n"); > + return ERR_CAST(pdata->gpiod_enable); > + } Using dev_err_cast_probe() would make this change more compact and give a better error message for the user. > > ret = of_property_count_u32_elems(np, "led-sources"); > if (ret < 0) { Daniel.