public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	 "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	 Paolo Abeni <pabeni@redhat.com>,
	pmladek@suse.com, john.ogness@linutronix.de,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	 Sergey Senozhatsky <senozhatsky@chromium.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	 netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	asantostc@gmail.com, efault@gmx.de,  gustavold@gmail.com,
	calvin@wbinvd.org, jv@jvosburgh.net, mpdesouza@suse.com,
	 kernel-team@meta.com
Subject: Re: [PATCH net-next v5 1/4] printk: Add execution context (task name/CPU) to printk_info
Date: Mon, 2 Feb 2026 03:49:32 -0800	[thread overview]
Message-ID: <aYCFnYCga1dgWniG@gmail.com> (raw)
In-Reply-To: <20260130173243.4e3fff89@kernel.org>

Hello Jakub,

On Fri, Jan 30, 2026 at 05:32:43PM -0800, Jakub Kicinski wrote:
> On Wed, 28 Jan 2026 06:17:37 -0800 Breno Leitao wrote:
> > +config CONSOLE_HAS_EXECUTION_CTX
> > +	bool
> > +	help
> > +	  Selected by console drivers that support execution context
> > +	  (task name/CPU) in their output. This enables PRINTK_EXECUTION_CTX
> > +	  to provide the necessary infrastructure.
> > +
> > +config PRINTK_EXECUTION_CTX
> > +	bool "Include execution context (task/CPU) in printk messages"
> > +	depends on PRINTK && CONSOLE_HAS_EXECUTION_CTX
> > +	default CONSOLE_HAS_EXECUTION_CTX
>
> AFAIU the double-symbol thing serves no practical purpose?
>
> If none of the console drivers uses the metadata what would be the
> point of capturing it?
>
> Conversely if some console driver wants this data there's no option
> for the user to disable it.
>
> AFAICT this patch should only add one invisible symbol for capturing
> the context and have netcons enable it.

The two-symbol design establishes a clear separation between what console
drivers require and how the printk core implements it.

This approach was discussed here:
https://lore.kernel.org/all/87eco09hgb.fsf@jogness.linutronix.de/

> I don't see a reason at this
> stage to prompt users with netcons disabled whether they want
> PRINTK_EXECUTION_CTX

Users won't see a prompt when netconsole is disabled. Since
CONSOLE_HAS_EXECUTION_CTX is only selected when NETCONSOLE_DYNAMIC is
enabled, PRINTK_EXECUTION_CTX will be automatically deselected without
prompting. Additionally, CONSOLE_HAS_EXECUTION_CTX is a hidden symbol that
cannot be manually forced.

That said, I'm open to making PRINTK_EXECUTION_CTX invisible as well,
given it is behaving like one already.

  reply	other threads:[~2026-02-02 11:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28 14:17 [PATCH net-next v5 0/4] net: netconsole: convert to NBCON console infrastructure Breno Leitao
2026-01-28 14:17 ` [PATCH net-next v5 1/4] printk: Add execution context (task name/CPU) to printk_info Breno Leitao
2026-01-28 14:42   ` John Ogness
2026-01-30  9:01     ` Breno Leitao
2026-01-30  9:19       ` Petr Mladek
2026-01-30  9:20       ` John Ogness
2026-01-31  1:32   ` Jakub Kicinski
2026-02-02 11:49     ` Breno Leitao [this message]
2026-02-03  0:23       ` Jakub Kicinski
2026-01-28 14:17 ` [PATCH net-next v5 2/4] netconsole: extract message fragmentation into send_msg_udp() Breno Leitao
2026-01-28 14:44   ` John Ogness
2026-01-28 14:17 ` [PATCH net-next v5 3/4] netconsole: convert to NBCON console infrastructure Breno Leitao
2026-01-28 14:49   ` John Ogness
2026-01-29 15:19   ` Petr Mladek
2026-01-28 14:17 ` [PATCH net-next v5 4/4] netconsole: Use printk context for CPU and task information Breno Leitao
2026-01-28 15:03   ` John Ogness
2026-01-28 16:46     ` Breno Leitao
2026-01-29 15:25   ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYCFnYCga1dgWniG@gmail.com \
    --to=leitao@debian.org \
    --cc=akpm@linux-foundation.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=asantostc@gmail.com \
    --cc=calvin@wbinvd.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=efault@gmx.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=gustavold@gmail.com \
    --cc=john.ogness@linutronix.de \
    --cc=jv@jvosburgh.net \
    --cc=kernel-team@meta.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpdesouza@suse.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox