From: Dan Carpenter <dan.carpenter@linaro.org>
To: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: make _action_public_str const
Date: Mon, 2 Feb 2026 16:51:59 +0300 [thread overview]
Message-ID: <aYCr_1sbBtbupRI9@stanley.mountain> (raw)
In-Reply-To: <20260202131649.161215-2-giorgitchankvetadze1997@gmail.com>
On Mon, Feb 02, 2026 at 05:16:50PM +0400, Giorgi Tchankvetadze wrote:
> The _action_public_str array is never modified at runtime and
> serves as a lookup table. Mark it 'static const char * const'
> to allow the compiler to put it in the read-only data section.
>
> This fixes a checkpatch warning:
> WARNING: static const char * array should probably be static const char * const
>
> Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
> ---
> v2: add blank line before Signed-off-by (suggested by Dan Carpenter)
Thanks.
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards,
dan carpenter
next prev parent reply other threads:[~2026-02-02 13:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 13:16 [PATCH v2] staging: rtl8723bs: make _action_public_str const Giorgi Tchankvetadze
2026-02-02 13:51 ` Dan Carpenter [this message]
2026-02-07 13:21 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYCr_1sbBtbupRI9@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=giorgitchankvetadze1997@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox