From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7908D3033CF for ; Mon, 2 Feb 2026 19:43:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770061406; cv=none; b=KhGkUFcgL4REBt66qzEOZN8em/f6HEYektddYr+HOL+ajIKQ7/XPJSoqbcBE3wicTLeaHClnwQtOYDrvvLFczKm44DHp6LqdRtsMtiDv9WDfzPtu+mhZAMgjoQUKV8W+rQOVXxp3oXzpBWP7zMh/cMIMdBst+xVESCDCAl5QKxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770061406; c=relaxed/simple; bh=9XJmP5Zv0m0XvpH5yX6YdmF55NDMAU1dVmNSfErk8Ww=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U5xFUAX3I4cMuJuFfJ5+Suvdnc/QXsIc/yP5Tc9x4C+OCKAA3ETQUf+10FLZuAb5TsTKD3mzZaabgqmIyoTjv4DBfhujzasT1mR1GplAFJP7NXJoPHweRSLtqbe2VHWWynfqcO272etTqP63Y88VFKBlyDQrgQV5Tx2VVMBS0Bg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Iu/YqL7W; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Iu/YqL7W" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4806f3fc50bso49658895e9.0 for ; Mon, 02 Feb 2026 11:43:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770061404; x=1770666204; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZIj5bc9c6vnIYo8f60ma9Tq489xKeyteUNnrezyXRkA=; b=Iu/YqL7WsQrnIkDkXgGyjCXRI9ix1cGCj33IZuavRp98q9bjhXC5ziMkuG6cQHoeex PjLg7TULGIMNDf524Admie1D5Uqd8l+toUrB8yPY6VkAX92DpSWPAWOjfLkZ79wNCN1a c6ON1TnDLq+VbDCCSs+udcRqSXJzECzjYTuepZSGlf6ugvHzx1WLXndEJ+aEGhVYpdRL 3ui2h3BeaZkOly/4F/Dahz/fQurS9B94PTuFR/JCwNAqbbhi56T5ESJY/F7HTFOUSoSD 5Wzvwq8NgJubILcoJegRN8BXfYV9perRi8QHC4aX7oA/cOwmbG38++lKTQxogr9YtaAh ndMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770061404; x=1770666204; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZIj5bc9c6vnIYo8f60ma9Tq489xKeyteUNnrezyXRkA=; b=PfCkfZcYB7ThlbZtJDF7RjBXB7HsMkA0jamhCAOHB2iD/5+Xuo8bdaTb2AS+Rx34fN 7fTWQ9eduWz/VJIq3Vzk3EpZdq/qBIO1O5PjJZiJm3EV6DXoqZBjzkc7h+6wPzTod6Ec pi1LfJ2XzVDSYN/KNtKJdCb1xCXaz+2x4J4HUkGdLw223LXv3zzz4ZTCX/9XnwQ+r9Ro 7Wc3p3m+A21u2tO4aa+Z95Q14ZwBMhDBq1l75fPGHOKEV2gOBmOnnx1Rj05nB6/Og6SE R+KsSs7ZsaYLmwiQlY9L5oLXYmbE8xTQqJY4SK6hy6nGVd3NPry16GZL++7nr9Rxll2s SpMQ== X-Forwarded-Encrypted: i=1; AJvYcCVxUvypW8C2rS5BFXK/TVDF5WxiWA2yByxVKgvvgWzEvc44P4z1G39wGDcrw2PNyy03ZewdLLqiqJM5BFY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy68yflnuaGBnmO//I6gziz4bigN/xoMD2C4d6z2vO/GbC2sd62 ZeqtFnGUPqOQXtw1iUXfFfMmmWdK/XeqGfHah5TqTY2v4GVmafcCtA/DcCeVrtoIFUw= X-Gm-Gg: AZuq6aKOwTGQFXI9kRsLGqLu8k8mZuk9T0EC84CqcvBBD+ed96pxdcBty7qSMGdQ665 fx4wu8NlsDK5ck2vYNCsB7SUPGvNIPAJxVUZGXgYVv8+NXLpJ437upsfY0H5Q6QtJKDH7Wh/tnZ TNsYaLLTyvvBYqdckW628BzBBPH/kkDBjG4nI6ATjkmRvByAjQ+42O7vAwXtGMdJ56b88A8lmYs h4GsSOEMwcRgA0IpcpNahxXy2YcSqxbsNuEhHuqqcoI7zLqnkPqDCpYOE9cQk9ZXMaO57Ga5PCx rRR0YvOzlAxqRrIk0UQE1VtU0TT5JC8s398A2Fm+Zcd6ftzXgiSobBYKYo81Q/Bk7LK9fJCfjya ZgiTprAvaBWhlxccjs6ugVf2fgu1e4lax7YXszcNUIBCv1coKk7+QqA555ezYG/dX/aVCNKG9uR ljg1I6TOIxTVzXR2fv X-Received: by 2002:a05:600c:354c:b0:45d:5c71:769a with SMTP id 5b1f17b1804b1-482db49d193mr164987515e9.26.1770061403703; Mon, 02 Feb 2026 11:43:23 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482e2e3bf18sm103677055e9.19.2026.02.02.11.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 11:43:23 -0800 (PST) Date: Mon, 2 Feb 2026 22:43:20 +0300 From: Dan Carpenter To: Gustavo Piaz da Silva Cc: gregkh@linuxfoundation.org, ovidiu.panait.oss@gmail.com, gshahrouzi@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 2/2] staging: axis-fifo: refactor device tree parsing Message-ID: References: <20260202142047.30704-1-gustavopiazdasilva2102@gmail.com> <20260202142047.30704-3-gustavopiazdasilva2102@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260202142047.30704-3-gustavopiazdasilva2102@gmail.com> On Mon, Feb 02, 2026 at 11:20:47AM -0300, Gustavo Piaz da Silva wrote: > static int axis_fifo_parse_dt(struct axis_fifo *fifo) > { > - int ret; > - unsigned int value; > struct device_node *node = fifo->dt_device->of_node; > + int ret; > + u32 width; > > - ret = of_property_read_u32(node, "xlnx,axi-str-rxd-tdata-width", > - &value); In the original commit then there were a bunch of changes and it kind of was fine to rename "value" to "width" because you were also changing the commit message and it was nice that the error message matched the code. But in this patch you're just deleting error messages and changing the goto end to a direct return. At that point, I would prefer to see a really minimal diff. No function renames. No changes to the line breaks. > - if (ret) { > - dev_err(fifo->dt_device, "missing xlnx,axi-str-rxd-tdata-width property\n"); > - goto end; > - } else if (value != 32) { > - dev_err(fifo->dt_device, "xlnx,axi-str-rxd-tdata-width only supports 32 bits\n"); > - ret = -EIO; > - goto end; > - } > + ret = of_property_read_u32(node, "xlnx,axi-str-rxd-tdata-width", &width); > > + if (ret) Delete the blank between the function call and the error checking. [ snip ] > - ret = of_property_read_u32(node, "xlnx,rx-fifo-depth", > - &fifo->rx_fifo_depth); > + ret = of_property_read_u32(node, "xlnx,rx-fifo-depth", &fifo->rx_fifo_depth); > + if (ret) > + return ret; This is an example of changing the white space. It's unrelated. Whey you were changing to use a helper then it was related, but once we delete the helper it's not. regards, dan carpenter