From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id E973F3793CF
	for <linux-kernel@vger.kernel.org>; Mon,  2 Feb 2026 16:10:14 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770048615; cv=none; b=gy6P6wRaWr2MfxFMBMi+ppP6ubSTanfkinnLKZhoG1XVuIclNkQ4YrZyNWZ7uKPOxaH93R3qqKMewdYCZwbjvorIvvflYACVyrrmJ1tJ7DmX7ygNMivkTs+jkKm9c6pfX6QXNA/4OfcHEAiBc56nxAmziHj7Q839qCr2yp/4E+M=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770048615; c=relaxed/simple;
	bh=9f2cQ+JTUDi5r2PU42FHIqeKjn3jU9sQjf7xROhquGk=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=aSyzSrcnSjDZ12gvcoHM7IiVr50v1NXVq5XhTTLtYT1XKagWiKFJkECkOGzoCNVB/VebBKEKaV0PirCgfTC/52VlhB5zgb9XgFMSiwGi/ZB0J5itddWHoiX7rVj1NY+gj2jdF2g2O57BQa/Tv/CWWqrR6he0yO7ZCqwsWCvRqQY=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Hco48qHS; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Hco48qHS"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72F27C116C6;
	Mon,  2 Feb 2026 16:10:14 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1770048614;
	bh=9f2cQ+JTUDi5r2PU42FHIqeKjn3jU9sQjf7xROhquGk=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=Hco48qHS6q4lTNZ/IqEJHVYZpIqTNur2Ji+5GenPtTQbctvY6vmD70tbOSGanN964
	 KQ49GSrWTdRco4tZxisSR55kHr7sTvVx9CdR2RzfNDDzdk9mZ8hKtihsawAB1o8pBF
	 uVNu+YgVdCeHntc5vccFJ9SqYhmD7b921usxEjI0M8n6Q4AB22M4q7p4PeoQ6/4Up7
	 5+SICC9haWM4Cq3oq6Rgmm2ecHHq6G+7j0APNhKlTsbcHGmnWxMyE4Bh3F4UOYEYLY
	 sbLVzOwzOWSAeYzxtUGE9UpVciNFFKXJ/XYr1ZWuX1VL3sREMY9pLPlAy9kxh8TTTc
	 yNVJI99lDOfVw==
Date: Mon, 2 Feb 2026 09:10:12 -0700
From: Keith Busch <kbusch@kernel.org>
To: Daniel Hodges <hodgesd@meta.com>
Cc: axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme-fabrics: use kfree_sensitive() for DHCHAP secrets
Message-ID: <aYDMZO7el37ZPQTE@kbusch-mbp>
References: <20260201030840.3173507-1-hodgesd@meta.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260201030840.3173507-1-hodgesd@meta.com>

On Sat, Jan 31, 2026 at 07:08:40PM -0800, Daniel Hodges wrote:
> The DHCHAP secrets (dhchap_secret and dhchap_ctrl_secret) contain
> authentication key material for NVMe-oF. Use kfree_sensitive() instead
> of kfree() in nvmf_free_options() to ensure secrets are zeroed before
> the memory is freed, preventing recovery from freed pages.

Thanks, applied to nvme-7.0.