From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE959314B62 for ; Tue, 3 Feb 2026 11:56:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770119795; cv=none; b=u3RznrHg8OCq7HKHDEJCNr9AfpvRt1AVq0bI8dbS5kZqpv4nVNhyfNDej3sCaWJGg0uu658av+DW7HUoIYGwjXiSQzQ0qKrJP4QpSOTa1ZAlO+D5gFEXvZPd6ScrMLMUssoa33ew0X0Erub5TImrp8rI/+ofQHZ2iALm6YC5Zu0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770119795; c=relaxed/simple; bh=fIValo5yKPbIhFlXOD01Dpkto4MaemDemMmEahN16qs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=FK1X0NCfT3LO6L9YvbWGCysvrueZFE3uYhcNgHupv6KpSkxSHVyGTI/QR45gN8nCqXt/2gOXpiFecYHKy6wd5OAPTDhsekW2vo5M6FGRm8Rpc/dMnAoXzgNXATgQxehjxb8rKf8eGeKzHL+O/gwq2EhjJpFRDFJSYnrG4Ru4XCc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=GWRYtlRi; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GWRYtlRi" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-4806fc58fa5so49884005e9.2 for ; Tue, 03 Feb 2026 03:56:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1770119792; x=1770724592; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=xKNeZZFcZOPnlVkKlVgbf6KllIvQR8EtUXBkDqrK0DU=; b=GWRYtlRiEVowduEGes/CBxe2ZudHGmb7zw3y5XApoABes3HJyAqz1GwNf6jdCMle+w ymW4QqqeddqtNn94kYfL0QDmrSAPu6PVXS4gbxxewTIKa5BTRUBqT+U21GWsg8lhb90L cY+ILc39K1Ued/hUw3duHgjhRA678sg0q9Wuk//NJuCNy15KCVrcYQz7PmfO5KXOxcjF 8vizGu0GInZM9BlSfhlJaFFyeqB7BslONojzP+WYzHQTLlBfoEnEy0apy7VgrpPMiYnW SoeCfCegwp99+YZ4LpIU2ryGXime4zmZZVO82MqWupQYXk8qmuTEYgAWxJr5Q/eJTSsT S7DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770119792; x=1770724592; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xKNeZZFcZOPnlVkKlVgbf6KllIvQR8EtUXBkDqrK0DU=; b=Gehi3aAFJugT3jgO5BFmeckiuzma/F0LAFe9t/vDI0ZcLMurdmziOIrFSB8PqxcKl5 WtIzYBeXbApk4KG+uGlA7CeXFX56CiiPl2whXEfdrDGZToQ5QcufhJ5nhBi/P/dKIIBm BSGM+8X56N+XUeYBzQnnVuexr/ZlN/9tzNHZsG+OUkSPujB5bu3MBbADbrPqhglQprK3 h1JF/hXmmhGzYcLzVwV+t112Hk/GQQj36VUSSke082sEWwzsZi4bLPP9XPl+yeyf6SbM B9KvfyNqfqEPf8w7Zz4/Pe7o/AD7HR1Cx78L8yauqvC1qk4p22X2qhcICc7YgTM5sX0h OcPg== X-Forwarded-Encrypted: i=1; AJvYcCVq32s/x3iRG9Sh7QQL2evCd6l2e38+T4yUazARn63k6ujy74bcKEk7+KAucz38YfUvDzaaBgnE7SGorG0=@vger.kernel.org X-Gm-Message-State: AOJu0YyPbEDxgKvzVQX3NZNzpWVezhsRZUfT7LDuK+e8XTEVNyRhc9aA tympdd7RqQOCBbO05BLTSIlrG5TD9R3qdpgI+gQfWKPF8tHuGVhMKtjlhDXGXR4bswvTC+lSYCr 78/TvUYhim6YwqtpyLw== X-Received: from wmsm42.prod.google.com ([2002:a05:600c:3b2a:b0:47e:d9ed:20f0]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:5288:b0:480:4d37:e742 with SMTP id 5b1f17b1804b1-482db451e66mr191651005e9.10.1770119792156; Tue, 03 Feb 2026 03:56:32 -0800 (PST) Date: Tue, 3 Feb 2026 11:56:31 +0000 In-Reply-To: <2026020323-oversold-goon-b522@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260128-binder-fix-target-node-null-v1-1-78d198ef55a5@google.com> <2026020323-oversold-goon-b522@gregkh> Message-ID: Subject: Re: [PATCH] rust_binder: return p from rust_binder_transaction_target_node() From: Alice Ryhl To: Greg Kroah-Hartman Cc: Carlos Llamas , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Tue, Feb 03, 2026 at 12:48:40PM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 28, 2026 at 09:12:07AM +0000, Alice Ryhl wrote: > > Somehow this got changed to NULL when I ported this to upstream it. No > > idea how that happened. > > > > Reported-by: Carlos Llamas > > Closes: https://lore.kernel.org/r/aXkEiC1sGOGfDuzI@google.com > > Fixes: c1ea31205edf ("rust_binder: add binder_transaction tracepoint") > > Signed-off-by: Alice Ryhl > > --- > > Commit not yet upstream, so cc stable not required. > > --- > > drivers/android/binder/rust_binder.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/android/binder/rust_binder.h b/drivers/android/binder/rust_binder.h > > index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644 > > --- a/drivers/android/binder/rust_binder.h > > +++ b/drivers/android/binder/rust_binder.h > > @@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t > > > > if (p) > > p = p + RUST_BINDER_LAYOUT.n.arc_offset; > > - return NULL; > > + return p; > > } > > > > static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t) > > > > --- > > base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd > > change-id: 20260128-binder-fix-target-node-null-02fcb98f0200 > > Does not apply at all, what tree was this made against? This applies on char-misc-next. It's a fix for commit c1ea31205edf, which currently only exists in that branch. Alice