From: Florian Westphal <fw@strlen.de>
To: Sun Jian <sun.jian.kdev@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Phil Sutter <phil@nwl.cc>, Simon Horman <horms@kernel.org>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] netfilter: amanda: fix RCU pointer typing for nf_nat_amanda_hook
Date: Tue, 3 Feb 2026 16:03:58 +0100 [thread overview]
Message-ID: <aYIOXk55_DRFKCqo@strlen.de> (raw)
In-Reply-To: <20260203145511.164485-1-sun.jian.kdev@gmail.com>
Sun Jian <sun.jian.kdev@gmail.com> wrote:
> enum amanda_strings {
> @@ -98,7 +98,12 @@ static int amanda_help(struct sk_buff *skb,
> u_int16_t len;
> __be16 port;
> int ret = NF_ACCEPT;
> - typeof(nf_nat_amanda_hook) nf_nat_amanda;
> + unsigned int (*nf_nat_amanda)(struct sk_buff *skb,
> + enum ip_conntrack_info ctinfo,
> + unsigned int protoff,
> + unsigned int matchoff,
> + unsigned int matchlen,
> + struct nf_conntrack_expect *exp);
Why is that needed?
next prev parent reply other threads:[~2026-02-03 15:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 8:01 [PATCH] netfilter: amanda: fix RCU pointer typing for nf_nat_amanda_hook Sun Jian
2026-02-03 13:50 ` Florian Westphal
2026-02-03 14:36 ` sun jian
2026-02-03 14:55 ` [PATCH v2] " Sun Jian
2026-02-03 15:03 ` Florian Westphal [this message]
2026-02-03 16:19 ` sun jian
2026-02-03 16:59 ` Florian Westphal
2026-02-04 1:56 ` sun jian
2026-02-04 2:31 ` sun jian
2026-02-04 12:24 ` Florian Westphal
2026-02-04 14:49 ` sun jian
2026-02-04 15:38 ` [PATCH v4 0/5] netfilter: annotate NAT helper hook pointers with __rcu Sun Jian
2026-02-04 15:38 ` [PATCH v4 1/5] netfilter: amanda: annotate nf_nat_amanda_hook " Sun Jian
2026-02-04 15:38 ` [PATCH v4 2/5] netfilter: ftp: annotate nf_nat_ftp_hook " Sun Jian
2026-02-05 10:00 ` Florian Westphal
2026-02-05 12:23 ` sun jian
2026-02-05 12:30 ` [PATCH v5] netfilter: annotate NAT helper hook pointers " Sun Jian
2026-02-04 15:38 ` [PATCH v4 3/5] netfilter: irc: annotate nf_nat_irc_hook " Sun Jian
2026-02-04 15:38 ` [PATCH v4 4/5] netfilter: snmp: annotate nf_nat_snmp_hook " Sun Jian
2026-02-04 15:38 ` [PATCH v4 5/5] netfilter: tftp: annotate nf_nat_tftp_hook " Sun Jian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYIOXk55_DRFKCqo@strlen.de \
--to=fw@strlen.de \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=sun.jian.kdev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox