From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: abdurrahman@nexthop.ai
Cc: Michal Simek <michal.simek@amd.com>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v9 4/7] i2c: xiic: cosmetic cleanup
Date: Tue, 3 Feb 2026 17:42:34 +0200 [thread overview]
Message-ID: <aYIXagCXYb4DrDLp@smile.fi.intel.com> (raw)
In-Reply-To: <20260202-i2c-xiic-v9-4-ce4695f5267d@nexthop.ai>
On Mon, Feb 02, 2026 at 08:37:21PM +0000, Abdurrahman Hussain via B4 Relay wrote:
> Re-use dev pointer instead of referencing &pdev->dev everywhere.
...
> - dev_dbg(&pdev->dev, "mmio %08lx irq %d scl clock frequency %d\n",
> + dev_dbg(dev, "mmio %08lx irq %d scl clock frequency %d\n",
> (unsigned long)res->start, irq, i2c->i2c_clk);
No need to do this here as we change the format string afterwards anyway.
But I leave it up to Andi, I won't prevent this to go in, if he agrees.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-03 15:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 20:37 [PATCH v9 0/7] i2c: xiic: use generic device property accessors Abdurrahman Hussain via B4 Relay
2026-02-02 20:37 ` [PATCH v9 1/7] i2c: xiic: switch to devres managed APIs Abdurrahman Hussain via B4 Relay
2026-02-02 20:37 ` [PATCH v9 2/7] i2c: xiic: remove duplicate error message Abdurrahman Hussain via B4 Relay
2026-02-02 20:37 ` [PATCH v9 3/7] i2c: xiic: switch to generic device property accessors Abdurrahman Hussain via B4 Relay
2026-02-02 20:37 ` [PATCH v9 4/7] i2c: xiic: cosmetic cleanup Abdurrahman Hussain via B4 Relay
2026-02-03 15:42 ` Andy Shevchenko [this message]
2026-02-03 18:59 ` Abdurrahman Hussain
2026-02-04 1:11 ` Andi Shyti
2026-02-02 20:37 ` [PATCH v9 5/7] i2c: xiic: cosmetic: use resource format specifier in debug log Abdurrahman Hussain via B4 Relay
2026-02-02 20:37 ` [PATCH v9 6/7] i2c: xiic: use numbered adapter registration Abdurrahman Hussain via B4 Relay
2026-02-03 15:45 ` Andy Shevchenko
2026-02-03 18:14 ` Abdurrahman Hussain
2026-02-03 18:31 ` Andrew Lunn
2026-02-03 18:50 ` Abdurrahman Hussain
2026-02-03 19:57 ` Abdurrahman Hussain
2026-02-03 19:58 ` Andrew Lunn
2026-02-02 20:37 ` [PATCH v9 7/7] i2c: xiic: skip input clock setup on non-OF systems Abdurrahman Hussain via B4 Relay
2026-02-03 15:46 ` Andy Shevchenko
2026-02-03 18:38 ` Abdurrahman Hussain
2026-02-03 23:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYIXagCXYb4DrDLp@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=abdurrahman@nexthop.ai \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox