From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE61F284895 for ; Tue, 3 Feb 2026 18:34:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770143663; cv=none; b=D48hwG81LNPLoyrlvLJWPi/X7qjwSuc6xUACrWMhAA+9ItScrxYZSaCYDRWEqjW4U6+GOWTlsSaXsl47S/rMKj2idxYIOe66g6wP7CNmpbh1A1QJoElwCgczdXmRSQqCE820e6KZY7tAPANgRX9CCo9+WjpFExJVwcEO0v0/wZ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770143663; c=relaxed/simple; bh=pBOp8/P1hQCnGJgskG3YY0KJlWnmwCTblLlq6mNTV2M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ih5RbnAxK4nP6JDEo3s9R27rdZzVv6KitbskqXwq3TalCnL0zGv4KMiXW37ez4WTH9zb3dNPppMv694ugJzPAfNCi6qlShrqktPyHDQ52f8CzAx4ncdfmcjffOtSJk6gK7jIICIFsDe/rjTVbNBcIdZUTpgWyDFJn3wxJXs80xQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fKRFbKHk; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fKRFbKHk" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-823f9f81da5so1187037b3a.1 for ; Tue, 03 Feb 2026 10:34:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770143661; x=1770748461; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=o6uJLcE00Iq19qZLatJ2/SPEG6MVkQU0n0oI7YP48ZU=; b=fKRFbKHkFdzdVesugMjN6MHatQ3vL0U7kztStrlgqNXUtO2yvB1VxYW3Tfkl88NUFt nbSWqT7nGRtzWp+fDca4ZS/MOUNsKKMbr8SFk6FpAfQc4CZWz65FLBkiueEYgHT27r7M IFsmSbCRAdammoobSnvbPPJ2T28hIwTk0auDITdnQ4UXMblL2+sehq7fTQ6R3vA0nKXc 4Je7Z5yt6Q7qUOWBoEWYmXharCSyVsqc5gqEyFr7u6RKu8+O/vGLAKgC1sYJOkXv0zL8 KkLKoAvsBCVzc7up58zUrcC9JtXJvNKRblBd11fyMfTv5AABF2M5UuAOY6DAiRJbrQi0 og3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770143661; x=1770748461; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o6uJLcE00Iq19qZLatJ2/SPEG6MVkQU0n0oI7YP48ZU=; b=fN/Z5cIDJ14wQ1jiSGgtJLVM+ipsvlaCtoq12VD2Z5A0JAv6uSpx4VPSeIxjY22j5h VozripXMWnSbyX3DdA+2izMaX6gqTUdyhne1gQsqtnLkI9mA4N8fbdMtxr+UEOsAZWns EO+fPZkolWBT+b7HWhFOd9dKEc+ul4gYYD+td7v1AkPjF2C7zoxV/FH2vXrQskF66egL nLn7NaQmsQ3OF1AYYA5+cNyfj9rjO2q4T05/tOI/Wa+56W7RoXlmeKGRXLVLB7BA+F88 edg0n6mXwPPNerXUSTLIlwG60xcz7Mq4lFZftyyJatMQA3XcOosR5Yea73v/c0zxffFT iccw== X-Gm-Message-State: AOJu0YyS4UxhAvkF+d9vL2h3fs+hjdcn072fwYjDnQFrdn6mgBUq7pxe wh/8RziubDIUZsgRYXzpOKiU13CcCe3sZvxCX1wc2BpRiqjaHYTajE1o X-Gm-Gg: AZuq6aKZxYjCs9Ol7cMIst/e2SDMArtAsLj+xGZwImXoz4Zh9//vhjDUT08Z1ECTrV2 WiWebsTtHzl8MpVsgTEM2uax6W0/sKyOqBJJufAdGQjFFGjA9jOnpoGUT5Vxz/PFWEg3kajoif9 PSHK8D/UBizLjP0Bcjjn6J2p+kaOWRkvKkYUgcrm+LkfbF0X9QuHcO619ys+PLmS+6PPnJLRw34 xGYuTIpyhKAoEi7tjC2qSi0LxvqBPdBg7RMcCFVpYP7ESKft+yNJqIU3+cxfyWx4ZyogKcjapTq /BG1Tcc3yjBXZbP4qaSe96LRLUr+d8kFUfjlf1n9z+/qqcV/wmDH4mSTOt4HJ8YfFkkY6fJevJb XmdBpjlW2Ay6x7WtihEocZef8pmH8HjYdvHMu9cUxmoQLahK4gqe+NKo9H8juJ15jz6KEmhFzOe 54OJO28qo3gWQlOvtZIiOjft6A X-Received: by 2002:a05:6a20:cf90:b0:38b:de3d:d542 with SMTP id adf61e73a8af0-393723c22c5mr326552637.51.1770143661043; Tue, 03 Feb 2026 10:34:21 -0800 (PST) Received: from google.com ([2402:7500:479:35ee:ffa0:8c05:8b18:1c7a]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-354860fa13csm413520a91.7.2026.02.03.10.34.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 10:34:20 -0800 (PST) Date: Wed, 4 Feb 2026 02:34:16 +0800 From: Kuan-Wei Chiu To: Titouan Ameline de Cadeville Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, davidgow@google.com, raemoar63@gmail.com, kees@kernel.org, eleanor.lin@realtek.com Subject: Re: [PATCH v5] lib: math: tests: drop unnecessary KUnit param_value casts Message-ID: References: <20260203173040.42158-1-titouan.ameline@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260203173040.42158-1-titouan.ameline@gmail.com> On Tue, Feb 03, 2026 at 06:30:40PM +0100, Titouan Ameline de Cadeville wrote: > Drop unnecessary casts from KUnit parameter access since param_value > is a void *. This improves readability and follows common kernel style. I'm not necessarily against this patch, but to be honest, I don't see how this "improves readability." Regards, Kuan-Wei > > No functional change. > > Reviewed-by: David Gow > Signed-off-by: Titouan Ameline de Cadeville > --- > > Changes in v5: > - Use consistent email address in From/Author/Signed-off-by (titouan.ameline@gmail.com). > - Add version changelog below the '---' line. > > lib/math/tests/gcd_kunit.c | 2 +- > lib/math/tests/int_log_kunit.c | 4 ++-- > lib/math/tests/int_pow_kunit.c | 2 +- > lib/math/tests/int_sqrt_kunit.c | 2 +- > lib/math/tests/rational_kunit.c | 2 +- > 5 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/lib/math/tests/gcd_kunit.c b/lib/math/tests/gcd_kunit.c > index ede1883583b1..b9c9b8758991 100644 > --- a/lib/math/tests/gcd_kunit.c > +++ b/lib/math/tests/gcd_kunit.c > @@ -34,7 +34,7 @@ KUNIT_ARRAY_PARAM(gcd, params, get_desc); > > static void gcd_test(struct kunit *test) > { > - const struct test_case_params *tc = (const struct test_case_params *)test->param_value; > + const struct test_case_params *tc = test->param_value; > > KUNIT_EXPECT_EQ(test, tc->expected_result, gcd(tc->val1, tc->val2)); > } > diff --git a/lib/math/tests/int_log_kunit.c b/lib/math/tests/int_log_kunit.c > index 14e854146cb4..9f9b48232701 100644 > --- a/lib/math/tests/int_log_kunit.c > +++ b/lib/math/tests/int_log_kunit.c > @@ -43,7 +43,7 @@ KUNIT_ARRAY_PARAM(intlog2, intlog2_params, get_desc); > > static void intlog2_test(struct kunit *test) > { > - const struct test_case_params *tc = (const struct test_case_params *)test->param_value; > + const struct test_case_params *tc = test->param_value; > > KUNIT_EXPECT_EQ(test, tc->expected_result, intlog2(tc->value)); > } > @@ -52,7 +52,7 @@ KUNIT_ARRAY_PARAM(intlog10, intlog10_params, get_desc); > > static void intlog10_test(struct kunit *test) > { > - const struct test_case_params *tc = (const struct test_case_params *)test->param_value; > + const struct test_case_params *tc = test->param_value; > > KUNIT_EXPECT_EQ(test, tc->expected_result, intlog10(tc->value)); > } > diff --git a/lib/math/tests/int_pow_kunit.c b/lib/math/tests/int_pow_kunit.c > index 34b33677d458..ef9c8a9bd8ac 100644 > --- a/lib/math/tests/int_pow_kunit.c > +++ b/lib/math/tests/int_pow_kunit.c > @@ -31,7 +31,7 @@ KUNIT_ARRAY_PARAM(int_pow, params, get_desc); > > static void int_pow_test(struct kunit *test) > { > - const struct test_case_params *tc = (const struct test_case_params *)test->param_value; > + const struct test_case_params *tc = test->param_value; > > KUNIT_EXPECT_EQ(test, tc->expected_result, int_pow(tc->base, tc->exponent)); > } > diff --git a/lib/math/tests/int_sqrt_kunit.c b/lib/math/tests/int_sqrt_kunit.c > index 1798e1312eb7..9c46024b0fc1 100644 > --- a/lib/math/tests/int_sqrt_kunit.c > +++ b/lib/math/tests/int_sqrt_kunit.c > @@ -45,7 +45,7 @@ KUNIT_ARRAY_PARAM(int_sqrt, params, get_desc); > > static void int_sqrt_test(struct kunit *test) > { > - const struct test_case_params *tc = (const struct test_case_params *)test->param_value; > + const struct test_case_params *tc = test->param_value; > > KUNIT_EXPECT_EQ(test, tc->expected_result, int_sqrt(tc->x)); > } > diff --git a/lib/math/tests/rational_kunit.c b/lib/math/tests/rational_kunit.c > index 47486a95f088..b05587a1e90a 100644 > --- a/lib/math/tests/rational_kunit.c > +++ b/lib/math/tests/rational_kunit.c > @@ -33,7 +33,7 @@ KUNIT_ARRAY_PARAM(rational, test_parameters, get_desc); > > static void rational_test(struct kunit *test) > { > - const struct rational_test_param *param = (const struct rational_test_param *)test->param_value; > + const struct rational_test_param *param = test->param_value; > unsigned long n = 0, d = 0; > > rational_best_approximation(param->num, param->den, param->max_num, param->max_den, &n, &d); > -- > 2.44.2 >