From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C3392ECE86 for ; Wed, 4 Feb 2026 09:55:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770198931; cv=none; b=WxmbeZtWDnIWPQ17gyLQLJoB64VHugMRPoDdO7PiDY+4n6W5g5C9pTlXnL5vR1/A5WPqS0IDTJwnJwGZqGBle9d7Hwn1XOq1+i2y9cmFhmQoHpkYQudn7DKJh17vmjzy/2x9OBjKGAc8TW6a0w2pYzwEMOs8Rj2KOKIKgNyN+eI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770198931; c=relaxed/simple; bh=fDc9+RnTuNqnqK2DLJw2MgkTQPt1U2igsoiMD6lUu2Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MFmb6SUZ8aMel4zwm5kwDjmg1U8Sctn6duwrG+0G41jWhuOyhQfhMgnpclaM+MjxhEAUCHnkttAfbzHptXvLm2rxDABPMKvi/7QTMSFzmQdkWrT9dwNa/NzlU0f3ZP+KkoRwDvWPCo4VXoGm8wQo9nnh8OO1p5+5/TqtcuAHC/c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=glgbkgof; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="glgbkgof" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4806cc07ce7so65993315e9.1 for ; Wed, 04 Feb 2026 01:55:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770198930; x=1770803730; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XzUjtBBrjfJBhBDao8Y/buom6ruqtjiudppkV5j4hu4=; b=glgbkgofbI7qInVxzI2G4p6D7xwoBdKDZ5TjFI4Y9e2wf7+Quwknk0amcexyLDaTRo JlczXuLGX3BBEdINyNNkum6VRz4TklTxWUStm0Ta7xPFGUXg1Y7x44lFZPS3+P/yuuuV 8RMZeGrPw6bRFmcwXRC5KgKAkEbJpUWbCDmqq5TEb1GtsAuYb//K725imvxU5axrulDx KVXdrgmSDFwugeqq0m68bf4VIHIzkQzqZsvw06XL3bVFWAZWODVtxUwpcFdlCYppokWs gOAcr6GhhB9YlGh4rRrBD9RsVbWRopj69R/BuZmDZbMLz7VwHaIAz9shl7ukgm+2C7Dm KJpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770198930; x=1770803730; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XzUjtBBrjfJBhBDao8Y/buom6ruqtjiudppkV5j4hu4=; b=JpSToAL0d62O7ji29YVmfAWSWaEWJ91OsM+MEn9T1I1NODkW95gWQnFFIXb+r3dBJl XZdMFpvxa0YTxm74hk/vWbawhb+4cHpEObdmDzN079IKZV/GhYvwgEOtS/H0IVIrImj6 n8dYJjPrPp5ps8Qjl05aY9garTAUNS/O1EYAccfB1BiSJ8UkJwXnILx/HkM5koweIE9R +H0a4QZRpff6qP7IKHKhauw1qfkui8vtv/7+0BbP3YCORv7GcBSlrT/Epzg2QDOgn4/t fa3prHxV4HYwwRHjRdXLO9Lb9gbWlmKj4zXjAlUp4s9UmDc9Enr2KVhzdw8RFnx0NjT/ Slow== X-Forwarded-Encrypted: i=1; AJvYcCUkU/a2DMcrf6yQ8qxdoKcPgam3rJC5371XWKV9Jtvn+iuVKlr8OqDPs7ymhoCCjeEBSYOGglXTrNdQkuA=@vger.kernel.org X-Gm-Message-State: AOJu0YzzZNKRHVMSBMG/CQswjpYjLlI9tuAGD0suB6wURVzTmtKN400I B9t4xYoF+UT+/rR9aZHMgrNUum7Vmt66TItpmP2+hWxzfNlHqI2WVo4cFwlS+ETqyXQ= X-Gm-Gg: AZuq6aKzWvMG5mnCSveAE+Na2z2wk6NOiqHgpH+FhzmMC8LjQGnXlm+dqhJn5GJ6438 47pq7LW8dpc572gmrenT4Ho8TMRkU5qaiXxjkdqHA/0f1EP97JFYi6gd1u/0kMefqjXukwRqoQu 7N0rWbSwgWw/tnrZTqcP9ajKS+T/pN30+6Nm+joNa3ID6usKx3xMtZTrXcV5zWtn7yFWctVVqEQ pbAkmePFdy/2L3K2M5cg5c/ZmoCXk4j8ShhOpJnhfBaRarzJ0UDN5qmdE9vflmglDAs8yI4YpVF M/RoYc7TG3tYdMC9cBOjXXZ6N5E9Cg93n1KmOSNLynKRJ8eeBFMvBSKlLiys4P0EvTPHBOnlEzD yjPd7HAIUdo1VqC+kd0wRY3RI2k5P3hy+gqNU2MZ+Dg19Oz5z8XxgdfOfNQ446INQwmaYNyEnPa eo4It648wwfFK6fhOj X-Received: by 2002:a05:600c:358d:b0:465:a51d:d4 with SMTP id 5b1f17b1804b1-4830e93ec05mr37014135e9.6.1770198929624; Wed, 04 Feb 2026 01:55:29 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43617e3a486sm5477520f8f.16.2026.02.04.01.55.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 01:55:29 -0800 (PST) Date: Wed, 4 Feb 2026 12:55:26 +0300 From: Dan Carpenter To: Artem Lytkin Cc: Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] staging: sm750fb: convert pr_* to dev_* logging in sm750_hw.c Message-ID: References: <20260203230758.3056-1-iprintercanon@gmail.com> <20260203230758.3056-4-iprintercanon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260203230758.3056-4-iprintercanon@gmail.com> On Tue, Feb 03, 2026 at 11:07:58PM +0000, Artem Lytkin wrote: > Convert pr_info/pr_err calls to dev_info/dev_err in hw_sm750_map() > and hw_sm750_inithw() where struct pci_dev *pdev is available as > a function parameter. Functions without direct device pointer access > are left unchanged to avoid unnecessary signature changes. > > Signed-off-by: Artem Lytkin > --- > drivers/staging/sm750fb/sm750_hw.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c > index ce46f240c..60f9f7135 100644 > --- a/drivers/staging/sm750fb/sm750_hw.c > +++ b/drivers/staging/sm750fb/sm750_hw.c > @@ -34,7 +34,7 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev) > sm750_dev->vidreg_start = pci_resource_start(pdev, 1); > sm750_dev->vidreg_size = SZ_2M; > > - pr_info("mmio phyAddr = %lx\n", sm750_dev->vidreg_start); > + dev_info(&pdev->dev, "mmio phyAddr = %lx\n", sm750_dev->vidreg_start); > Same. regards, dan carpenter