From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B26113AE6F5 for ; Wed, 4 Feb 2026 11:39:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770205147; cv=none; b=lY5VbGW8OT8BKjvdFX8TvKsD+8ZnkOHUk6IBlmSuhKgprb6if3pRpuRkwGjIpvZPAZQx2l6Nxm09/pKSa19DURsTHxmwL4yZDfpC+WeQbkX9OY4bjuCLPuvKFHXHfk3uPe46YXhmlKXrL3k4BnJRIlmKMpMHWorJAGzGB5rKv9o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770205147; c=relaxed/simple; bh=3PLp7u4/e9QtU/Z9HbvZ+sWCeQ4IFeck7aj64OWbhLk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k71Xkv5NtTTU8rakFMyZEjUo8D82mIF8KsB/E2mIFhyBvE1ZxF4fvBoGI+UDgMF30Wk7fuGMAUgea1A2CxPS92leNDCnFBK1q3TXYWxn5YEpZws8bP4FkEjknw2bLt4ad7gSa2s1C6MCt/5c0u/uQc/KESxuPJliKuRAlG6z/fo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zggazEqE; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zggazEqE" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-47ee2715254so37248445e9.3 for ; Wed, 04 Feb 2026 03:39:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770205145; x=1770809945; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=t9tqnl4nl5DEpP04BaFMoPL0bj/Xd+YqfHCJcLoEdNs=; b=zggazEqE0ChKl0ha+5jPf1JDVMxk2lF8eXs/1VrDpFHwOLRMtocMTLgm3x43ZmwjWM Ts4wL8Rdoj1BAqq4PNDLCnxvJpiX9ZHdOcthfPmzndRbEBY+Gs5J5JOThghZXmmqaGon NJrvVp7YD/2408hCa/rz5hET85rt2mXaHYa5eYNWqsFOgF+FphzUSU52HIkJaMRK+8yv XmndBYROoSSq7pQBP3CxJ/0W0RYNO1hPjU75RflfgFebasrvNIX9AAPNXUb8SdWNL6V3 V9czSArVbNqw6oVIO+wCCI4/wgGMAj3X3COP6HrwmMdWw/HgiqalrJm/LYr5DhWolZYq NGkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770205145; x=1770809945; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t9tqnl4nl5DEpP04BaFMoPL0bj/Xd+YqfHCJcLoEdNs=; b=Jz6EG0D1AzfSwU8y8lvnLHbAW45hcLIbJwVPjziOqf3WGykzv/pGH5ByyHvDlVVzej pz4ePzo3IUZJmu9YC/D5NJRNYnIO+wbkUa0/F9XU7PrHsEY/8YDP+u9lZxndgNni1r21 dqiG382ED9rA9AorT41Ew2eGvojfBsTVhgwtCf8i2QhwwQhdwRrbs++fx/ksxLiI5lTU cuKRqAlWg6MIZzzQjjPjbwTnpO5RgOzCUDPTtuHOTAOiTgHTmz9RbRxxDV/xYxvlJzGQ a9P7ox3sOlsFQk5KlzXXirMmq2HTzIUHAwZ7WS5l7TTb1JAqv52C/IBVW2zCxG0l9WZX XOUw== X-Forwarded-Encrypted: i=1; AJvYcCVm+CT/EjOp9qUX03uATmWptibKPLNNJRVuEKf3aeHtczKYa58qUiee9SQ5Tx64x3JCusPI8kl7JC6Qp/M=@vger.kernel.org X-Gm-Message-State: AOJu0YxlJY1R7va0WRvJNFZsxr+n6wFzgm9wwifYHcNUQgDxV33gQitf jknYsGqWmbT4L2bz2oxbRUxLfLLoxMFeP/qWhnGKJBCvRnT1AkQ8js3DoIiYtbdgy6s= X-Gm-Gg: AZuq6aLCeFLiFNyG5jrdTX6L2Spz+CRuEZnvogrpsEFYLoHRe2azwRnuyQgQH265bmQ LxFNmmwb49+170KPwPfFswrrfGu5D6B18kZNRY/jG1wHEgA1G7OnjQh339LzkPxYTiqiBpmBsRV Gs3VB3pUa1u8untvte9ndyGONDieAkkujsAl/fcceztijCHF8LeiAdFRrBSyQrcKhsWyevw0Uv9 Jnugj8KQX/InWMmNPe6uT4XOM6UOBCNSJhPMF6Zsj6I+9W0do28w1o4gHl32Qm25AGPvxVhG5dZ E+GEnVDtLgZvhP1KnNP/zJKTL8/e5vmhdNESvG5X7kd9zCD+UkuinXW+0tt4ngxzVlJbdhh69ZJ H5pgV4k9+uIANG04/XN3wAVGkyUMHo0jBQqZES8pmCDln+KK/w4bEMB2T21qAOCqdU4UINInSuS IIG1Yax5TULCulShHs X-Received: by 2002:a05:600d:6447:20b0:480:7385:110f with SMTP id 5b1f17b1804b1-4830e94c939mr25956105e9.12.1770205145002; Wed, 04 Feb 2026 03:39:05 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4830fe69e9fsm22558835e9.6.2026.02.04.03.39.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 03:39:04 -0800 (PST) Date: Wed, 4 Feb 2026 14:39:01 +0300 From: Dan Carpenter To: Artem Lytkin Cc: Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] staging: sm750fb: remove debug prints and convert logging in sm750_hw.c Message-ID: References: <20260204101536.3311-1-iprintercanon@gmail.com> <20260204101536.3311-4-iprintercanon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260204101536.3311-4-iprintercanon@gmail.com> On Wed, Feb 04, 2026 at 10:15:36AM +0000, Artem Lytkin wrote: > @@ -163,11 +156,11 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev) > * The following register values for CH7301 are from > * Chrontel app note and our experiment. > */ > - pr_info("yes,CH7301 DVI chip found\n"); > + dev_info(&pdev->dev, "CH7301 DVI chip found\n"); > sm750_sw_i2c_write_reg(0xec, 0x1d, 0x16); > sm750_sw_i2c_write_reg(0xec, 0x21, 0x9); > sm750_sw_i2c_write_reg(0xec, 0x49, 0xC0); > - pr_info("okay,CH7301 DVI chip setup done\n"); > + dev_info(&pdev->dev, "CH7301 DVI chip setup done\n"); Delete at least one of these. Pretty sure that Greg will want you to delete both actually. regards, dan carpenter