Re: [PATCH v2 4/4] staging: sm750fb: remove debug prints and convert logging in sm750_hw.c

Dan Carpenter
2026-02-04T11:39:06Z

On Wed, Feb 04, 2026 at 10:15:36AM +0000, Artem Lytkin wrote:
> @@ -163,11 +156,11 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
> * The following register values for CH7301 are from
> * Chrontel app note and our experiment.
> */
> - pr_info("yes,CH7301 DVI chip found\n");
> + dev_info(&pdev->dev, "CH7301 DVI chip found\n");
> sm750_sw_i2c_write_reg(0xec, 0x1d, 0x16);
> sm750_sw_i2c_write_reg(0xec, 0x21, 0x9);
> sm750_sw_i2c_write_reg(0xec, 0x49, 0xC0);
> - pr_info("okay,CH7301 DVI chip setup done\n");
> + dev_info(&pdev->dev, "CH7301 DVI chip setup done\n");

Delete at least one of these. Pretty sure that Greg will want you to
delete both actually.