[PATCH v2 1/4] staging: sm750fb: add bounds checking to option parsing in lynxfb_setup()

Artem Lytkin
2026-02-04T10:15:39Z

Replace strcat() with memcpy() and add explicit bounds checking on the
remaining buffer space before each copy. The original code lacked any
validation that the write position stays within the allocated buffer.

Signed-off-by: Artem Lytkin <iprintercanon@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index fecd7457e..0eacb522d 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -1163,8 +1163,15 @@ static int __init lynxfb_setup(char *options)
} else if (!strncmp(opt, "dual", strlen("dual"))) {
g_dualview = 1;
} else {
- strcat(tmp, opt);
- tmp += strlen(opt);
+ size_t opt_len = strlen(opt);
+ size_t remaining = len - (tmp - g_settings);
+
+ if (opt_len + 1 >= remaining) {
+ pr_warn("option string too long\n");
+ break;
+ }
+ memcpy(tmp, opt, opt_len);
+ tmp += opt_len;
if (options)
*tmp++ = ':';
else
--
2.43.0