Re: [PATCH v2 3/4] staging: sm750fb: remove debug prints and convert logging in sm750.c

Dan Carpenter
2026-02-04T11:17:52Z

On Wed, Feb 04, 2026 at 10:15:35AM +0000, Artem Lytkin wrote:
> Remove debug prints disguised as pr_info that dump internal variable
> values, pointer addresses, and structure contents. Convert remaining
> meaningful pr_err and pr_warn calls to dev_err and dev_warn where
> device context is available.

I feel like you should delete things as a separate step. It makes it
slightly easier to think about.

It's really a no brainer to delete all the pr_info() stuff. I don't
really have a problem deleting the debug code as well, but that's a
slightly more involved question because it doesn't really hurt anyone.
I guess no one will complain. Greg tends to be a fan of deleting stuff
as well.