From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 250EA2BE03C for ; Wed, 4 Feb 2026 21:12:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770239525; cv=none; b=c6g4tr0FSpc+utr4HzpGhxQYC7FZTWXFQA1xiTv4EXxAQp4idaUTy61I6+NM1Ltuy0RSdkUiKb0hXFtbTclBDYOBTMpJ37C8titJiPgNQYjnsn5ABHHj0OhCD7Awh+MeMZY3PXXqVyKWThOxQ9/cZ+MjsmgHGZ7cfqU1d603geg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770239525; c=relaxed/simple; bh=yttss3Q9KiabiVq+I8ru33iXLqJEhygxc3lQ+tgJI/U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pCmh63JkR/m9O20aYBHCK9bB53y6k9E220cnTWzEOfyJsCNHlv4hYBeS+nYKfYABNZw447V3zqQhFBBRiiCqdop/Xwl0crwjn3OUMD6yS+xD+7PylBkSgq9qUHqvMk3t54SJAl0nz67pIj3wjS03P50xvQQpq5Zr9xtK1hzEC0Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=VwneSCtA; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="VwneSCtA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770239525; x=1801775525; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=yttss3Q9KiabiVq+I8ru33iXLqJEhygxc3lQ+tgJI/U=; b=VwneSCtA5U7tjVjSi0c3hisK+xEq445nsCxxjllg1AcXdrNl7He4Qal6 8xYe/uZvr2d+eDODkY/0tFXRB6WR/CxKQvN0uTwr3O7POzQwPuf/zEUkV XwOJhXO4e4xajb3xKJCGDOUjUh2HPNymY6xY+EVnqEvz3TG5msi9y6mcF jV8nhfr22l0umjXeEwrJwl3a+A0b7MsQmdaM9UD5RNw0IpHvumtYTFUP8 VeNZFbXna2XbJoGRiMgGiwDDWGB7DsAae18swh3mTM7HuMiOG/axr+o1k AM7ZZN4hgROqm9jH147b41Khe5OCp1bDuFsfOJtfZlw692WM/ZiOCmF6K Q==; X-CSE-ConnectionGUID: UCQ6rcNfSaaH9aX2EaOPTg== X-CSE-MsgGUID: FI2vtGuISB6wtUwbns5w9w== X-IronPort-AV: E=McAfee;i="6800,10657,11691"; a="89016884" X-IronPort-AV: E=Sophos;i="6.21,273,1763452800"; d="scan'208";a="89016884" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2026 13:12:05 -0800 X-CSE-ConnectionGUID: skLqpx8xTACKpQkjes1rJw== X-CSE-MsgGUID: /3NCVb3FR7y1AR1sycNBRA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,273,1763452800"; d="scan'208";a="214453397" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.188]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2026 13:12:03 -0800 Date: Wed, 4 Feb 2026 23:12:00 +0200 From: Andy Shevchenko To: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Subject: Re: [PATCH v2 1/1] mtd: cfi_cmdset_0001: Factor out do_write_buffer_locked() to reduce stack frame Message-ID: References: <20260204012630.2211832-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260204012630.2211832-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Feb 04, 2026 at 02:25:27AM +0100, Andy Shevchenko wrote: > Compiler is not happy about used stack frame: > > drivers/mtd/chips/cfi_cmdset_0001.c: In function 'do_write_buffer': > drivers/mtd/chips/cfi_cmdset_0001.c:1887:1: error: the frame size of 1296 bytes is larger than 1280 bytes [-Werror=frame-larger-than=] > > Fix this by factoring out do_write_buffer_locked(). My gosh, I already sent a v2 earlier and there were some replies, I need to check... -- With Best Regards, Andy Shevchenko