public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Salah Triki <salah.triki@gmail.com>
To: Peter Rosin <peda@axentia.se>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mux: core: fix reference count leak in mux_chip_register()
Date: Wed, 4 Feb 2026 21:54:31 +0100	[thread overview]
Message-ID: <aYOyB0_Nmp9gR_pw@pc> (raw)
In-Reply-To: <6f7ebe28-7b93-4e09-ef86-4428d35ada1b@axentia.se>

On Sat, Jan 31, 2026 at 11:03:55PM +0100, Peter Rosin wrote:
> Hi!
> 
> 
> This patch is broken. NACK.
> 
> The put_device() call that you seem to think is missing is found in the
> mux_chip_free() function, which is what should be called to clean up
> after (a successful) mux_chip_alloc().
> 
> If there really is a leak somewhere, the real problem is a missing call
> to mux_chip_free(), not a missing put_device() in mux_chip_register().
> Adding a put_device() in mux_chip_register() leads to too many calls to
> put_device().
> 
> Cheers,
> Peter

Thanks for the clarification, that makes sense. I'll drop this patch.

Best regards,
Salah

      reply	other threads:[~2026-02-04 20:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-31 12:09 [PATCH] mux: core: fix reference count leak in mux_chip_register() Salah Triki
2026-01-31 22:03 ` Peter Rosin
2026-02-04 20:54   ` Salah Triki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYOyB0_Nmp9gR_pw@pc \
    --to=salah.triki@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peda@axentia.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox