From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010060.outbound.protection.outlook.com [52.101.193.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F8AD2D7DEC for ; Wed, 4 Feb 2026 23:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.60 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770248852; cv=fail; b=Ywa5iGl7tdC5+GWkduvz5TGaAlBwcAG1uGp5nxVgZgT/IzPqqb0T4D8dfLOtuy+U7nJRTV+7Uj6rj+yxkWggg3WKi0nu4VmZOxC0T6gERjoeO7PdqL1wOj/Q3RajnoQgiGJfywBSPOZlu9vBp45cH3l13X137Vm8DM2escSdcdw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770248852; c=relaxed/simple; bh=6KESZ5g7hh5g1BcsqmpxoHNKUp6MZ4adXA4JaAWeCZk=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=C6MjYgaViP0pRLnpsUnptX75Qn9aqPJ0frnHkJpdMqIkyLEGjwrkxP1SDhblrvU3IhQUAzbw493HfKOakjhwTuOaEf1c4txWBcfom9xbV70ZBw4XG5DR1NEfPv47VlB+P+V3cjyO3Ojac5ipc592wCk8EM7DxOJPFND1VnUD0B0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=aZ4QHoBO; arc=fail smtp.client-ip=52.101.193.60 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="aZ4QHoBO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Id41GBxENDeGl4iX3DYPMjRsOXPzhDguRpHTwqCm3/Cm70lQ43KejXqsRB1QxJz1/jjXu0jU7wp9WZFGfvdr4zoBCUpkGTfXrWs8J2/Gh36KB0xbXA89ov6D5/7Bw0rRIRENC/NgdmQIuZ8VyuoRXUtTsGCg7rEH9BNdcrzFzwnTOy6rQ8lMTpVymvEyB1plmErHVAuTBKwwOxcBecCO8JYUQ3eC4Lrzx85KZFaDMNMUL4e96lYFu3wgK2Ui9tlq+fBDl9kiuAaTdPa1UkjX+1J29+rx2Y32QQNwYjJCZEAsVKJL9MVTA7yZDZqtjQHMvxvKzwCMiAqmIjjud7Hpvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9LBl63pCK4iVc1H1i4aMDhZDspk48VoHWFFI20UG+Xk=; b=qHFLqi9SeIOkk43vaEQlMhGHFiPb8fpjVfkAtviBa+VPx3+176c1nkF/ApFFY0i1ImU5KZOgm9aRGlO6Wiq/y8ImkonILVOncWBcYn3Ep+IVWJzUvkfN1FjuxxC3E4fCgBBwJrx8Y32H7KhIRRvwEJm1hmX+3yCUSUeQ8OfS3n9Fw4uwAVlcQGsNmrwEzGU85wLXxMxw8nRU+LClPWTY+3ihigye9Jf3cLKtmktSQu+LvVA1e3LoqavY3pAbRoctITBIJUF2v7tT4k0rRIYn9kyPiVOvb1B173zci1hRLMK10C1zGL2/qJXlhUxVcEwyASRZn8NZ6IaWpV8U+yEZaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9LBl63pCK4iVc1H1i4aMDhZDspk48VoHWFFI20UG+Xk=; b=aZ4QHoBOS2goFs3ICz0BaXo0HtCiec+SXQRp3aRrMD/wmby8D8t8iFhUIKJtkhIvfHTWOjym2UV1HRH+qjuurhntCUmMcb7UFzpWvM4ChdvxmPHFcTmcaktDAjqBpUcvEiRFp5j5EZ8KBCOmQUfMjPxx2SqxY8SyIth4rjJw3pqk5sCMVmvtWYzv+GGmSU8hdj73JtdDvkTZzpLIINZ26pq9C51UGVD9eSnqQXm9xm5ylE1Y/XHxNPMoiU8WOWLvsUbLokSxCqgRxlkSCrW/JH2axKCUbr4hgn+gO5u9DdZXVKhuqH8Q/GItljPID71NrpaKR9omPTA288BeD3TXRA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6414.namprd12.prod.outlook.com (2603:10b6:8:cd::12) by IA4PR12MB9812.namprd12.prod.outlook.com (2603:10b6:208:55b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9587.12; Wed, 4 Feb 2026 23:47:30 +0000 Received: from DS0PR12MB6414.namprd12.prod.outlook.com ([fe80::2459:590d:bcb:1f9e]) by DS0PR12MB6414.namprd12.prod.outlook.com ([fe80::2459:590d:bcb:1f9e%4]) with mapi id 15.20.9587.010; Wed, 4 Feb 2026 23:47:30 +0000 Date: Wed, 4 Feb 2026 15:47:28 -0800 From: Saeed Mahameed To: Pavan Chebbi Cc: jgg@ziepe.ca, michael.chan@broadcom.com, linux-kernel@vger.kernel.org, dave.jiang@intel.com, Jonathan.Cameron@huawei.com, gospo@broadcom.com, selvin.xavier@broadcom.com, leon@kernel.org, kalesh-anakkur.purayil@broadcom.com Subject: Re: [PATCH v3 fwctl 3/5] fwctl/bnxt_en: Create an aux device for fwctl Message-ID: References: <20260129155453.3626544-1-pavan.chebbi@broadcom.com> <20260129155453.3626544-4-pavan.chebbi@broadcom.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260129155453.3626544-4-pavan.chebbi@broadcom.com> X-ClientProxiedBy: BY3PR03CA0027.namprd03.prod.outlook.com (2603:10b6:a03:39a::32) To DS0PR12MB6414.namprd12.prod.outlook.com (2603:10b6:8:cd::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6414:EE_|IA4PR12MB9812:EE_ X-MS-Office365-Filtering-Correlation-Id: 3f3e33a2-b9e1-4aec-51a3-08de6447c244 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?5/9TQJ0GibTxfjEGYsTJH5kYlZLoKxnfptCQ8A1i/bzU5jNu5LJ8xhbgHFrP?= =?us-ascii?Q?G16hu9AyYNvQ/zKh1598J8/UTsJa0ITRVfsrn/imke6ykZWM5/FfH8D6ysfN?= =?us-ascii?Q?CQIcHEn/W80OTNi/VnH4IQ8XIrXtO/4h9taDMCcuWY7s+j4tiv5FqLlCzkkX?= =?us-ascii?Q?1zi5WAHt0/hat6F7KpsSz+sWOSlblAMugaqsW9P+XAA2twj2uUc5HHS5GBdy?= =?us-ascii?Q?aWDRDsP7NqJihZltQgi3iLwdau1KAwZXaVXAaf40ydvEjNtt0STbvEhpfRHg?= =?us-ascii?Q?CwbMc+59OGuVFza0rLS0jpr+BkSsSw8zIFHtSte+V6jlMVA7IVPynybdesa3?= =?us-ascii?Q?oJf74WPJF+Lh8payERXKmnG1XgU4tPZs2L6RxIenqpGHJeIroBdPj8oG6xa9?= =?us-ascii?Q?ymAHYe0R7H2Dm4QetZrNNKVQaTkgavmyrXcTe08FkJSPgjLFVwA04EDudrA4?= =?us-ascii?Q?hDjPR5KwF/cot7+TOcWj1TV2zS/bY3acOHwc4P+Hzv7lTEOz5WesVxKgIGd9?= =?us-ascii?Q?ThZaC1yASVnLfrzq3QpnHw4Z+MP1u//mMqlztaN9O6MLcfrvnXBi3wyXq+/G?= =?us-ascii?Q?igz67yS6ELc38G1ES2lAuzjOvuw58hwfkDWT1tvDo1OJXuGT8hTAzIaEItcd?= =?us-ascii?Q?3EG/ZN1dhwc6/drPAYfwFgpls/T7u711XdkzPxswUK0/kEOqNKj1uIA8lfi+?= =?us-ascii?Q?DM/TY+jlIxCJEdGZ/cUExNPGGPXc50ockOZlzNQWSm67Zzvmo0URUn2qCWkN?= =?us-ascii?Q?QkF1j0eqOB1wbyAvnpEGQqInG4h4PvY4Yri33BTCsdioYk8uPSx8ZVu+WgkT?= =?us-ascii?Q?1e6fhGPb1J4LkbJcXu1f+MQ0i1JvizC/g7kqF2A5EKSYYhnM0mr71kTroMHX?= =?us-ascii?Q?8TwkpoBLY7HQ7yCBJ+JxEuZROOO5C0mfjKNirJHVZbqaye4qlT68z2mhRJhj?= =?us-ascii?Q?jIDsBKw+yca1DZWsMOcYlXD0oKQVW/rWexXeuXlkTYiBFiy8LsPHmBqaLbeQ?= =?us-ascii?Q?Rs3bgADdi4geGTiydbeZ6ky4JyW6Z1YQ868g1rBKINHGarlGW3f1HVaIBtBb?= =?us-ascii?Q?xyF36M34192ccZO4y0JpOZ1OzQgtYIIY6Yzm13zVkmYvfqAAGxQCTLZ3TzR1?= =?us-ascii?Q?Jm/JnbkPOCtTurqRLQll/D7nBhqxpQJ76V7D2dCzEaAzraV6ZVGoVvAwpXlp?= =?us-ascii?Q?UxHMBLOLsNNK2dd5WxkHH3F4Tq4y5UywZIduXTWC/VFUKsfFFZLPu8srujqO?= =?us-ascii?Q?GYTFb6ow2FXZuEQAPmOzXO/T3kX0/54ABo7FLXDrXVjGNskcV3YiHch/rw1d?= =?us-ascii?Q?vFoJcoC9bX1Zltq9YoNrDYIIJed2yJK4bZCEU5gB8Mcjkr1W34lBIV+O+o8s?= =?us-ascii?Q?GzfR6UeHHKhB99asKY7zbdDcpgB4y1+3zW49RFEwV2YUKDwB/vnLeun0m9Nz?= =?us-ascii?Q?BedD7qxq/v94EMi4zLJi07alUoLs7EcoRRNwEZQxXRjVIFsFWN3NMhmK36Iv?= =?us-ascii?Q?Kgptb57ZZTW4rIGB6/n4h/nlsHUdxuNdVDRWZp9BlrT/SdDesCBnvcOj0nKk?= =?us-ascii?Q?b92P0uJ6kVmfiMrXNNU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6414.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LOkQSIgAv9gSLi8WG8bqyT5aNDHC2nOfOzCclcgDcCxe41s+SORLY2lM0Cr6?= =?us-ascii?Q?DYwGiAt/FQTQhvBqbgTcMQZDZNpis1KbJawCJHWerszBKNAM3+FmUB7TNkf5?= =?us-ascii?Q?PknHJLeDtYS3YdFR6pOmzfaoZzi1DU2X2bGsloXuJArUXLP/gPANlfJDPhTc?= =?us-ascii?Q?si9eX5Mtx4ljgUaeB5iJhOrwGanA7p8vNp5S9Npmk34eK9gV9ZUIdFH8Zy6i?= =?us-ascii?Q?dYecBEa6x5BuqAhwZQ5FD5xNSWHCkXfQwA6CDBlgG+2eyYyPeiup6fyhwuLu?= =?us-ascii?Q?J5Sk6WCkpPg4pXyc8+RIoh7DuWwkkwRGHHb/VjGAHkdOYZm+6JQf4z/R5j10?= =?us-ascii?Q?/iOluvlmFkEG854rK2ro1AKK3D5BT5Eq62fNiWe1SWQtBbV4DFo8uUzbKS7B?= =?us-ascii?Q?Zemy4b1+Z8ZV7Tz1/QFphBVb5Tz1Nk5U7r1TG5fgGkoAHXt4ENZa10pvsncB?= =?us-ascii?Q?TZqgW9wKi4ZFADoI6FQr4OhdV0H8BrK6T5ON1nUb4DqmxAaxcKSQALSBnsZg?= =?us-ascii?Q?fF1+++VC9SJVq38NkINRZyfuQ/KUZUpYcqvgVQHoCwwDOuOQ5bShTDE+doA5?= =?us-ascii?Q?b1cGLUi7iHTJhnp59p0X4szDwKI3njRwNf/EIjk9ukWTPByTF9CjEquUdg9+?= =?us-ascii?Q?RleEfLJ/V7fwNNLULn1FBO9dOozVUKqYCru/IgKn9298RXdNLAF3Wts01FNh?= =?us-ascii?Q?FjZeTjCJBGYoE6KX7wbngRxEJsdNaQxQYw3K9DBnEAl+SuN9+SgHGnYh0H7O?= =?us-ascii?Q?d6LuU+9f6eDwWdXvo6vprrazVyIcL+BXwerk7MZ7GW21lWrn4c8BY+73L+ex?= =?us-ascii?Q?CMVQaIlzotK5RuhPxZal7mXve1clp33gd11HRrGHMbP5AtHl0YB+k4c7VXnA?= =?us-ascii?Q?bfr7ioX6ZxXqyxH9bR6AsQs65oZKd9+Kvp3zQTmppyTjCf00x0jInZ8hApKe?= =?us-ascii?Q?0FLcZSjTttnIMdADOwe/ln/oyM0Aid8qCyPg2VJ3oFzfOvjsiBaOTvYfELp8?= =?us-ascii?Q?1mouXJ4Wcw8pvrPftdP2Gx516st1KmD6s5tUqDYZafiV7BSJZsfeKweNW2lP?= =?us-ascii?Q?p1zhUW8mJEEPHsYmc7C/RQAU3sDd9oEEOGojwYXToLs98Sc00YXKZxP1CLvL?= =?us-ascii?Q?3Hfo//HJBpy7eMqIxlwSYw/tCC2D/+NTzK7F4tG3UBCaw+sjCkVW+F++vihi?= =?us-ascii?Q?YPYbrIhEMCdKnsXLvOYctBHtlOiE1c7bx3XqeH5R99zERjQJ9qVzMz4tKZfh?= =?us-ascii?Q?uk/SKqICHekVZcgyuHmvJKUz6aqv6JLyLVhJdLAYCFYX2XJ2v6x1DG69usCR?= =?us-ascii?Q?Lus6tQ8suztZWz62lDWVExpRO6O6hgXZz4pB8ebbDtPz+F5CO8obsBZwrdvd?= =?us-ascii?Q?RAvOWJaw06GGyIoPUcA1TDCYu8IiNowoeaEnkXaXWV6R5quIz/tdFloAt2vh?= =?us-ascii?Q?1LTuRK670FhejZDXglKwewJexBfFF6S96SX8YDPd9ULDVWttnpoQbGCcFOND?= =?us-ascii?Q?3SS59BToVAHVa9OdVAKvAJKGlD/M0hHjG7RWAz82Ay1g+Z++Z2N1pHtfXzt4?= =?us-ascii?Q?RfNOVcDl04kIccenUxA1wEqH3H3vx5oIkWIo6RFR/tiJeMe6QDuog+2/nPg7?= =?us-ascii?Q?3HIHGdcbUID1dDzIUYUYjB4OxY7qqmsknOXB779n2lJLi1IN3LiQbDOtrsl/?= =?us-ascii?Q?DhzIlBvN5IOfQYg3NwzUJwSZ2SDaAaBq7L1z4XOOh4Q+1CAvTgQAlyTKGS6Z?= =?us-ascii?Q?qKIrfGswDA=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f3e33a2-b9e1-4aec-51a3-08de6447c244 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6414.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2026 23:47:29.9144 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GbwvweRmBo1KeVEkECPMESEkdsEJIo3fhRwnjHy9X5sUll/IzBYNe8fIYuGIfd+jflsh5k+uAhdLzFgnLshntg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA4PR12MB9812 On 29 Jan 07:54, Pavan Chebbi wrote: >Create an additional auxiliary device to support fwctl. >The next patch will create bnxt_fwctl and bind to this >device. > >Reviewed-by: Andy Gospodarek >Signed-off-by: Pavan Chebbi >--- > drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 12 ++++++++++-- > include/linux/bnxt/ulp.h | 1 + > 2 files changed, 11 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c >index 3097fc5755e6..9fd3c1e43224 100644 >--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c >+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c >@@ -50,6 +50,8 @@ static bool bnxt_auxdev_is_active(struct bnxt *bp, int idx) > > static struct bnxt_aux_device bnxt_aux_devices[__BNXT_AUXDEV_MAX] = {{ > .name = "rdma", >+}, { >+ .name = "fwctl", > }}; > > static void bnxt_fill_msix_vecs(struct bnxt *bp, struct bnxt_msix_entry *ent) >@@ -278,6 +280,11 @@ void bnxt_ulp_stop(struct bnxt *bp) > aux_priv = bp->aux_priv[i]; > edev = bp->edev[i]; > mutex_lock(&edev->en_dev_lock); >+ if (i == BNXT_AUXDEV_FWCTL) { >+ edev->flags |= BNXT_EN_FLAG_ULP_STOPPED; >+ mutex_unlock(&edev->en_dev_lock); >+ continue; >+ } This felt a bet off so I had to comment on patch 2. The fact that you need to maintain a edev flag for ULP state was before using aux bus for all upls which was kindof ok since it was unconditionally set on bnxt_stop/start, but now the state got pretty complex with the introduction of dangling aux devices as I mentioned in the previous patch. please see suggestion on that patch, I am sure this can be simplified a lot. > if (!bnxt_ulp_registered(edev) || > (edev->flags & BNXT_EN_FLAG_ULP_STOPPED)) { > mutex_unlock(&edev->en_dev_lock); >@@ -316,7 +323,7 @@ void bnxt_ulp_start(struct bnxt *bp) > aux_priv = bp->aux_priv[i]; > edev = bp->edev[i]; > mutex_lock(&edev->en_dev_lock); >- if (!bnxt_ulp_registered(edev) || >+ if (i == BNXT_AUXDEV_FWCTL || !bnxt_ulp_registered(edev) || > !(edev->flags & BNXT_EN_FLAG_ULP_STOPPED)) { > goto clear_flag_continue; > } >@@ -521,7 +528,8 @@ void bnxt_aux_devices_add(struct bnxt *bp) > aux_dev = &bp->aux_priv[idx]->aux_dev; > rc = auxiliary_device_add(aux_dev); > if (rc) { >- netdev_warn(bp->dev, "Failed to add auxiliary device for ROCE\n"); >+ netdev_warn(bp->dev, "Failed to add auxiliary device for auxdev type %d\n", >+ idx); > auxiliary_device_uninit(aux_dev); > if (idx == BNXT_AUXDEV_RDMA) > bp->flags &= ~BNXT_FLAG_ROCE_CAP; >diff --git a/include/linux/bnxt/ulp.h b/include/linux/bnxt/ulp.h >index 1a4643c46f86..0851ad3394b0 100644 >--- a/include/linux/bnxt/ulp.h >+++ b/include/linux/bnxt/ulp.h >@@ -24,6 +24,7 @@ struct bnxt; > > enum bnxt_auxdev_type { > BNXT_AUXDEV_RDMA = 0, >+ BNXT_AUXDEV_FWCTL, > __BNXT_AUXDEV_MAX > }; > >-- >2.39.1 >