From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D4AF35975 for ; Thu, 5 Feb 2026 05:45:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770270323; cv=none; b=W0L2B11skaD3geAUO64gomqOQG32xW681PPzQspb35UAQIR8xS5IbFBEIn1NvQPuncleBxl9EVwicT59bzWmzqxzGDjRiLo5qasF52850tRLYUjM0cxzNep2Ep6hv6B/PcIFU4oIKLRVKDfGz1tm88safFnyofvDSUwCHY5/Baw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770270323; c=relaxed/simple; bh=BxHkQnWiZGK8SegJF00wGZb6bJ+KMssGsjb6bt6VFEo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SFAiIczfdKUHZyxI0ZNMEwvc8pEgUigqN9BNt36eh/LikRxbJvfpnh+M6RtC/0ELCRDGG+2wt7eL0QZWNDrsawJwf7KE6PvDLbh4lqMeRrgfoLg1b+XY9RKRfXgPvkVrac/GGjwrCrgYkAHADaUMOpgiG4R7pT88McXduWXfLkM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=k0O21NBP; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="k0O21NBP" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47ee07570deso4041065e9.1 for ; Wed, 04 Feb 2026 21:45:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770270321; x=1770875121; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=q9ZbjIehz2HbPNy+4HYnVCfD5OADW7ZHwhYE+qzHtDU=; b=k0O21NBPjijBahUELgqeT+FKL1drAeWpBj3W08cwCvPHKL0KY0r6bkg5M8lKQq/nwE ggTfwqNTAH1HQPU5liY2xcB0OwZHUd0ukajK5Hf/lKDbHWbdGM8ciaqowufnwKRS+Vjw Dhnoz0ZrvMb+Hp1nuF/LLf+87/mQ3o0ph4Q+mHkbQ147gmdApb438LTJrx+GLFKZZxn7 Y7RZUPDyMAfz4Lvhvm8dbWtJdpCi9KabXND0ZhQDWFnExIlqjdUce+htFZjcfm9c92so nJ4SvpX6eNiwIpwX4SPZx+XvihcqSW9eyE8LA/reV1jw53uI6sNZNZNWoRdsJeD9ryvb 2Exg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770270321; x=1770875121; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q9ZbjIehz2HbPNy+4HYnVCfD5OADW7ZHwhYE+qzHtDU=; b=cDfMQ4zggSNGCkT8MT5EhONB/HqR4GE08RWSDr0NHFmwCfMkqpqJORom6r0IvrA2hp Eqr3h85TEev25/Ayb7V2KAzJx+PmbLI2jKDwKTwvYU9ygHQepLEaM9z070jae94t//80 LPG9dyzUsypn9Scbxr2z5JAIeEtdw20UN+PsfQqIdE7G1YstiRY0cQ/dweH2mSuPHxpB js9H/pwHGYsMSCsU5O1+i6SasbAV7p06NOiHi0oiNMJ/CJgh7YpSsQiK9f0FO+mmP9Qx gPwgTSvV6G60G5ov7tmTI+o5PYUuodHlPFgZwtgNCjoISvwDrIu7HSjIV9bFAojhsAVk AAog== X-Forwarded-Encrypted: i=1; AJvYcCV89aUkO79IIeiqnsbaOvdHjm5VLALBBQeo1gNpAvAaZrhFPkYg+Zr8O13ziq3hzn2Wyc1q7JnuyRX3UuI=@vger.kernel.org X-Gm-Message-State: AOJu0YyuE0+VQaOys1LDXSjr5u3lY1CDl0Ocr/IQMlTuUk00WNyIsm/Y vnGvV4hO+wDcrcX+qH+sDAmEmfoTBl+5z1JsNn2lmb2PeW3CG7GjsdaIFUMhe8hWIEE= X-Gm-Gg: AZuq6aKSrlsEogi4gVw4jY1j0k+vznF8NKrkRfd5+gt6f6XXQnz2qgfdxYjE44FcogY JGSl/wDeOJT0sySJ5LFp3LTs8hsE6AbJxW0gV8vXKRZ5InLOgYRS+2EXC8O9w2IBQpnsUvRnGdS kKuuy35x4h6FM+U07/eFk0sfcFtRg7LPJrR8siLUMvZVKGrzSb4kuZK7JCUvjrJ3UKhz4+GPuTE e1jk+x51o0YJEz3LrqtIXVa+UmknxImks+egl00h0dNTNe8otKftJ3qE26mQ3upuLLZ4J9v8WkZ sDm8Z7xa+XmfsvGz6iym/J0nvtwxFp1DxLfpqu2Ik3uJebsA+/1rzHuhjKCEz9EootMMYC4Jgih 5yl9Yz8v9GLJWwYPi2x3CwUTSyU9++ngfUiTpSGg2LpxnFbvNs6CnR2DsorySvbmNW9w7Z20uzM ptr98xUSDw85WV4hWZ3sbDzLFM94c= X-Received: by 2002:a05:600c:46d2:b0:483:885:f0b0 with SMTP id 5b1f17b1804b1-4830e99d428mr73842535e9.35.1770270320777; Wed, 04 Feb 2026 21:45:20 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4830ec57bcdsm62695735e9.2.2026.02.04.21.45.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 21:45:20 -0800 (PST) Date: Thu, 5 Feb 2026 08:45:16 +0300 From: Dan Carpenter To: Minu Jin Cc: gregkh@linuxfoundation.org, christian.gromm@microchip.com, parthiban.veerasooran@microchip.com, hverkuil+cisco@kernel.org, laurent.pinchart+renesas@ideasonboard.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: most: video: fix potential race in list iteration Message-ID: References: <20260205021620.1165137-1-s9430939@naver.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260205021620.1165137-1-s9430939@naver.com> On Thu, Feb 05, 2026 at 11:16:20AM +0900, Minu Jin wrote: > There is a pattern in the loops where the lock is dropped > to call a specific function and then re-acquired. > > The list can be exposed during this short gap, creating a potential > race condition. This patch fixes the problem by replacing the list > head with a local free list using list_replace_init(), instead of > using the lock/unlock pattern in the loop. > > Signed-off-by: Minu Jin > --- > Changes in v2: > - Use list_replace_init() instead of moving one-by-one. > (suggested by Dan Carpenter) Thanks. Reviewed-by: Dan Carpenter regards, dan carpenter