From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.formilux.org (mta1.formilux.org [51.159.59.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32F1F219A71 for ; Thu, 5 Feb 2026 15:36:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=51.159.59.229 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770305804; cv=none; b=gIx5UesS3n5AhtvT8F6dVryYsXEvwaCAzyk9OkZ4GGRVqutpxD2kwNp4I2H+x+SrnblJUHWjNLg2xFWsrliRu+6r1WobX3bM86xaAZ1i+YydXgZmKOkIp/SgRAZGgx5c1XnFLzTjluc4vz9Tsuol5PfecpnDMzv+4RYG5mN+vwg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770305804; c=relaxed/simple; bh=NtwADNrvezLQIcTpSSQftO1bu4ZF4AIO5BFCIcvyxd0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CVVrSIDvMaNBBKWGeTezTRmDzo0wC4D3PGoo/rdEA7yuZq492jhy47bWPWGwX2csO61MdD2KQJyiHjFVi8RJYQUoVfev5W5UeJzAoZWAo4mVhQN3KLRVF3L8V4WzUgGFSe8YZ5lymrfs5LkVbguQ5pc+JR9jXtsac94xEemv0eI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=1wt.eu; spf=pass smtp.mailfrom=1wt.eu; dkim=pass (1024-bit key) header.d=1wt.eu header.i=@1wt.eu header.b=X5TWe283; arc=none smtp.client-ip=51.159.59.229 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=1wt.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=1wt.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=1wt.eu header.i=@1wt.eu header.b="X5TWe283" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1wt.eu; s=mail; t=1770305795; bh=bDG6JUw0vcIRR0kyBBhmEXyGARwRCtNfBmiWb++p9+c=; h=From:Message-ID:From; b=X5TWe283hcU9qCzxp/Q8l1S2heYWS4UvpZ6MAqfiSS9O9rEO9mxN8lVFR6YG2Zrfi wb482IoVIPe7SxK1BtPivi3SeI9sSfF3h8TUZ3GT58VGHo+uPhztYPXnWlB7UDHj34 pEODenMJvaTT2kEdaFUgC9rCSqKHQT9jst0ouAMs= Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by mta1.formilux.org (Postfix) with ESMTP id 26F58C0BAA; Thu, 05 Feb 2026 16:36:35 +0100 (CET) Date: Thu, 5 Feb 2026 16:36:33 +0100 From: Willy Tarreau To: Heiko =?iso-8859-1?Q?St=FCbner?= Cc: Kever Yang , linux-rockchip@lists.infradead.org, Finley Xiao , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla Subject: Re: [PATCH v3 3/3] nvmem: rockchip-otp: Add support for rk3562 Message-ID: References: <20250415103203.82972-1-kever.yang@rock-chips.com> <20250415103203.82972-4-kever.yang@rock-chips.com> <20250728190154.GA24527@1wt.eu> <3080333.vCJZsxu672@diego> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3080333.vCJZsxu672@diego> Hi Heiko, On Thu, Feb 05, 2026 at 01:50:34PM +0100, Heiko Stübner wrote: > Hi Willy, > > Am Montag, 28. Juli 2025, 21:01:54 Mitteleuropäische Normalzeit schrieb Willy Tarreau: > > On Tue, Apr 15, 2025 at 06:32:03PM +0800, Kever Yang wrote: > > > From: Finley Xiao > > > > > > This adds the necessary data for handling otp on the rk3562. > > > > > > Signed-off-by: Finley Xiao > > > Signed-off-by: Kever Yang > > > > Successfully tested with Jonas' patches on top of it on my > > Radxa E20C (RK3528): > > > > Tested-by: Willy Tarreau > > as you replied to the rk3562 variant, does that mean the rk3528 > uses the same variant data? Now you make me doubt, I'll have to recheck the original message in its series and the patches that I had applied. I seem to rememeber there were certain common patches between the two but I don't remember which ones, and it's also possibly that I replied by accident to the wrong message in the series or that I mistook one patch for another when comparing them :-/ Ah, I seem to have found it, there's indeed the 3562 in my local patches and the 3528 as well, both of which rely on the 3568 one: commit a68433c468c8a9d4789641eb6a40ae571fb7f01f Author: Finley Xiao Date: Tue Apr 15 18:32:03 2025 +0800 nvmem: rockchip-otp: Add support for RK3562 This adds the necessary data for handling otp on the rk3562. Signed-off-by: Finley Xiao Signed-off-by: Kever Yang Reviewed-by: Heiko Stuebner Signed-off-by: Jonas Karlman and: commit 249b07e24d3d1d47b7ec23d5f09a56837b66d7f5 Author: Jonas Karlman Date: Sun Mar 16 00:05:45 2025 +0000 nvmem: rockchip-otp: Add support for RK3528 Add support for the OTP controller in RK3528. The OTPC is similar to the OTPC in RK3562 and RK3568, exept for a missing phy clock and reset. Signed-off-by: Jonas Karlman It's very possible that I visually mistook one for the other when responding to the series, and if so, I'm really sorry about that! The former relies on rk3568_data and the latter on rk3528_data, which is defined like this: +static const char * const rk3528_otp_clocks[] = { + "otp", "apb_pclk", "sbpi", +}; + +static const struct rockchip_data rk3528_data = { + .size = 0x80, + .word_size = sizeof(u16), + .clks = rk3528_otp_clocks, + .num_clks = ARRAY_SIZE(rk3528_otp_clocks), + .reg_read = rk3568_otp_read, +}; Looks like the patches originally come from this branch that I manually cherry-picked: https://github.com/Kwiboo/linux-rockchip/commits/next-20250620-rk3528 I have one extra E20C that's not yet in prod if you're interested in me running some specific tests. It will not happen quickly but just let me know if I can help, as it's a nice little machine. Willy