From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD7CC13C918 for ; Thu, 5 Feb 2026 12:57:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770296272; cv=none; b=uYeYyFFWBFl4mCfkqkQWNXB3xImVpJvkNjwDbdj+h4z/dKcO0wWmpcXbJBvT0JxSmnnzaBPjMPIx0cBUVt6PUZIS+LJLyqiaGr1zFkET9FhR23JQFRle4I93WQaIcNy43dCS7tg+jwmwmAhgsMJHhjqD3Xgsw40hykE70MqpVZ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770296272; c=relaxed/simple; bh=u408GEn+r7rpYool1ipTSvS5yUGjc6/mxdNfTwVEj5o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HpYgVOlYE+bNwYoiNub0ek+EgR/0OSk1/D4WR1zjY9BmArAyQv/EysPPgexbJCjcz+jy84wXrPFTwEOQewUrd72aiPOJhx2zyy4hqOoa69NjTPNG7TgOtNMVHbqZqTj30jVSuWUX83a05t/8nVF/WbLW7aXszkvdjAIYiqXvCNY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pt9xM+Fh; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pt9xM+Fh" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-42fb0fc5aa9so740301f8f.1 for ; Thu, 05 Feb 2026 04:57:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770296270; x=1770901070; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=w1syDhd5NfaU3goDOmun9W28zqJO0qiGwzzr5rkRfKM=; b=Pt9xM+FhVTCYSJHba6Pd1DerbcpE2xMJJjKsRnvAIsbWufGsHscy3IWgMa6c8Z2f0a hxq1RBypardq9CeLFVbXR6evB3TCpDpT7hHdnw8S0S0i7xASuBnMKquZhazZf5Kr/6MH mHYUR/SjFRuzwykB9zYIAuEyNxicGC5/I9dAeZeI5mVgkxPksnhEFZCLvL8Tm6E5Qt7F //Xio5pWUYxh1ZKij3lcDTnPEaKesfYz7WwPk3BD3ECWwwIHTqR8/hFV4QDDeIj0goFv sdU4JTj6CHAHsLeE9HaE6af/DLPUpRaQsEtImPQM8vziyAoepOARiprfI1YIKqhqHQsT vIvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770296270; x=1770901070; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w1syDhd5NfaU3goDOmun9W28zqJO0qiGwzzr5rkRfKM=; b=JvbVmaSNeZeP9NWUcm38o97UuqeHzv0c8rXZioARfw4taXqKh/tLm+2ydW9Q3KwhbE cR3ptWOPm8OoYacndbxjnq59vjIVfkZiHXFGc9fLn6ORwnPUryP7C0O8Ax4Up62Wov+X ELddc3Q7U13zfgP59s4BLsMc8J518eCM8bJSHOBxTh/z7k4JUqC+Fry0trIolYZyT+P3 BUGkRwM2+6Eq4upIjfThhvyFUVQN5iZsllhsa045b+mQJWlLTZE6G7KVWLnU/1Hwjl8x idPBfaso5V/HR0faxMbS0YZKWS9MV3NPyCeaBXPhHz0GvSHO3n91OlrB3usOyw+VLqQp l23g== X-Forwarded-Encrypted: i=1; AJvYcCV3GZfdFgp6qf1TXSsG1i7foRaXkn6QRoxVrqgiae8s+PCt60XrAiD6ZxMiuuaU8S8Cn4Tgu1+0nbnZXtY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5j84gL6//PPxO4U318bD58JvGMiM1HXvDcjmXPF9mrQvpGjkY rDPx673TeNDqT6aeLYXLbo51iUB6Zc2od6My4YPPKPGrYRoopBR4oXMT X-Gm-Gg: AZuq6aIMLvDPcL48/tAf3ZerC95QIFWXsTaM54sHSKjY3BkO2Uq9TRGpKLrohOSsSJC cUr/l/QT+jpco1dBUkZs5F+2adpUjUrX7F687RH4GZEk73eAW5p8CZYeAwsK01MSlIYRFu0caE1 5wvMvF/voN7QRl3fuJK9ZY9z6L8knLrtB9g2ZSZhJ7XYhzwCiDd1zEiknPhqgXVGYwuf00YQBI5 gS2prWFEWR0jPXjHn3mQ5OJAeAAfJTC6R39lSoMa+O4OfWbux4R5TC4Sl6BsP5Z1cp6ALIN7MTT owdncTJ4KSrna4MTf5vMww9VP+8AUOOH/2//4rXMGEGLNGxTmApHT+zRFA0naLzY4/SjvI40TZh qP/KgwftcKi/PyKFnc303u4HxO2PyDQHW9E4/DtqhId6tT+WffX0cRwedQcomLEBvhTBbKbwYy4 BlT6WGeS26ky/G8yeuE/+JL2U= X-Received: by 2002:a05:6000:3110:b0:435:92d3:d9b4 with SMTP id ffacd0b85a97d-436180318bfmr9531080f8f.26.1770296269844; Thu, 05 Feb 2026 04:57:49 -0800 (PST) Received: from fedora ([138.199.6.232]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43618064844sm13730468f8f.42.2026.02.05.04.57.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Feb 2026 04:57:49 -0800 (PST) Date: Thu, 5 Feb 2026 13:57:46 +0100 From: Filippo =?utf-8?B?TXVzY2hlcsOg?= To: Andi Shyti Cc: jdelvare@suse.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] i2c: amd8111: switch to devm_ functions Message-ID: References: <20260202131304.8524-1-filippo.muschera@gmail.com> <20260202131304.8524-2-filippo.muschera@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Feb 05, 2026 at 12:03:51PM +0100, Andi Shyti wrote: > Hi Filippo, > > On Mon, Feb 02, 2026 at 02:13:04PM +0100, Filippo Muscherà wrote: > > Use devm_kzalloc() to manage the memory allocation of the smbus structure > > and devm_request_region() to manage the I/O port region. > > Merged to i2c/i2c-host-2. > > Just a few notes for the next time: > > 1. I prefer two different patches for devm_kzalloc() and > devm_request_region(). > > 2. For series with more than one patch, I'd like to have a cover > letter to introduce the series. > > Thanks, > Andi Hi Andi, Thanks for the review and the notes. I'll make sure to follow these guidelines for my future submissions. Thanks, Filippo