From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Marcelo Schmitt <marcelo.schmitt@analog.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
jic23@kernel.org, michael.hennerich@analog.com,
nuno.sa@analog.com, eblanc@baylibre.com, dlechner@baylibre.com,
andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, corbet@lwn.net, marcelo.schmitt1@gmail.com,
Trevor Gamblin <tgamblin@baylibre.com>,
Axel Haslam <ahaslam@baylibre.com>
Subject: Re: [PATCH v7 5/8] iio: adc: ad4030: Add SPI offload support
Date: Thu, 5 Feb 2026 19:11:24 +0200 [thread overview]
Message-ID: <aYTPPNE-GxkeokjV@smile.fi.intel.com> (raw)
In-Reply-To: <aYTOmc32Q4Iuv-Gi@smile.fi.intel.com>
On Thu, Feb 05, 2026 at 07:08:48PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 05, 2026 at 01:48:40PM -0300, Marcelo Schmitt wrote:
...
> > + cnv_wf.period_length_ns = DIV_ROUND_CLOSEST(NSEC_PER_SEC, cnv_rate_hz);
> > + offload_period_ns = DIV_ROUND_CLOSEST(NSEC_PER_SEC, freq_hz);
^^^ for the context to the below remark.
...
> > + config->periodic.frequency_hz = DIV_ROUND_UP_ULL(NSEC_PER_SEC,
> > + offload_period_ns);
>
> The point of having _ULL version here is...?
And for the consistency with the above this should be HZ_PER_GHZ.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-05 17:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 16:46 [PATCH v7 0/8] Add SPI offload support to AD4030 Marcelo Schmitt
2026-02-05 16:47 ` [PATCH v7 1/8] dt-bindings: iio: adc: adi,ad4030: Reference spi-peripheral-props Marcelo Schmitt
2026-02-05 16:47 ` [PATCH v7 2/8] Docs: iio: ad4030: Add double PWM SPI offload doc Marcelo Schmitt
2026-02-05 16:48 ` [PATCH v7 3/8] dt-bindings: iio: adc: adi,ad4030: Add PWM Marcelo Schmitt
2026-02-05 16:48 ` [PATCH v7 4/8] iio: adc: ad4030: Use BIT macro to improve code readability Marcelo Schmitt
2026-02-05 17:02 ` Andy Shevchenko
2026-02-05 16:48 ` [PATCH v7 5/8] iio: adc: ad4030: Add SPI offload support Marcelo Schmitt
2026-02-05 17:08 ` Andy Shevchenko
2026-02-05 17:11 ` Andy Shevchenko [this message]
2026-02-05 16:48 ` [PATCH v7 6/8] dt-bindings: iio: adc: adi,ad4030: Add ADAQ4216 and ADAQ4224 Marcelo Schmitt
2026-02-05 18:42 ` Rob Herring (Arm)
2026-02-06 13:05 ` Rob Herring
2026-02-06 13:21 ` Marcelo Schmitt
2026-02-05 16:49 ` [PATCH v7 7/8] iio: adc: ad4030: Add support for " Marcelo Schmitt
2026-02-05 16:53 ` Andy Shevchenko
2026-02-05 16:49 ` [PATCH v7 8/8] iio: adc: ad4030: Support common-mode channels with SPI offloading Marcelo Schmitt
2026-02-05 19:43 ` [PATCH v7 0/8] Add SPI offload support to AD4030 Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYTPPNE-GxkeokjV@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=ahaslam@baylibre.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=eblanc@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=tgamblin@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox