From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEC4A32D7F9 for ; Thu, 5 Feb 2026 22:38:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770331091; cv=none; b=Pt8uvugSa3ckDtpjKKqtLStXlGnyvbDcLia4FJiLGocbFxoCxw6PwrNaumtitbjp+bSFe+nTT41qFEIbGK5fBS8PlKfRF2t3Yra0vjhnvKXdOAqEFislOC0GhvmgoIMfbogYxlbqzJsBBZWCibzTXRmvszMDkMHD3+p8DD5/A6s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770331091; c=relaxed/simple; bh=YHuWLI7vqpaFUVgA48uLnmqh4lvi/ESzazpPvwDrPfI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=WBk6VOK/8wom4NOmgAZfCA4fpFK9FuL3r2be1wlQ4DQd3hP6geKvuiHX0nNbVz5n2QOOf59/1H1QG3QF+QQjucMGmYC9GyV/f1c4KMqGFb8pdWYAoql0/6GF0hL2416SBdvbK62ctTe7da1P9FxtN1JHJa8Rmx8dbtmjatLmLMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ZjUeSYzm; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ZjUeSYzm" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2a94369653aso12719625ad.1 for ; Thu, 05 Feb 2026 14:38:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1770331090; x=1770935890; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=l7Cxq1heXUBi49e9Wexr9Rtb/4PcjxqgXg/oc/Il7q8=; b=ZjUeSYzmm9CY+jC2xOAP4Wk0gtbYmcqA9iWt5foTDR+MUS5ejzrON0tMFv2IR1FUbT pHtXYWcm8Ko3IX7KjfuhVtHw5Lx5UGnUrrV62BmkzgIfmEnvIVCSJP2tRVHWE87UWoEi xSQWoINfyOb6GNI5KK7u8bQZRFTLiVA57vxK9OPAYss7kws6sg8BOonXgREm4oENKVj/ J1DZJH4uL3XW2nraGq7QiXerF9tNltp2SYnS0byN0neScNResCUdr0ZCaMWSAY81izRK MPjmqBt8ef3KsUDSNMVMGPKjK2IW2dQ/2ZSdhpjqu26S8VS/8Lx4Hz6qpJ7mgsQIYDsR pjpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770331090; x=1770935890; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l7Cxq1heXUBi49e9Wexr9Rtb/4PcjxqgXg/oc/Il7q8=; b=AF16gZ/9TDW7cfbFXUaiagfoIxgeYaGlQtdmSdhRxKee7fjTqcY2DTjkjgKpAg4yDz bpZw8eRojGdSIaCCtGWKNcftTQE1UQpchGaVGvtM3apf/La3jE16GaYZgZHkySFb5nVP tr+hggBNu8X6aAaP07QtqDM5dIMIKYPDAuPCmHpA+v0eZRRmKA36cxT6S/0X8GF/cjio 6akYIDgbBBwtV1zfszwjs+krGJLUqKUowrWgUkN7TFK+4QwAoqFp09I26cGaeuQKIIgy +kzp05OA+4YfZSCvmh4lQmkSb1ugIgL7VH+NVmpjYsC8Y3dDF4olreRT5/mRhO8EYm/A W4RA== X-Forwarded-Encrypted: i=1; AJvYcCWId5lN1w7mXOxhGx1InSsrIeLtFuyZoACZzZmpLvSmHjjrJgDN77Ratz14tfuEpcSpl64CWFKZYXXXC7c=@vger.kernel.org X-Gm-Message-State: AOJu0YzxKzAeRKeaFh4T5yr825v2lotKLwbP6L824IA5txPI4+qt0Rxl +4b7jC1MY9+eentfnOs23xBae7iSN78ca+ZoZhAIsp4FToCsiaM1CkZh045nW+e2EIMpLPjVftb i47oYsQ== X-Received: from plkn1.prod.google.com ([2002:a17:902:6a81:b0:2a9:2ce4:2399]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:2f08:b0:29b:e512:752e with SMTP id d9443c01a7336-2a952232dc0mr6704095ad.47.1770331090264; Thu, 05 Feb 2026 14:38:10 -0800 (PST) Date: Thu, 5 Feb 2026 14:38:08 -0800 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260129011517.3545883-1-seanjc@google.com> <20260129011517.3545883-10-seanjc@google.com> Message-ID: Subject: Re: [RFC PATCH v5 09/45] KVM: x86: Rework .free_external_spt() into .reclaim_external_sp() From: Sean Christopherson To: Yan Zhao Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, Kai Huang , Rick Edgecombe , Vishal Annapurve , Ackerley Tng , Sagi Shahar , Binbin Wu , Xiaoyao Li , Isaku Yamahata Content-Type: text/plain; charset="us-ascii" On Thu, Feb 05, 2026, Yan Zhao wrote: > On Wed, Feb 04, 2026 at 05:45:39PM +0800, Yan Zhao wrote: > > On Wed, Jan 28, 2026 at 05:14:41PM -0800, Sean Christopherson wrote: > > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > > > index d12ca0f8a348..b35a07ed11fb 100644 > > > --- a/arch/x86/include/asm/kvm_host.h > > > +++ b/arch/x86/include/asm/kvm_host.h > > > @@ -1858,8 +1858,8 @@ struct kvm_x86_ops { > > > u64 mirror_spte); > > > > > > /* Update external page tables for page table about to be freed. */ > > > - int (*free_external_spt)(struct kvm *kvm, gfn_t gfn, enum pg_level level, > > > - void *external_spt); > > > + void (*reclaim_external_sp)(struct kvm *kvm, gfn_t gfn, > > > + struct kvm_mmu_page *sp); > > Do you think "free" is still better than "reclaim" though TDX actually > > invokes tdx_reclaim_page() to reclaim it on the TDX side? > > > > Naming it free_external_sp can be interpreted as freeing the sp->external_spt > > externally (vs freeing it in tdp_mmu_free_sp_rcu_callback(). This naming also > > allows for the future possibility of freeing sp->external_spt before the HKID is > > freed (though this is unlikely). > Oh. I found there's a free_external_sp() in patch 20. > > So, maybe reclaim_external_sp() --> remove_external_spt() ? > > Still think "sp" is not good :) I think my vote would be for reclaim_external_spt(). I don't like "remove", because similar to "free", I think most readers will assume success is guaranteed.