From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E2F3223DE9 for ; Fri, 6 Feb 2026 01:38:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770341926; cv=none; b=spmloOeQRZWSUChGV0uN44YGMQsP7JYbuXTAO6QchE78jO6pXpYtG3soHdAmD73XUJpzW86u5GTeGZrOLGV21ZP6TrYiNcdnzv+zoSN5SPA+ODPsbLEupila/ufCKX7IeP9shy/g5vFc5ZJkRuX/R+2yukkA4xhpfjaBiEbZN7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770341926; c=relaxed/simple; bh=IbopyEVAw0lcGmp+LREMylxfP9DIqwwNS3V/is5hqb0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=g482Z6xX0sCBU/E1a8rBzU0tOfexTOHKX8Bl+7lbFLgstPsQJgnOH6+lfUgxmyP2UjFByvpoWbZNmEkDJutEY9ub5aUIiMZyXAE7ci1u+IdmjzVrLKojUvGzo5sNBp4MINjDZuOuQhar3WIsINMbnsWafZ5NaLhVi9SZzkdh4iw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=rub3yRVN; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rub3yRVN" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2a9474f4975so2375005ad.3 for ; Thu, 05 Feb 2026 17:38:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1770341926; x=1770946726; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=xnh7MWyoEPXlnntK36ZUb93K9kbxOaxGRlGHFywiAKY=; b=rub3yRVN2gn8W644+N6b7COsd7xOxabt763fRa9FQPB/QFvYbI4ynDYmcl8KHna3l1 XASNwxsHlgFkzmI2n+ivBXCwiBNBtTpwItFzZWUZ2Eea7i20JCVjj8DV+YTmKZJg8gM9 YAu8BMDBrsddCZHrOhdxk/B3R7aaB3MCGwqSE1M8kE3VDrxbvHhiW22DLXazAnL2i+qn ociPFp2r+5FrDsd/Qjk5jNyT2c+QbQ2U48CC6h190Cq8pxie/uaDNSObX3GBJZt9RL0l vb10MvCQAyfCDmDaaRSbqEd+N071TVkCTMoP5DlH4JMmiiX9EyO0clNtEUQfXPXGrrnZ va9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770341926; x=1770946726; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xnh7MWyoEPXlnntK36ZUb93K9kbxOaxGRlGHFywiAKY=; b=cWZ3fNBOCLVPckt8XE6T/tCTKLOrLu4MBlmRffOaSuOKIuDi1GOmEianUZkH4jJC8l FefdstmAa3cxYGAycawMSl6Ngm+WMykqN3Wj4s9dewKn/yEYRSuFSVY8vdfa6/Q7J6Db Fm7jKFM5RRgyaH7XMsYl+4YaA6hu0L1sXmHp8oGAA241bnXWJJC6POgPiJoYai0Z8H5P 0yHb/knPU/vToRzgVbeqx7L8TSI3O7nwb5D23slLQgjpRP5gehc1HA75+e5H27mZzRLC DuJMrRd/yXdZuLKY9wNP+p/0/iH3F0hSaV+eplyO1vE/NgEU8/E/m1Pc/MEFBt1XrBLW 9UFg== X-Forwarded-Encrypted: i=1; AJvYcCX2HIwPunEkNbvqYTHqUk0KMYBgtvfsvbRiopaMT61MmxHU8XLYzZOxb8B+8dwt0egTyA54EjIYlui88Ps=@vger.kernel.org X-Gm-Message-State: AOJu0YwPG2Tq8468KDksbwjVM/WJb4Oe7ALc97BkCPi3627zsueKvnfu FqzsH1xi0O6s96YzNRa0gnWrlyamEDVlmTNwafi4AhSUaLy+dqCfv6npWFrMoRLRSkfSs3Kg/KW ZRLeWtA== X-Received: from plhz4.prod.google.com ([2002:a17:902:d9c4:b0:29f:25cf:e576]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:cf0a:b0:2a8:ff32:5f96 with SMTP id d9443c01a7336-2a95165a927mr11461595ad.13.1770341925840; Thu, 05 Feb 2026 17:38:45 -0800 (PST) Date: Thu, 5 Feb 2026 17:38:44 -0800 In-Reply-To: <20260115011312.3675857-1-yosry.ahmed@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260115011312.3675857-1-yosry.ahmed@linux.dev> Message-ID: Subject: Re: [PATCH v4 00/26] Nested SVM fixes, cleanups, and hardening From: Sean Christopherson To: Yosry Ahmed Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Thu, Jan 15, 2026, Yosry Ahmed wrote: > Yosry Ahmed (26): > KVM: SVM: Switch svm_copy_lbrs() to a macro > KVM: SVM: Add missing save/restore handling of LBR MSRs > KVM: selftests: Add a test for LBR save/restore (ft. nested) > KVM: nSVM: Always inject a #GP if mapping VMCB12 fails on nested VMRUN > KVM: nSVM: Triple fault if mapping VMCB12 fails on nested #VMEXIT > KVM: nSVM: Triple fault if restore host CR3 fails on nested #VMEXIT > KVM: nSVM: Drop nested_vmcb_check_{save/control}() wrappers > KVM: nSVM: Call enter_guest_mode() before switching to VMCB02 > KVM: nSVM: Make nested_svm_merge_msrpm() return an errno > KVM: nSVM: Call nested_svm_merge_msrpm() from enter_svm_guest_mode() > KVM: nSVM: Call nested_svm_init_mmu_context() before switching to > VMCB02 > KVM: nSVM: Refactor minimal #VMEXIT handling out of > nested_svm_vmexit() > KVM: nSVM: Unify handling of VMRUN failures with proper cleanup > KVM: nSVM: Clear EVENTINJ field in VMCB12 on nested #VMEXIT > KVM: nSVM: Drop the non-architectural consistency check for NP_ENABLE > KVM: nSVM: Add missing consistency check for nCR3 validity > KVM: nSVM: Add missing consistency check for hCR0.PG and NP_ENABLE > KVM: nSVM: Add missing consistency check for EFER, CR0, CR4, and CS > KVM: nSVM: Add missing consistency check for event_inj > KVM: SVM: Rename vmcb->nested_ctl to vmcb->misc_ctl > KVM: SVM: Rename vmcb->virt_ext to vmcb->misc_ctl2 > KVM: SVM: Use BIT() and GENMASK() for definitions in svm.h > KVM: nSVM: Cache all used fields from VMCB12 > KVM: nSVM: Restrict mapping VMCB12 on nested VMRUN > KVM: nSVM: Sanitize control fields copied from VMCB12 > KVM: nSVM: Only copy NP_ENABLE from VMCB01's misc_ctl All in all, looks good. A few comments, but I don't anticipate a big jump in the patch count :-) Note, make sure to rebase on the latest kvm-x86 next, there are a handful of minor conflicts.